- 17 12月, 2014 12 次提交
-
-
由 Rafael Mendonça França 提交于
Improving Method Chaining section [ci skip]
-
由 Andrey Nering 提交于
-
由 Rafael Mendonça França 提交于
assert template should raise ArgumentError for unsupported layout types
-
由 Zachary Scott 提交于
"backoffice" -> "back office", "lookup" -> "look up" [ci skip]
-
由 Carsten Wirth 提交于
-
由 Jon Atack 提交于
"Lookup" is a noun, but not a verb. The verb is "look up". [skip ci]
-
由 Rafael Mendonça França 提交于
Add a code checking about file or not to the rails db command
-
由 Rafael Mendonça França 提交于
allow reseting of request variants
-
由 Rafael Mendonça França 提交于
Add test for ActiveModel `after_validation`, `after_` and `around_` callbacks returning false
-
由 Rafael Mendonça França 提交于
Test to ensure content_tag works when fixing #17661
-
由 Rafael Mendonça França 提交于
Add test for `:skip_after_callbacks_if_terminated`
-
由 Jon Atack 提交于
After c2fe0938, which was reverted yesterday, there will likely be future PRs to address #17661. The test `actionview/test/template/capture_helper_test.rb #test_capture_returns_nil_if_the_returned_value_is_not_a_string` should have errored with c2fe0938, but it was rewritten in the PR to not raise. My guess is that it may have seemed irrelevant to the content_tag tests or already covered by them. This test provides additional protection by being in the content_tag test suite to explicitly raise a red flag in future cases. It foregoes some redundancy for safety — at least until #17661 is closed.
-
- 16 12月, 2014 28 次提交
-
-
由 Xavier Noria 提交于
Improve section in constant autoload guide
-
由 Rafael Mendonça França 提交于
Remove misleading test: around_action return false
-
由 Arthur Nogueira Neves 提交于
English fix [ci skip]
-
由 George Millo 提交于
-
由 Eileen M. Uchitelle 提交于
Improve grammar
-
由 Jon Atack 提交于
[skip ci]
-
由 Timo Schilling 提交于
The current implementation of `variants=` don't allow a resetting to nil, wich is the default value. This results in the following code smell: ```ruby case request.user_agent when /iPhone/ request.variants = :phone when /iPad/ request.variants = :ipad end ``` With the ability to reset variants to nil, it could be: ```ruby request.variants = case request.user_agent when /iPhone/ :phone when /iPad/ :ipad end ```
-
由 Xavier Noria 提交于
Constant autoload grammar fix
-
由 Jon Atack 提交于
[skip ci]
-
由 yuki3738 提交于
-
由 Jon Atack 提交于
[skip ci]
-
由 Yves Senn 提交于
-
由 Abdelkader Boudih 提交于
[ci skip]
✂ blank lines between list items. -
由 Yves Senn 提交于
[ci skip] /cc @sgrif @zzak Conflicts: activerecord/CHANGELOG.md
-
由 Juanito Fatas 提交于
-
由 Xavier Noria 提交于
I think "What" is was fine, "The purpose of" assumes the reader knows such thing exists. "What is" is fine, and also matches the following "What is require_dependency".
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Zachary Scott 提交于
4.2.0", then they should have no problems hacking with Rails. [ci skip] If they do, then its a bug and it should be reported.
-
由 Zachary Scott 提交于
Improving tips about installation in the guides [ci skip]
-
由 Zachary Scott 提交于
-
https://github.com/jonatack/rails由 Zachary Scott 提交于
[ci skip] Conflicts: guides/source/constant_autoloading_and_reloading.md
-
由 Arthur Nogueira Neves 提交于
Counter cache Rails guides fix
-
由 Zachary Scott 提交于
-
由 Zachary Scott 提交于
Adding method chaining section on ActiveRecord querying guide [ci skip]
-
由 Zachary Scott 提交于
[ci skip]
-
由 Zachary Scott 提交于
Improve autoload_paths section [ci skip]
-
由 Steve Lounsbury 提交于
You need to specify the counter_cache option on the has_many side of the association when using a custom counter cache column. This is documented on the has_many association here: http://apidock.com/rails/ActiveRecord/Associations/ClassMethods/has_many [ci skip]
-