- 21 8月, 2009 1 次提交
-
-
由 Jeremy Kemper 提交于
-
- 19 8月, 2009 5 次提交
-
-
由 taryn 提交于
Similar to Active Record - it will raise ActiveResouce::ResourceInvalid if the resource is not valid (ie if <tt>valid?</tt> returns false) However - does not raise ActiveResource::ResourceNotFound if the callbacks fail (callbacks have not yet been implemented) - it will just try to save and raise if the callbacks all fail. This is not ideal behaviour - but will do until we decide to change the behaviour of save_with_validations to actually raise (rather than catch) the ResourceInvalid exception. Signed-off-by: NJoshua Peek <josh@joshpeek.com>
-
由 taryn 提交于
Active Record does not explode with RecordNotFound if you go looking for a collection of objects - it just returns nil. Thus Active Resource should also not explode. After all - finding no objects that match a set of conditions is not exceptional behaviour - unlike looking for a specific object with a given id (which you'd expect to exist). I've also added documentation to +find+ to reflect this. Signed-off-by: NJoshua Peek <josh@joshpeek.com>
-
由 taryn 提交于
Pulled find-based tests into their own test case. This matches Active Record, and allows us to have one places where all find-tests are located, which will help when adding dynamic finders later. Signed-off-by: NJoshua Peek <josh@joshpeek.com>
-
由 taryn 提交于
Moved all test cases into a new test/cases directory to match Active Record test directory structure. Signed-off-by: NJoshua Peek <josh@joshpeek.com>
-
由 taryn 提交于
Added validations to ActiveResource. Added a smoke test to see if we can add a validation and use it, and add a validates callback and use it. Signed-off-by: NJoshua Peek <josh@joshpeek.com>
-
- 18 8月, 2009 1 次提交
-
-
由 Mike Gunderloy 提交于
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>
-
- 17 8月, 2009 3 次提交
-
-
由 Pratik Naik 提交于
If you're still using it, please install the plugin from git://github.com/rails/sqlite2_adapter.git
-
由 Joshua Peek 提交于
-
由 Joshua Peek 提交于
Cleanup route reloading in tests. Prefer with_routing over using ActionController::Routing::Routes directly
-
- 16 8月, 2009 14 次提交
-
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Jay Pignata 提交于
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>
-
由 Jay Pignata 提交于
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>
-
由 Jeremy Kemper 提交于
-
由 Jay Pignata 提交于
Adding a call to logger from params_parser to give detailed debug information when invalid xml or json is posted [#2481 state:committed] Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>
-
由 Joshua Peek 提交于
-
由 Jeremy Kemper 提交于
-
由 Yehuda Katz 提交于
* request.formats is much simpler now * For XHRs or Accept headers with a single item, we use the Accept header * For other requests, we use params[:format] or fallback to HTML * This is primarily to work around the fact that browsers provide completely broken Accept headers, so we have to whitelist the few cases we can specifically isolate and treat other requests as coming from the browser * For APIs, we can support single-item Accept headers, which disambiguates from the browsers * Requests to an action that only has an XML template from the browser will no longer find the template. This worked previously because most browsers provide a catch-all */*, but this was mostly accidental behavior. If you want to serve XML, either use the :xml format in links, or explicitly specify the XML template: render "template.xml".
-
由 Yehuda Katz 提交于
Caches and cache clearing seems to actually work, but the actual architecture is kind of messy. Next: CLEAN UP.
-
由 Yehuda Katz 提交于
* only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine
-
由 Yehuda Katz 提交于
* Call _evaluate_assigns_and_ivars at the two entry points so we don't have to do a check at every render. * Make template.render viable without having to go through a wrapper method * Remove old TemplateHandler#render(template, local_assigns) path so we don't have to set self.template every time we render a template. * Move Template rescuing code to Template#render so it gets caught every time. * Pull in some tests from Pratik that test render @object in ActionView
-
由 Jatinder Singh 提交于
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>
-
由 Jeremy Kemper 提交于
-
- 15 8月, 2009 2 次提交
-
-
由 Joshua Peek 提交于
-
由 Joshua Peek 提交于
-
- 14 8月, 2009 2 次提交
-
-
由 Joshua Peek 提交于
-
由 Joshua Peek 提交于
-
- 13 8月, 2009 2 次提交
-
-
-
由 José Valim 提交于
-
- 12 8月, 2009 10 次提交
-
-
由 Chad Woolley 提交于
make mysql and postgresql rebuild databases on every CI build, to prevent breakages such as collation and character set changing Signed-off-by: NYehuda Katz <wycats@gmail.com>
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
* Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare!
-
由 Yehuda Katz 提交于
* Tentatively replaced HeaderHash with SimpleHeaderHash, which does not preserve case but does handle converting Arrays to Strings in to_hash. This requires further discussion. * Moved default_charset to ActionDispatch::Response to avoid having to hop over to ActionController. Ideally, this would be a constant on AD::Response, but some tests expect to be able to change it dynamically and I didn't want to change them yet. * Completely override #initialize from Rack::Response. Previously, it was creating a HeaderHash, and then we were creating an entirely new one. There is no way to call super without incurring the overhead of creating a HeaderHash. * Override #write from Rack::Response. Its implementation tracks Content-Length, and doing so adds additional overhead that could be mooted if other middleware changes the body. It is more efficiently done at the top-level server. * Change sending_file to an instance_variable instead of header inspection. In general, if a state is important, it should be set as a property of the response not reconstructed later. * Set the Etag to @body instead of .body. AS::Cache.expand_cache_key handles Arrays fine, and it's more efficient to let it handle the body parts, since it is not forced to create a joined String. * If we detect the default cache control case, just set it, rather than setting the constituent parts and then running the normal (expensive) code to generate the string.
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
Further experimentation. Was able to cut the cost of rendering 100 partials in a collection in half. To discuss: What are the desired semantics (if any) for layouts in a collection. There are no tests for it at present, and I'm not sure if it's needed at all. Deprecated on this branch: `object` pointing at the current object in partials. You can still use the partial name, or use :as to achieve the same thing. This is obviously up for discussion.
-
由 Yehuda Katz 提交于
-