1. 19 8月, 2017 9 次提交
  2. 18 8月, 2017 16 次提交
  3. 17 8月, 2017 15 次提交
    • G
      Merge pull request #30292 from maclover7/jm-ast-purge · d11d629f
      George Claghorn 提交于
      Add missing test for Blob#purge
      d11d629f
    • G
      Merge pull request #30293 from maclover7/jm-ast-logs · 8a0c69ee
      George Claghorn 提交于
      Use nil Logger for tests
      8a0c69ee
    • J
      Add missing test for Blob#purge · 267fdcc4
      Jon Moss 提交于
      267fdcc4
    • J
      Merge pull request #30295 from ohbarye/follow_up_to_28058 · d1c03d3f
      Jon Moss 提交于
      Remove obsolete explanation about passing string to `:if` and `:unless` [ci skip]
      d1c03d3f
    • J
      Capitalize Redis · f84019cd
      Jon Moss 提交于
      [ci skip]
      f84019cd
    • O
      Remove obsolete explanation · 8779e33a
      ohbarye 提交于
      about passing string to `:if` and `:unless`.
      This is a follow up to https://github.com/rails/rails/pull/28058 [ci
      skip]
      8779e33a
    • Y
      Move `test_index_is_created_for_both_timestamps` to `TimestampsWithoutTransactionTest` · 334d5240
      Yasuo Honda 提交于
      This commit addresses these failures when the backend RDBMS executes implicit commit for DDL like MySQL and Oracle.
      
      ```ruby
      $ ARCONN=mysql2 bin/test test/cases/integration_test.rb test/cases/timestamp_test.rb --seed 58225 -n '/^(?:TimestampTest#(?:test_index_is_created_for_both_timestamps)|IntegrationTest#(?:test_cache_key_for_newer_updated_at|test_cache_key_format_for_existing_record_with_updated_at|test_cache_key_format_for_existing_record_with_updated_at_and_custom_cache_timestamp_format))$/' -v
      Using mysql2
      Run options: --seed 58225 -n "/^(?:TimestampTest#(?:test_index_is_created_for_both_timestamps)|IntegrationTest#(?:test_cache_key_for_newer_updated_at|test_cache_key_format_for_existing_record_with_updated_at|test_cache_key_format_for_existing_record_with_updated_at_and_custom_cache_timestamp_format))$/" -v
      
      TimestampTest#test_index_is_created_for_both_timestamps = 0.19 s = .
      IntegrationTest#test_cache_key_format_for_existing_record_with_updated_at = 0.05 s = F
      IntegrationTest#test_cache_key_format_for_existing_record_with_updated_at_and_custom_cache_timestamp_format = 0.02 s = F
      IntegrationTest#test_cache_key_for_newer_updated_at = 0.01 s = F
      
      Finished in 0.272880s, 14.6585 runs/s, 14.6585 assertions/s.
      
        1) Failure:
      IntegrationTest#test_cache_key_format_for_existing_record_with_updated_at [/home/yahonda/git/rails/activerecord/test/cases/integration_test.rb:111]:
      --- expected
      +++ actual
      @@ -1 +1 @@
      -"developers/1-20170717135609430848"
      +"developers/1-20170817135609283207"
      
        2) Failure:
      IntegrationTest#test_cache_key_format_for_existing_record_with_updated_at_and_custom_cache_timestamp_format [/home/yahonda/git/rails/activerecord/test/cases/integration_test.rb:116]:
      --- expected
      +++ actual
      @@ -1 +1 @@
      -"cached_developers/1-20170717135609"
      +"cached_developers/1-20170817135609"
      
        3) Failure:
      IntegrationTest#test_cache_key_for_newer_updated_at [/home/yahonda/git/rails/activerecord/test/cases/integration_test.rb:147]:
      --- expected
      +++ actual
      @@ -1 +1 @@
      -"developers/1-20170717145609430848"
      +"developers/1-20170817135609283207"
      
      4 runs, 4 assertions, 3 failures, 0 errors, 0 skips
      $
      ```
      
      `ActiveRecord::TestCase::TimestampTest#test_index_is_created_for_both_timestamps`
      calls`ActiveRecord::TestCase::TimestampTest#setup` which updates `updated_at` column value.
      
      ```ruby
          @developer = Developer.first
          ... snip ...
          @developer.update_columns(updated_at: Time.now.prev_month)
      ```
      
      This transaction expected to be rolled back, but if the backend RDBMS like MySQL perfomes
      implicit commit when DDL executed, this transacion is committed by `create table` statement
      inside `ActiveRecord::TestCase::TimestampTest#test_index_is_created_for_both_timestamps`.
      
      It causes these failures above which expect `update_at` column value are not changed(rollbacked).
      334d5240
    • J
      Use nil Logger for tests · 07a13f7a
      Jon Moss 提交于
      Makes tests much more quietly, as opposed to the enormous amount of
      logging that appears right now. This setting is used in AJ, as well as
      other frameworks.
      
      Output from test run:
      
      ```
      
      .........................................................
      
      Finished in 3.003355s, 18.9788 runs/s, 45.2827 assertions/s.
      57 runs, 136 assertions, 0 failures, 0 errors, 0 skips
      ```
      07a13f7a
    • B
    • R
      Temporarily point to a fork of SDoc · 6db4cf9b
      Robin Dupret 提交于
      This fork brings:
      
      * A tiny refresh of the default theme.
      * SEO tags to class files.
      * The removal of HTML tags from search results.
      * Some general template clean-up (HTML 5, removal of the jQuery
        effect library, etc.).
      * A speed up of the generation time (by ~30 seconds).
      6db4cf9b
    • M
      Encrypt the IRC notification setting, so it's not used on forks · 251d3f91
      Matthew Draper 提交于
      The value isn't actually secret, so I've kept it as a comment.
      251d3f91
    • K
      Merge pull request #30287 from y-yagi/use_queue_adapter_name_to_get_adapter_name · 8d7c0052
      Kasper Timm Hansen 提交于
      Use `ActiveJob::Base.queue_adapter_name` to get adapter name
      8d7c0052
    • R
      Merge pull request #30288 from y-yagi/bump_thor_and_blade · 9d59193e
      Rafael França 提交于
      Bump `thor` and `blade`
      9d59193e
    • Y
      Bump `thor` and `blade` · bad08d86
      yuuji.yaginuma 提交于
      For test with latest thor.
      bad08d86
    • M
      faster implementation of Hash#deep_merge · 2eacb1c3
      M. Simon Borg 提交于
      add missing newline
      
      call #deep_merge instead of #dup.deep_merge!
      
      make variable and parameter naming more consistent
      
      change `_key` to `key`
      
      faster implementation of Hash#deep_merge
      2eacb1c3