1. 18 8月, 2015 1 次提交
  2. 11 6月, 2015 1 次提交
  3. 11 3月, 2015 1 次提交
  4. 03 3月, 2015 1 次提交
  5. 18 2月, 2015 1 次提交
  6. 12 2月, 2015 1 次提交
  7. 08 2月, 2015 1 次提交
    • S
      rm `Type#number?` · 1492e83e
      Sean Griffin 提交于
      This predicate is only used in `query_attribute`, and is relatively easy
      to remove without adding a bunch of is a checks.
      1492e83e
  8. 03 2月, 2015 1 次提交
  9. 31 1月, 2015 1 次提交
  10. 22 1月, 2015 1 次提交
  11. 19 1月, 2015 1 次提交
  12. 04 1月, 2015 1 次提交
    • R
      Prefer `array?` rather than `array` · 3225ebfa
      Ryuta Kamizono 提交于
      Slightly refactoring `PostgreSQLColumn`. `array` should be readonly.
      `default_function` should be initialized by `super`. `sql_type` has been
      removed `[]`. Since we already choose to remove it we should not change.
      3225ebfa
  13. 06 11月, 2014 1 次提交
  14. 05 11月, 2014 1 次提交
  15. 25 7月, 2014 1 次提交
  16. 07 7月, 2014 1 次提交
    • S
      Remove the `text?` predicate from the type objects · 35592307
      Sean Griffin 提交于
      This was only used for uniqueness validations. The first usage was in
      conjunction with `limit`. Types which cast to string, but are not
      considered text cannot have a limit. The second case was only with an
      explicit `:case_sensitive => true` option given by the user.
      35592307
  17. 30 6月, 2014 1 次提交
  18. 26 6月, 2014 1 次提交
    • S
      Consolidate testing of update_all type casting · 58d38d6d
      Sean Griffin 提交于
      We have several test cases on "tricky" types that are essentially
      testing that `update_all` goes through the same type casting behavior as
      a normal assignment + save. We recently had another case to add this
      test for another type in https://github.com/rails/rails/pull/12742.
      
      Rather than testing this separately for every type which is "tricky"
      when round tripping, let's instead have a fairly exhaustive test that
      ensures we're getting the correct values at every step for `update_all`.
      Given the structure of the code now, we can be confident that if the
      type is correct, and `update_all` is type casting correctly, we're going
      to get the right behavior for all types.
      58d38d6d
  19. 18 6月, 2014 2 次提交
    • S
      Don't type cast the default on the column · 4d3e88fc
      Sean Griffin 提交于
      If we want to have type decorators mess with the attribute, but not the
      column, we need to stop type casting on the column. Where possible, we
      changed the tests to test the value of `column_defaults`, which is
      public API. `Column#default` is not.
      4d3e88fc
    • S
      Don't assume that Hstore columns have always changed · d9812729
      Sean Griffin 提交于
      HStore columns come back from the database separated by a comma and a
      space, not just a comma. We need to mirror that behavior since we
      compare the two values.
      
      Also adds a regression test against JSON to ensure we don't have the
      same bug there.
      d9812729
  20. 14 6月, 2014 1 次提交
  21. 10 6月, 2014 2 次提交
    • S
      Rename `type_cast` to `type_cast_from_database` · d24e6407
      Sean Griffin 提交于
      In some cases there is a difference between the two, we should always
      be doing one or the other. For convenience, `type_cast` is still a
      private method on type, so new types that do not need different behavior
      don't need to implement two methods, but it has been moved to private so
      it cannot be used accidentally.
      d24e6407
    • S
      Make `_before_type_cast` actually be before type cast · c93dbfef
      Sean Griffin 提交于
      - The following is now true for all types, all the time
        - `model.attribute_before_type_cast == given_value`
        - `model.attribute == model.save_and_reload.attribute`
        - `model.attribute == model.dup.attribute`
        - `model.attribute == YAML.load(YAML.dump(model)).attribute`
      - Removes the remaining types implementing `type_cast_for_write`
      - Simplifies the implementation of time zone aware attributes
      - Brings tz aware attributes closer to being implemented as an attribute
        decorator
      - Adds additional point of control for custom types
      c93dbfef
  22. 04 6月, 2014 2 次提交
  23. 03 6月, 2014 2 次提交
  24. 28 5月, 2014 1 次提交
    • Y
      pg, keep `hstore` and `json` attributes as `Hash` in @attributes. · bdbf00dc
      Yves Senn 提交于
      The solution presented in this patch is not efficient. We should replace it
      in the near future. The following needs to be worked out:
        * Is `@attributes` storing the Ruby or SQL representation?
        * `cacheable_column?` is broken but `hstore` and `json` rely on that behavior
      
      Refs #15369.
      
      /cc @sgrif @rafaelfranca
      bdbf00dc
  25. 12 5月, 2014 1 次提交
  26. 28 3月, 2014 2 次提交
  27. 15 3月, 2014 1 次提交
  28. 16 1月, 2014 1 次提交
  29. 24 12月, 2013 2 次提交
  30. 25 10月, 2013 2 次提交
  31. 02 7月, 2013 1 次提交
  32. 14 5月, 2013 1 次提交
  33. 28 2月, 2013 1 次提交