- 08 3月, 2017 1 次提交
-
-
由 Krzysztof Zych 提交于
-
- 24 2月, 2017 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 07 2月, 2017 1 次提交
-
-
由 Stan Lo 提交于
ActionMailer::Base#instrument_name and ActionController::Base#instrument_name will be frequently called once caching is enabled. So it's better to freeze them instead of create new string on every call. Also, the instrument name in #instrument_fragment_cache will usually be "write_fragment.action_controller" or "read_fragment.action_controller". So freezing them might also gain some performance improvement. We have done something like this in other places: https://github.com/rails/rails/blob/master/actionview/lib/action_view/template.rb#L348
-
- 04 2月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 31 1月, 2017 9 次提交
-
-
由 Eugene Kenny 提交于
The raw_source method is documented as returning the exact value that was used to create the body; mutating it breaks that contract. Additionally, if the value used to create the body is blank, raw_source returns a frozen string which causes the interceptor to raise an error.
-
由 yuuji.yaginuma 提交于
-
由 Rafael Mendonça França 提交于
Also change the class_methods to ClassMethods since the former document the method as an instance method of Parameterized not as a class method.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
We own the class so we can override the initialize.
-
由 Rafael Mendonça França 提交于
-
- 30 1月, 2017 1 次提交
-
-
由 David Heinemeier Hansson 提交于
Needed for testing of parameterized mailers
-
- 29 1月, 2017 1 次提交
-
-
由 Kasper Timm Hansen 提交于
-
- 28 1月, 2017 1 次提交
-
-
由 David Heinemeier Hansson 提交于
Offer the option to use parameterization for shared processing of headers and ivars
-
- 15 1月, 2017 2 次提交
-
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
- 12 1月, 2017 1 次提交
-
-
由 Akira Matsuda 提交于
(I personally prefer writing one string in one line no matter how long it is, though)
-
- 06 1月, 2017 1 次提交
-
-
由 MQuy 提交于
-
- 05 1月, 2017 1 次提交
-
-
由 Akira Matsuda 提交于
Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
-
- 04 1月, 2017 1 次提交
-
-
由 Rafael Mendonça França 提交于
This reverts commit 1e969bfb, reversing changes made to a5041f26. Reason: It breaks the public API
-
- 03 1月, 2017 1 次提交
-
-
由 Fumiaki MATSUSHIMA 提交于
If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
-
- 31 12月, 2016 1 次提交
-
-
由 Jon Moss 提交于
Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip]
-
- 24 12月, 2016 2 次提交
-
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
- 06 12月, 2016 1 次提交
-
-
由 MQuy 提交于
-
- 30 11月, 2016 1 次提交
-
-
由 MQuy 提交于
-
- 29 10月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 14 9月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
All indentation was normalized by rubocop auto-correct at 80e66cc4. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency.
-
- 02 9月, 2016 1 次提交
-
-
由 Xavier Noria 提交于
-
- 25 8月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed.
-
- 16 8月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
-
- 09 8月, 2016 1 次提交
-
-
由 Xavier Noria 提交于
-
- 07 8月, 2016 3 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
-
- 06 7月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
Follow up to #24436
-
- 07 6月, 2016 1 次提交
-
-
由 Jonne Haß 提交于
SSL_set_verify(3) explains: SSL_VERIFY_FAIL_IF_NO_PEER_CERT Server mode: if the client did not return a certificate, the TLS/SSL handshake is immediately terminated with a "handshake failure" alert. This flag must be used together with SSL_VERIFY_PEER. Client mode: ignored SSL_VERIFY_CLIENT_ONCE Server mode: only request a client certificate on the initial TLS/SSL handshake. Do not ask for a client certificate again in case of a renegotiation. This flag must be used together with SSL_VERIFY_PEER. Client mode: ignored The SMTP connection here uses a OpenSSL socket in client mode, suggesting invalid/ignored flags is rather misleading.
-
- 31 5月, 2016 1 次提交
-
-
由 Rajat Bansal 提交于
-