1. 05 6月, 2019 9 次提交
  2. 04 6月, 2019 9 次提交
  3. 03 6月, 2019 5 次提交
  4. 02 6月, 2019 6 次提交
  5. 01 6月, 2019 6 次提交
    • R
      Avoid making extra 5 arrays in each `save` · 613060d1
      Ryuta Kamizono 提交于
      Each `save` calls `all_timestamp_attributes_in_model` to fill timestamp
      columns. Allthough the `all_timestamp_attributes_in_model` returns the
      same value every time, the `all_timestamp_attributes_in_model` makes
      extra 5 arrays every time.
      
      This avoids the making extra 5 arrays by memoizing the result, it makes
      `save` economical and a bit faster.
      
      https://gist.github.com/kamipo/1ddad2235073f508637bf9a72d64bb83
      
      Before (2a015f6c):
      
      ```
      {["~/rails/activerecord/lib/active_record/timestamp.rb",
        76,
        :T_ARRAY]=>[1000, 0, 341, 0, 1, 13640],
       ["~/rails/activerecord/lib/active_record/timestamp.rb",
        64,
        :T_ARRAY]=>[1000, 0, 341, 0, 1, 13640],
       ["~/rails/activerecord/lib/active_record/timestamp.rb",
        80,
        :T_ARRAY]=>[1000, 0, 341, 0, 1, 13640],
       ["~/rails/activerecord/lib/active_record/timestamp.rb",
        68,
        :T_ARRAY]=>[1000, 0, 341, 0, 1, 13640],
       ["~/rails/activerecord/lib/active_record/timestamp.rb",
        73,
        :T_ARRAY]=>[1000, 0, 341, 0, 1, 13640]}
      Warming up --------------------------------------
          User.create * 10    36.000  i/100ms
      Calculating -------------------------------------
          User.create * 10    353.644  (± 7.4%) i/s -      1.764k in   5.021876s
      ```
      
      After (this change):
      
      ```
      {["~/rails/activerecord/lib/active_record/timestamp.rb",
        83,
        :T_ARRAY]=>[1, 0, 1, 1, 1, 40],
       ["~/rails/activerecord/lib/active_record/timestamp.rb",
        87,
        :T_ARRAY]=>[1, 0, 1, 1, 1, 40],
       ["~/rails/activerecord/lib/active_record/timestamp.rb",
        64,
        :T_ARRAY]=>[1, 1, 1, 1, 1, 0],
       ["~/rails/activerecord/lib/active_record/timestamp.rb",
        69,
        :T_ARRAY]=>[1, 1, 1, 1, 1, 0],
       ["~/rails/activerecord/lib/active_record/timestamp.rb",
        74,
        :T_ARRAY]=>[1, 1, 1, 1, 1, 0]}
      Warming up --------------------------------------
          User.create * 10    37.000  i/100ms
      Calculating -------------------------------------
          User.create * 10    380.063  (± 7.1%) i/s -      1.924k in   5.097917s
      ```
      613060d1
    • Y
      Merge pull request #36034 from y-yagi/fixes_35709 · 2a015f6c
      Yuji Yaginuma 提交于
      Change `ActionDispatch::Response#content_type` returning Content-Type header as it is
      2a015f6c
    • Y
      Change `ActionDispatch::Response#content_type` returning Content-Type header as it is · ea5f5096
      yuuji.yaginuma 提交于
      Since #35709, `Response#conten_type` returns only MIME type correctly.
      It is a documented behavior that this method only returns MIME type, so
      this change seems appropriate.
      https://github.com/rails/rails/blob/39de7fac0507070e3c5f8b33fbad6fced84d97ed/actionpack/lib/action_dispatch/http/response.rb#L245-L249
      
      But unfortunately, some users expect this method to return all
      Content-Type that does not contain charset. This seems to be breaking
      changes.
      
      We can change this behavior with the deprecate cycle.
      But, in that case, a method needs that include Content-Type with
      additional parameters. And that method name is probably the
      `content_type` seems to properly.
      
      So I changed the new behavior to more appropriate `media_type` method.
      And `Response#content_type` changed (as the method name) to return Content-Type
      header as it is.
      
      Fixes #35709.
      
      [Rafael Mendonça França & Yuuji Yaginuma ]
      ea5f5096
    • R
      Merge pull request #36373 from guigs/fix-table-comment-also-being-applied-to-the-primary-key-column · d3e87efe
      Ryuta Kamizono 提交于
      Fix table comment also being applied to the primary key column
      d3e87efe
    • G
    • J
      Merge pull request #36369 from jhawthorn/parallel_worker_crash · 06ae49d9
      John Hawthorn 提交于
      Fail parallel tests if workers exit early
      06ae49d9
  6. 31 5月, 2019 3 次提交
    • J
      Fail parallel tests if workers exit early · 9fd02d18
      John Hawthorn 提交于
      Previously, if a test worker exited early, the in-flight test it was
      supposed to run wasn't reported as a failure.
      
      If all workers exited immediately, this would be reported as ex.
      
          Finished in 1.708349s, 39.2192 runs/s, 79.0237 assertions/s.
          67 runs, 135 assertions, 0 failures, 0 errors, 2 skips
      
      This commit validates that all workers finish running tests by ensuring
      that the queue is empty after they exit. This works because we signal
      the workers to exit by pushing nil onto the queue, so that there should
      be a number of items left in the queue matching potentially missed
      tests.
      9fd02d18
    • G
      Add a changelog entry for 165785e8 · 5ce1f66d
      George Claghorn 提交于
      5ce1f66d
    • G
      Skip image analysis on ImageMagick error · 165785e8
      George Claghorn 提交于
      165785e8
  7. 29 5月, 2019 2 次提交