- 09 3月, 2014 8 次提交
-
-
由 Andrew White 提交于
If a developer has specified either :path or :as in the options hash then these should be used as the defaults for :shallow_path and :shallow_prefix. Fixes #14241.
-
由 Andrew White 提交于
By tracking the depth of resource nesting we can push the need for nested shallow scoping to only those routes that are nested more than one deep. This allows us to keep the fix for #12498 and fix the regression in #14224. Fixes #14224.
-
由 Andrew White 提交于
Originally with_scope_level was exclusively for managing scope levels with resources, however it is now used for other things so it makes more sense to move the responsibility for setting the :scope_level_resource to the resource_scope method. This eliminates repeatedly setting it to the same resource as each resource method scope is evaluated.
-
由 Yves Senn 提交于
Fix errors for four of the code samples [ci skip]
-
由 Peter Markou 提交于
The four code samples that fail to run are: - Add attribute magic to objects. Fixed by introducing a Person instance variable. - Tracking value changes. Fixed by replacing `attr_accessor` with `define_attribute_methods`, providing getter and setter methods for `name` and providing the missing `Person#save` method. A call to `Person#save` has to precede the `person.name = 'robert'` assignment, if we want `previous_changes` to include 'bob'. - Adding `errors` interface to objects. Fixed by introducing a Person instance variable, assigning `nil` to its name and calling `Person#validate!`. - Custom validators. Fixed by defining `HasNameValidator` before it is used by `ValidatorPerson`. All the code samples can now be run smoothly. Call Dirty#changes_applied in Person#save, instead of modifying instance vars.
-
由 Santiago Pastorino 提交于
Make the rails:template rake task load initializers
-
由 Santiago Pastorino 提交于
Fix OrderedHash.select to return self instance.
-
由 Santiago Pastorino 提交于
Make CSRF failure logging optional/configurable.
-
- 08 3月, 2014 9 次提交
-
-
由 Robin Dupret 提交于
Templates could rely on irregular inflections or external libraries for instance so we should load the application's initializers when running the rails:template task. The introducing commit of this feature is f7f11361 ; the initializers have never been loaded invoking this task. Fixes #12133.
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-
由 Pavel Penkov 提交于
-
由 Andrew White 提交于
Make sure we clean preview_interceptors
-
由 Arthur Neves 提交于
We should make sure we clean preview_interceptors after each test so they dont leaky to the next test
-
由 Arthur Nogueira Neves 提交于
Add preventDefault() on click event
-
由 Patrick Perey 提交于
-
由 Arthur Neves 提交于
On ruby 2.1.1 the behavior of .select and .reject has changed. They will return a Hash new instance, so we need to override them to keep the instance object class.
-
- 07 3月, 2014 5 次提交
-
-
由 Vijay Dev 提交于
Conflicts: guides/source/4_1_release_notes.md
-
由 dmathieu 提交于
Thank you @bquorning
-
由 dmathieu 提交于
[ci-skip] Closes rails/rails#14294
-
由 Vijay Dev 提交于
Add "Low-Level Caching" part to "Caching With Rails" guide
-
由 Aaron Patterson 提交于
Do note remove `Content-Type` when `render :body`
-
- 06 3月, 2014 6 次提交
-
-
由 Yves Senn 提交于
Fix guide about `config.active_record.default_timezone` [ci skip]
-
由 joker1007 提交于
Now the initial value of ActiveRecord.default_timezone is always :utc
-
由 Nikolay Shebanov 提交于
-
由 Hendy Tanata 提交于
-
由 Jeremy Kemper 提交于
Introduce `Rails.gem_version`
-
由 Prem Sichanugrist 提交于
This method return `Gem::Version.new(Rails.version)`, suggesting a more reliable way to perform version comparison. Example: Rails.version #=> "4.1.2" Rails.gem_version #=> #<Gem::Version "4.1.2"> Rails.version > "4.1.10" #=> false Rails.gem_version > Gem::Version.new("4.1.10") #=> true Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true This was originally introduced as `.version` by @charliesome in #8501 but got reverted in #10002 since it was not backward compatible. Also, updating template for `rake update_versions`.
-
- 05 3月, 2014 12 次提交
-
-
由 Prem Sichanugrist 提交于
`render :body` should just not set the `Content-Type` header. By removing the header, it breaks the compatibility with other parts. After this commit, `render :body` will returns `text/html` content type, sets by default from `ActionDispatch::Response`, and it will preserve the overridden content type if you override it. Fixes #14197, #14238 This partially reverts commit 30473768.
-
由 Robin Dupret 提交于
This actually not an issue fixing ; the changelog is referring to the introducing pull request itself.
-
由 Yves Senn 提交于
This is a result of the discussion at https://github.com/rails/rails/pull/14263/files#r10291489
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Follow up of #10732 - Allow string hash values on AR order method
-
由 Aaron Patterson 提交于
Make exists? use bound values.
-
由 Godfrey Chan 提交于
This reverts commit 475c9658, reversing changes made to 705915ab. We decided that this is not worth busting everyone's cache as this seems like a very unlikely problem. The problem only occurs when the user is 1) not using a namespace, or 2) using the same namesapce for different *kinds* of cache items. The recommended "fix" is to put those cache items into their own namspace: id = 1 Rails.cache.fetch(id, namespace: "user"){ User.find(id) } ids = [1] Rails.cache.fetch(ids, namespace: "users"){ User.find(ids) } See the discussion on #14269 for details.
-
由 John Barton (joho) 提交于
Added the log_warning_on_csrf_failure option to ActionController::RequestForgeryProtection which is on by default.
-
由 Guillermo Iguaran 提交于
Cache key should be different when is Array.
-
由 Marcelo Casiraghi 提交于
This behavior has almost no performance impact: String not allowed 66.910000 0.030000 66.940000 ( 67.024976) String allowed 69.360000 0.030000 69.390000 ( 69.503096) Benchmarked with http://git.io/Y0YuRw.
-