1. 16 10月, 2015 11 次提交
    • M
      fixes #21815 · 86d2924a
      Maarten Jacobs 提交于
      The default timestamp used for AR is `updated_at` in nanoseconds! (:nsec) This causes issues on any machine that runs an OS that supports nanoseconds timestamps, i.e. not-OS X, where the cache_key of the record persisted in the database (milliseconds precision) is out-of-sync with the cache_key in the ruby VM.
      
      This commit adds:
      
      A test that shows the issue, it can be found in the separate file `cache_key_test.rb`, because
      - model couldn't be defined inline
      - transactional testing needed to be turned off to get it to pass the MySQL tests
      This seemed cleaner than putting it in an existing testcase file.
      
      It adds :usec as a dateformat that calculates datetime in microseconds
      
      It sets precision of cache_key to :usec instead of :nsec, as no db supports nsec precision on timestamps
      86d2924a
    • Y
      Merge pull request #21969 from ignatiusreza/remove_readonly_option_doc · b3656076
      Yves Senn 提交于
      Remove mentioned of 'readonly' options in doc for HABTM [ci skip]
      b3656076
    • I
      [ci skip] readonly options has been removed · 15f75193
      Ignatius Reza 提交于
      15f75193
    • A
      drop array allocations when iterating over the hash · 960de47f
      Aaron Patterson 提交于
      `each_with_object` allocates an array for each kv pair.  Switching to
      the slightly more verbose but less allocatey `each_pair` eliminates
      array allocations.  Eliminating this allocation returns AR objects to
      have constant array allocations regardless of the number of columns the
      object has.
      
      Here is test code:
      
      ```ruby
      require 'active_record'
      
      class Topic < ActiveRecord::Base
      end
      
      20.times do |i|
        Process.waitpid fork {
          ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'
      
          ActiveRecord::Base.connection.instance_eval do
            create_table(:topics) do |t|
              t.string   :title, limit: 250
              t.string   :author_name
              t.string   :author_email_address
              t.string   :parent_title
              t.string   :type
              t.string   :group
              i.times do |j|
                t.string :"aaa#{j}"
              end
              t.timestamps null: true
            end
          end
      
          ObjectSpace::AllocationTracer.setup(%i{type})
      
          Topic.create title: "aaron" # heat cache
      
          result = ObjectSpace::AllocationTracer.trace do
            10.times do |i|
              Topic.create title: "aaron #{i}"
            end
          end
      
          puts "#{Topic.columns.length},#{(result.find { |k,v| k.first == :T_ARRAY }.last.first / 10)}"
        }
      end
      ```
      
      Before this commit:
      
      ```
      9,166
      10,167
      11,168
      12,169
      13,170
      14,171
      15,172
      16,173
      17,174
      18,175
      19,176
      20,177
      21,178
      22,179
      23,180
      24,181
      25,182
      26,183
      27,184
      28,185
      ```
      
      After:
      
      ```
      9,157
      10,157
      11,157
      12,157
      13,157
      14,157
      15,157
      16,157
      17,157
      18,157
      19,157
      20,157
      21,157
      22,157
      23,157
      24,157
      25,157
      26,157
      27,157
      28,157
      ```
      
      Left side is the number of columns, right is the number of allocations
      960de47f
    • R
      Merge pull request #21966 from AnnaErshova/dbreset-edit · 3b610270
      Rafael Mendonça França 提交于
      Clarifies db can be set up from structure.sql as well as from schema.rb
      3b610270
    • A
      Update active_record_migrations.md · 5cde56e1
      Anna Ershova 提交于
      Add 'db/'; corrects structure.rb to structure.sql
      5cde56e1
    • A
      make string allocation constant regardless of column count · 3253185b
      Aaron Patterson 提交于
      deep_dup'ing a hash will dup the keys as well as the values.  Since
      string keys from the source hash will be frozen, and the dup'd objects
      are immediately dup'd and frozen on insert in to the hash, the end user
      will only ever see two frozen strings.  Since the strings are immutable,
      this commit just cheats a little and reuses the immutable strings.
      
      Just to reiterate, before this commit, deep duping a hash that looks
      like this: `{ "foo" => "bar" }` will generate two new instances of
      "foo". One is created when `deep_dup` is called on "foo", and the other
      is created when the newly allocated "foo" string is inserted in to the
      hash.  The user never sees the intermediate "foo", and both copies of
      "foo" that the user *can* access will be frozen, so in this case we just
      reuse the existing frozen key.
      
      The upshot is that after this change, string allocations on AR
      allocations become constant regardless of the number of columns the
      model has.
      
      ```ruby
      require 'active_record'
      
      class Topic < ActiveRecord::Base
      end
      
      20.times do |i|
        Process.waitpid fork {
          ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'
      
          ActiveRecord::Base.connection.instance_eval do
            create_table(:topics) do |t|
              t.string   :title, limit: 250
              t.string   :author_name
              t.string   :author_email_address
              t.string   :parent_title
              t.string   :type
              t.string   :group
              i.times do |j|
                t.integer :"aaa#{j}"
              end
              t.timestamps null: true
            end
          end
      
          ObjectSpace::AllocationTracer.setup(%i{type})
      
          Topic.create title: "aaron" # heat cache
      
          result = ObjectSpace::AllocationTracer.trace do
            10.times do |i|
              Topic.create title: "aaron #{i}"
            end
          end
      
          puts "#{Topic.columns.length},#{(result.find { |k,v| k.first == :T_STRING }.last.first / 10)}"
        }
      end
      ```
      
      If you run the above script before this commit, the output looks like
      this:
      
      ```
      [aaron@TC rails (master)]$ be ruby -rallocation_tracer test.rb
      9,105
      10,107
      11,109
      12,111
      13,113
      14,115
      15,117
      16,119
      17,121
      18,123
      19,125
      20,127
      21,129
      22,131
      23,133
      24,135
      25,137
      26,139
      27,141
      28,143
      ```
      
      The left column is the number of methods, the right column is the number
      of string allocations.
      
      Running against this commit, the output is:
      
      ```
      [aaron@TC rails (master)]$ be ruby -rallocation_tracer test.rb
      9,87
      10,87
      11,87
      12,87
      13,87
      14,87
      15,87
      16,87
      17,87
      18,87
      19,87
      20,87
      21,87
      22,87
      23,87
      24,87
      25,87
      26,87
      27,87
      28,87
      ```
      
      As you can see, there is now only a constant number of strings
      allocated, regardless of the number of columns the model has.
      3253185b
    • A
      Merge pull request #21946 from davidcelis/fix-time-zone-utc-predicate · 3acc590d
      Andrew White 提交于
      Expand support for ActiveSupport::TimeWithZone#utc?
      3acc590d
    • S
      All strings returned by `ImmutableString` should be frozen · d6919c52
      Sean Griffin 提交于
      I seriously don't even know why we handle booleans, but those strings
      should technically be frozen. Additionally, we don't need to actually
      check the class in the mutable string type, since the `cast_value`
      function will always return a string.
      d6919c52
    • S
      Add an immutable string type to opt out of string duping · 34321e4a
      Sean Griffin 提交于
      This type adds an escape hatch to apps for which string duping causes
      unacceptable memory growth. The reason we are duping them is in order to
      detect mutation, which was a feature added to 4.2 in #15674. The string
      type was modified to support this behavior in #15788.
      
      Memory growth is really only a concern for string types, as it's the
      only mutable type where the act of coersion does not create a new object
      regardless (as we're usually returning an object of a different class).
      
      I do feel strongly that if we are going to support detecting mutation,
      we should do it universally for any type which is mutable. While it is
      less common and ideomatic to mutate strings than arrays or hashes, there
      shouldn't be rules or gotchas to understanding our behavior.
      
      However, I also appreciate that for apps which are using a lot of string
      columns, this would increase the number of allocations by a large
      factor. To ensure that we keep our contract, if you'd like to opt out of
      mutation detection on strings, you'll also be option out of mutation of
      those strings.
      
      I'm not completely married to the thought that strings coming out of
      this actually need to be frozen -- and I think the name is correct
      either way, as the purpose of this is to provide a string type which
      does not detect mutation.
      
      In the new implementation, I'm only overriding `cast_value`. I did not
      port over the duping in `serialize`. I cannot think of a reason we'd
      need to dup the string there, and the tests pass without it.
      Unfortunately that line was introduced at a time where I was not nearly
      as good about writing my commit messages, so I have no context as to
      why I added it. Thanks past Sean. You are a jerk.
      34321e4a
    • D
      Expand support for ActiveSupport::TimeWithZone#utc? · 8e847dcd
      David Celis 提交于
      Currently, ActiveSupport::TimeWithZone#utc? simply runs a check to see
      if the linked ActiveSupport::TimeZone's name is "UTC". This will only
      return true for ActiveSupport::TimeZone["UTC"], but not for time zones
      such as "Etc/UTC", "Etc/Universal", or other time zones that are aliases
      for UTC. Interestingly enough, ActiveSupport::TimeWithZone#utc? is also
      aliased as #gmt? but will return false for the "GMT" timezone (along
      with other TZInfo aliases for GMT).
      
      Instead of running a simple check on the TimeZone name, we can rely on
      the underlying TZInfo::TimezonePeriod and TZInfo::TimezoneOffset which
      keep a record of of the offset's abbreviated name. The possibilities
      here for UTC time zones are `:UTC`, `:UCT`, and `:GMT`.
      Signed-off-by: NDavid <me@davidcel.is>
      8e847dcd
  2. 15 10月, 2015 6 次提交
  3. 14 10月, 2015 14 次提交
  4. 13 10月, 2015 9 次提交