1. 21 3月, 2018 1 次提交
  2. 20 3月, 2018 1 次提交
    • D
      Expose foreign key name ignore pattern in configuration · d3fd4e4e
      David Stosik 提交于
      When dumping the database schema, Rails will dump foreign key names only
      if those names were not generate by Rails. Currently this is determined
      by checking if the foreign key name is `fk_rails_` followed by
      a 10-character hash.
      
      At [Cookpad](https://github.com/cookpad), we use
      [Departure](https://github.com/departurerb/departure) (Percona's
      pt-online-schema-change runner for ActiveRecord migrations) to run migrations.
      Often, `pt-osc` will make a copy of a table in order to run a long migration
      without blocking it. In this copy process, foreign keys are copied too,
      but [their name is prefixed with an underscore to prevent name collision
      ](https://www.percona.com/doc/percona-toolkit/LATEST/pt-online-schema-change.html#cmdoption-pt-online-schema-change-alter-foreign-keys-method).
      
      In the process described above, we often end up with a development
      database that contains foreign keys which name starts with `_fk_rails_`.
      That name does not match the ignore pattern, so next time Rails dumps
      the database schema (eg. when running `rake db:migrate`), our
      `db/schema.rb` file ends up containing those unwanted foreign key names.
      This also produces an unwanted git diff that we'd prefer not to commit.
      
      In this PR, I'd like to suggest a way to expose the foreign key name
      ignore pattern to the Rails configuration, so that individual projects
      can decide on a different pattern of foreign keys that will not get
      their names dumped in `schema.rb`.
      d3fd4e4e
  3. 18 3月, 2018 1 次提交
  4. 17 3月, 2018 1 次提交
    • E
      Fix connection handling with three-tier config · 03929463
      eileencodes 提交于
      If you had a three-tier config, the `establish_connection` that's called
      in the Railtie on load can't figure out how to access the default
      configuration.
      
      This is because Rails assumes that the config is the first value in the
      hash and always associated with the key from the environment. With a
      three tier config however we need to go one level deeper.
      
      This commit includes 2 changes. 1) removes a line from `resolve_all`
      which was parsing out the the environment from the config so instead of
      getting
      
      ```
      {
        :development => {
          :primary => {
            :database => "whatever"
          }
        },
          :animals => {
            :database => "whatever-animals"
          }
        },
        etc with test / prod
      }
      ```
      
      We'd instead end up with a config that had no attachment to it's
      envioronment.
      
      ```
      {
        :primary => {
          :database => "whatever"
        }
        :animals => {
          :database => "whatever-animals"
        }
        etc - without test and prod
      }
      ```
      
      Not only did this mean that Active Record didn't know how to establish a
      connection, it didn't have the other necessary configs along with it in
      the configs list.
      
      So fix this I removed the line that deletes these configs.
      
      The second thing this commit changes is adding this line to
      `establish_connection`
      
      ```
      spec = spec[spec_name.to_sym] if spec[spec_name.to_sym]
      ```
      
      When you have a three-tier config and don't pass any hash/symbol/env etc
      to `establish_connection` the resolver will automatically return both
      the primary and secondary (in this case animals db) configurations.
      We'll get an `database configuration does not specify adapter` error
      because AR will try to establish a connection on the `primary` key
      rather than the `primary` key's config. It assumes that the
      `development` or default env automatically will return a config hash,
      but with a three-tier config we actually get a key and config `primary
      => config`.
      
      This fix is a bit of a bandaid because it's not the "correct" way to
      handle this situation, but it does solve our immediate problem. The new
      code here is saying "if the config returned from the resolver (I know
      it's called spec in here but we interchange our meanings a LOT and what
      is returned is a three-tier config) has a key matching the "primary"
      spec name, grab the config from the spec and pass that to the
      estalbish_connection method".
      
      This works because if we pass `:animals` or a hash, or `:primary` we'll
      already have the correct configuration to connect with.
      
      This fixes the case where we want Rail to connect with the default
      connection.
      
      Coming soon is a refactoring that should eliminate the need to do this
      but I need this fix in order to write the multi-db rake tasks that I
      promised in my RailsConf submission. `@tenderlove` and I are working on
      the refactoring of the internals for connection management but it won't
      be ready for a few weeks and this issue has been blocking progress.
      03929463
  5. 16 3月, 2018 2 次提交
  6. 12 3月, 2018 2 次提交
    • A
      Ensure that leading date is stripped by quoted_time · 7c479cbf
      Andrew White 提交于
      In #24542, quoted_time was introduced to strip the leading date
      component for time columns because it was having a significant
      effect in mariadb. However, it assumed that the date component
      was always 2000-01-01 which isn't the case, especially if the
      source wasn't another time column.
      7c479cbf
    • A
      Normalize date component when writing to time columns · 3f95054f
      Andrew White 提交于
      For legacy reasons Rails stores time columns on sqlite as full
      timestamp strings. However because the date component wasn't being
      normalized this meant that when they were read back they were being
      prefixed with 2001-01-01 by ActiveModel::Type::Time. This had a
      twofold result - first it meant that the fast code path wasn't being
      used because the string was invalid and second it was corrupting the
      second fractional component being read by the Date._parse code path.
      
      Fix this by a combination of normalizing the timestamps on writing
      and also changing Active Model to be more lenient when detecting
      whether a string starts with a date component before creating the
      dummy time value for parsing.
      3f95054f
  7. 09 3月, 2018 1 次提交
  8. 07 3月, 2018 1 次提交
  9. 06 3月, 2018 5 次提交
  10. 05 3月, 2018 5 次提交
  11. 04 3月, 2018 3 次提交
  12. 03 3月, 2018 1 次提交
  13. 02 3月, 2018 5 次提交
  14. 28 2月, 2018 2 次提交
  15. 27 2月, 2018 4 次提交
    • K
      Fix `#columsn_for_distinct` of MySQL and PostgreSQL · 2d48268d
      kg8m 提交于
      Prevent `ActiveRecord::FinderMethods#limited_ids_for` from using correct primary
      key values even if `ORDER BY` columns include other table's primary key.
      
      Fixes #28364.
      2d48268d
    • R
      Partly revert 91b30a00 · 19672421
      Ryuta Kamizono 提交于
      Actually `reflection.klass` should be valid AR model unless
      `polymorphic?`. Previously it worked limitedly by ignoring `NameError`
      even if `reflection.klass` is invalid, and our isolated testing depends
      on the limited working.
      Probably we should also check the klass validity in `check_validity!`
      properly. Until that time, I restored the error suppression for now.
      
      Closes #32113.
      19672421
    • S
      Ensure we don't write virtual attributes on update, too · c2a2b84d
      Sean Griffin 提交于
      See 948b9319 for context
      c2a2b84d
    • S
      Never attempt to write virtual attributes to the database · 948b9319
      Sean Griffin 提交于
      Currently the place where we limit what gets sent to the database is in
      the implementation for `partial_writes`. We should also be restricting
      it to column names when partial writes are turned off.
      
      Note that we're using `&` instead of just defaulting to
      `self.class.column_names`, as the instance version of `attribute_names`
      does not include attributes which are uninitialized (were not included
      in the select clause)
      948b9319
  16. 26 2月, 2018 2 次提交
  17. 23 2月, 2018 3 次提交