1. 09 11月, 2017 2 次提交
  2. 08 11月, 2017 2 次提交
  3. 07 11月, 2017 3 次提交
    • R
      Remove useless `associated_records_by_owner` · 3f1695bb
      Ryuta Kamizono 提交于
      `associated_records_by_owner` had returned customizing result before
      calling `associate_records_to_owner` for through association subclasses.
      Since #22115, `associate_records_to_owner` is called in the method and
      not returned owner and result pairs. Removing the method will reduce
      method call and block call nesting.
      3f1695bb
    • B
      Fix `bin/rails db:migrate` with specified `VERSION` · 90fe2a42
      bogdanvlviv 提交于
      Ensure that `bin/rails db:migrate` with specified `VERSION` reverts
      all migrations only if `VERSION` is `0`.
      Raise error if target migration doesn't exist.
      90fe2a42
    • K
      Properly check transaction in persistence · 01c70324
      Keenan Brock 提交于
      ```
      [NoMethodError]: undefined method `state' for nil:NilClass  Method:[rescue in block in refresh]
      ```
      
      In `within_new_transaction`, there is the possibility that
      `begin_transaction` returns a `nil`. (i.e.: so `transaction = nil`)
      So this method is checking `transaction` for nil in 2 spots.
      
      Unfortunately, there is one line that is not checking `transaction` for `nil`
      That line, `commit_transaction`, throws an exception for us in AR 5.0.0.1
      
      The problem with the method is finally realized in the error checking itself.
      it calls `transaction.state` (i.e.: nil.state) and that is the final exception
      raised.
      
      The actual underlying (user) issue is hidden by this line.
      
      Solution is test transaction for nil.
      01c70324
  4. 06 11月, 2017 6 次提交
  5. 03 11月, 2017 1 次提交
    • Y
      Remove unused classes · 0d7ab973
      yuuji.yaginuma 提交于
      * `HasManyThroughCantDissociateNewRecords` and `HasManyThroughCantAssociateNewRecords`
      are no longer used since f6b12c11.
      * `ReadOnlyAssociation` is no longer used since 0da426be.
      0d7ab973
  6. 30 10月, 2017 2 次提交
  7. 28 10月, 2017 2 次提交
  8. 27 10月, 2017 2 次提交
  9. 26 10月, 2017 1 次提交
  10. 25 10月, 2017 4 次提交
  11. 24 10月, 2017 15 次提交