Signed-off-by: NJoshua Peek <josh@joshpeek.com>

Signed-off-by: NJoshua Peek <josh@joshpeek.com>

Signed-off-by: Nrick <technoweenie@gmail.com>
[#1055 state:resolved]

* Rails::GemDependency was missing definitions for hash and eql?, causing Array#uniq to not work.

* If several versions of a gem are unpacked in vendor, now chooses the highest if no version is specified.

* streamlined add_load_path. Now sets up Rubygems correctly to allow 'gem' to find frozen gems, with
  gems frozen to vendor/gems and specifications in vendor/gems/<gem-name>/.specification

* Rails::GemDependency#specification would return a spec for the highest installed version, even for
  frozen gems and/or previously loaded lower versions. See in part ticket #1123.

* removed vendor from default_load_paths - it was causing autoloading to append Gems::Gems::<gem-dir> to
  constant names

* added additional tests for loading frozen gems.

* incorporates the fix from #1107 for vendor rails

* defers to freeze:gems for handling the Rails framework. gems:unpack WILL NOT place a copy of Rails
  in vendor/gems. Should close #1123 completely.

* incorporates, via using the gem loader for frozen gems, fixes corresponding to #227, #324, #362, #527, and #742.

* gem plugins now work the same whether frozen or not. Correctness of the behavior is a matter for another ticket...
Signed-off-by: Nrick <technoweenie@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string.
Model.avg always returns big decimal.

1.9 has its own version.

Note : If you're not using rescue_from, you should overrider rescue_action_without_handler() method
and not rescue_action(). Afterwards, you can set request.remote_addr to a non "0.0.0.0" value for testing the
overridden behavior.

Remove HasManyAssociationStrategy and move the logic to ActiveRecord::Reflection::ThroughReflection.

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Return processing lock to dispatcher, the finer grained lock was incompatible with the reloading in development mode.

This commit also adds ActionController::Dispatcher#dispatch_unlocking -- non-locking version of dispatch.
It's named anologously to POSIX {getc,getchar,...}_unlocked functions.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1170 state:committed]

We have hit dramatic increase in tests time after upgrading rails.
Profiling revealed this particular place. After this fix our test times returned
back to norm.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1173 state:committed]

This fixes connection pool exhaustion for web servers which create new thread per connection (e.g. Webrick).

integration.rb changes are required to keep test transaction active for several requests.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1171 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1169 state:committed]

After releasing monitor some connection(s) may appear in pool before monitor is re-aquired.
When this happens we'll wait for connection which is already available.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1168 state:committed]

[#983 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Usage : rails app_name -d ibm_db
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Make sure recreate MySQL test database with the proper encoding and collation [#1165 state:resolved]
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1165 state:committed]

added nicer failure reporting to #assert_difference to tell you the expression that failed rather than just the expected and actual values
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1161 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1144 state:committed]

Dynamic finders should use the ActiveRecord::Base::find method instead of ::find_initial, :find_last, and ::find_all.

This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders.
Associations for instance do go through ::find, so this makes it more consistent.
Also removed the unnecessary deprecation silence blocks.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1162 state:committed]

Signed-off-by: NJoshua Peek <josh@joshpeek.com>

Add tests too.

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

wrote a test showing eager loading's misbehavior (sanitizing against the wrong table) when the association has a :conditions hash
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1116 state:committed]

Ignore all exceptions for validates_acceptance_of columns fetch so it can run even without a database connection
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1084 state:committed]

We shouldn't quote the unpack command's requirement as it's passed through GemRunner which takes care of it for us.