merge_with_conditions is not necessary because the conditions will already be in the scope_for_create hash in the scope

Construct an actual ActiveRecord::Relation object for the association scope, rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

* rsim/require_deprecation:
  require ActiveSupport deprecatation file before using deprecate method in database_statements

* rsim/habtm_select_fix:
  Explicitly select * from has_and_belongs_to_many association tables, simplify exists? query