- 04 3月, 2017 29 次提交
-
-
由 Robin Dupret 提交于
-
由 Andrew White 提交于
Fix `rake db:migrate:status` with subdirectories.
-
由 Ryuta Kamizono 提交于
`db:migrate` supports subdirectories and have a test. https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/test/cases/migrator_test.rb#L78-L85 But `db:migrate:status` doesn't work with subdirectories. It is due to `Dir.foreach(path)` is not the same with `Dir["#{path}/**/[0-9]*_*.rb"]`. I extracted `migration_files` and sharing it in the both to fix the issue. And added tests for `db:migrate:status`.
-
由 Andrew White 提交于
Silence puma startup messages in system test
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Don't share `options` with a reference type column
-
由 Robin Dupret 提交于
Fx system test example [ci skip]
-
由 yuuji.yaginuma 提交于
Since test suffix is automatically granted, it is not necessary to specify it in generator. Also, updated the generated file to contents actually generated.
-
由 yuuji.yaginuma 提交于
Fixes #28109
-
由 Ryuta Kamizono 提交于
Sharing `options` causes some unexpected behavior. If `limit: 2` is specified, this means that 2 bytes integer for a reference id column and 2 chars string for a reference type column. Another example, if `unsigned: true` is specified, this means that unsigned integer for a reference id column, but a invalid option for a reference type column. So `options` should not be shared with a reference type column.
-
由 Vipul A M 提交于
-
由 Akira Matsuda 提交于
So calling `filename_with_extensions` omitting the second argument like this https://github.com/slim-template/slim-rails/blob/8dbc1fbf859ebfa95b0884a0196a6ad9f0ca9cd5/lib/generators/slim/scaffold/scaffold_generator.rb#L10 causes NoMethodError. fixes #28275
-
由 Ryuta Kamizono 提交于
passing unique parameter to belongs_to wrongly
-
由 Aaron Patterson 提交于
Various refactoring to association scopes and joins
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Reflections only use their own information to create a `join_keys` object. This means that we can call `join_keys` on a reflection object and have it be context-free.
-
由 Andrew White 提交于
Add iso8601 and rfc3339 parsing to timezones
-
由 Aaron Patterson 提交于
-
由 Andrew White 提交于
For naming consistency when using the RFC 3339 profile of ISO 8601 in applications.
-
由 Andrew White 提交于
The `Time.xmlschema` and consequently its alias `iso8601` accepts timestamps without a offset in contravention of the RFC 3339 standard. This method enforces that constraint and raises an `ArgumentError` if it doesn't.
-
由 Andrew White 提交于
Previously there was no way to get a RFC 3339 timestamp into a specific timezone without either using `parse` or chaining methods. The new method allows parsing directly into the timezone, e.g: >> Time.zone = "Hawaii" => "Hawaii" >> Time.zone.rfc3339("1999-12-31T14:00:00Z") => Fri, 31 Dec 1999 14:00:00 HST -10:00 This new method has stricter semantics than the current `parse` method and will raise an `ArgumentError` instead of returning nil, e.g: >> Time.zone = "Hawaii" => "Hawaii" >> Time.zone.rfc3339("foobar") ArgumentError: invalid date >> Time.zone.parse("foobar") => nil It will also raise an `ArgumentError` when either the time or offset components are missing, e.g: >> Time.zone = "Hawaii" => "Hawaii" >> Time.zone.rfc3339("1999-12-31") ArgumentError: invalid date >> Time.zone.rfc3339("1999-12-31T14:00:00") ArgumentError: invalid date
-
由 Andrew White 提交于
Previously there was no way to get a ISO 8601 timestamp into a specific timezone without either using `parse` or chaining methods. The new method allows parsing directly into the timezone, e.g: >> Time.zone = "Hawaii" => "Hawaii" >> Time.zone.iso8601("1999-12-31T14:00:00Z") => Fri, 31 Dec 1999 14:00:00 HST -10:00 If the timestamp is a ISO 8601 date (YYYY-MM-DD) then the time is set to midnight, e.g: >> Time.zone = "Hawaii" => "Hawaii" >> Time.zone.iso8601("1999-12-31") => Fri, 31 Dec 1999 00:00:00 HST -10:00 This new method has stricter semantics than the current `parse` method and will raise an `ArgumentError` instead of returning nil, e.g: >> Time.zone = "Hawaii" => "Hawaii" >> Time.zone.iso8601("foobar") ArgumentError: invalid date >> Time.zone.parse("foobar") => nil
-
由 Robin Dupret 提交于
Fix spelling in docs
-
由 Jonathan Chen 提交于
[ci skip]
-
由 eileencodes 提交于
It turns out that we don't need to require system tests in the railties test helper so we can remove it. If you're using system tests they will be loaded by inheriting from ActionDispatch::SystemTestCase and the routes will be loaded by ActionDispatch::IntegrationTest.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Scopes can only ever be *not* reflection objects when they are passed in to the Reflection constructor. Given this fact, we can eliminate is_a checks and an intermediate array object by just asking the reflection object for join scopes.
-
由 Aaron Patterson 提交于
Remove `node` parameter to `join_constraints`
-
由 Aaron Patterson 提交于
I don't think we actually need this parameter anymore. Nobody seems to be using it.
-
- 03 3月, 2017 11 次提交
-
-
由 0oneo 提交于
passing `unique` parameter to belongs_to not right,
-
由 Andrew White 提交于
-
由 Eileen M. Uchitelle 提交于
Fix random failure on system test with ajax
-
由 Andrew White 提交于
Deprecate implicit coercion of `ActiveSupport::Duration`
-
由 Fumiaki MATSUSHIMA 提交于
If application has ajax, browser may begin request after rollback. `teardown_fixtures` will be called after `super` on `after_teardown` so we must call `Capybara.reset_sessions!` before `super` https://github.com/rails/rails/blob/b61a56541aecd7ac685d4f19d943177a3f1b465a/activerecord/lib/active_record/fixtures.rb#L857
-
由 Arun Agrawal 提交于
Fix typo in Upgrading Ruby on Rails Guide
-
由 Erol Fornoles 提交于
-
由 Ryuta Kamizono 提交于
fixed suspected typo in sample sql query
-
由 Kasper Timm Hansen 提交于
Includes a script to ease an app's upgrade.
-
由 Shay 提交于
-
由 Kasper Timm Hansen 提交于
-