- 12 4月, 2018 4 次提交
-
-
由 Godfrey Chan 提交于
On Rails 5.2, when compression is enabled (which it is by default), the actual value being written to the underlying storage is actually _bigger_ than the uncompressed raw value. This is because the `@marshaled_value` instance variable (typically) gets serialized with the entry object, which is then written to the underlying storage, essentially double-storing every value (once uncompressed, once possibly compressed). This regression was introduced in #32254.
-
由 Rafael França 提交于
Merge pull request #32536 from lsylvester/fix-immutable-relation-error-with-http-caching-and-collection-caching Fix ActiveRecord::ImmutableRelation is raised when collection caching and HTTP caching are used together
-
由 Lachlan Sylvester 提交于
don't check for immutability when setting skip_preloading as it doesn't effect the arel and the arel may already be generated by fresh_when
-
由 Rafael França 提交于
Use frozen string literal
-
- 11 4月, 2018 10 次提交
-
-
由 Rafael Mendonça França 提交于
See https://github.com/rails/rails-docs-server/pull/8 for reason. [ci skip]
-
由 Naoki Nishiguchi 提交于
-
由 yuuji.yaginuma 提交于
The issue was fixed with https://github.com/petergoldstein/dalli/pull/679, and a new version containing that fix was released.
-
由 Rafael França 提交于
Fix turbolinks warning in railties test
-
由 Yoshiyuki Hirano 提交于
* Upgrade turbolinks from v5.0.1 to v5.1.0 * Fix warning in railties test lib/turbolinks/assertions.rb:17: warning: assigned but unused variable - visit_action
-
由 Rafael França 提交于
Include default headers by default in API mode
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
We don't want people to jump from the last release in the previous series (4.2) straing to the first release in the current series that is support (5.1), so we should be supporting the entire series for severe security issues. This will not be a problem because usually we only have 3 releases in a series and backporting patches inside the same series is not harder than backporting to a previous series.
-
由 yuuji.yaginuma 提交于
Add explicit global namespace to `Rails::TestUnit::Runner` to resolve a namespace conflict between `minitest-rails` and Rails test runner. Fixes #31324
-
由 eileencodes 提交于
There's no reason to block future versions of Capybara since we don't _know_ they are going to break. How will we know if we have a conservative option set? This change prevents us from blocking users who want to upgrade in the future.
-
- 10 4月, 2018 14 次提交
-
-
由 Javan Makhmali 提交于
Active Storage: Always exclude JSON root from direct_uploads#create response
-
由 Javan Makhmali 提交于
The JavaScript component expects a bare response. Fixes #32365
-
由 Rafael Mendonça França 提交于
It is the last major release series.
-
由 Ryuta Kamizono 提交于
Prevent changes_to_save from mutating attributes
-
由 Ryuta Kamizono 提交于
Add `TestCaseTest#test_request_format_kwarg_doesnt_mutate_params` to master
-
由 Ryuta Kamizono 提交于
Correct Maintenance Policy for Rails 5.2 [ci skip]
-
由 Ryuta Kamizono 提交于
Update bug report templates
-
由 bogdanvlviv 提交于
Initially, the test was added to 5-0-stable in #32492 and a bit modified in #32506. This test ensures that request(in tests) doesn't mutate params. It was fixed since v5.1.0.beta1 by 98b83095 and then on 5-0-stable by #32492. This commit adds this test to master branch in order to prevent any regressions.
-
由 bogdanvlviv 提交于
Set Rails 5.2.0 in templates
-
由 Ryan Bigg 提交于
-
由 Rafael Mendonça França 提交于
Only disable headless chrome gpu on Windows
-
由 eileencodes 提交于
This was causing single db applications to have rake tasks named `db:create:primary`. These tasks are only useful to multiple database applications so they shouldn't be generated.
-
由 eileencodes 提交于
I realized I wasn't really testing some of the new rake tasks added so I built out this new test that uses a multi-db database.yml and allows us to run create/drop/migrate/schema:dump/schema:load and those that are namespaced like create:animals. This will make our testing more robust so we can catch problems quicker and set a good place to add future tests as these features evolve.
-
由 eileencodes 提交于
Pass the spec name to load_schema in order to load from the correct structure file when there are multiple databases
-
- 09 4月, 2018 5 次提交
-
-
由 Eileen M. Uchitelle 提交于
Improve the null origin error message
-
由 Patrik Bóna 提交于
-
由 Ryuta Kamizono 提交于
Avoid generating full changes hash on every save
-
由 Eugene Kenny 提交于
When an array of hashes is added to a `HashWithIndifferentAccess`, the hashes are replaced with HWIAs by mutating the array in place. If an attribute's value is an array of hashes, `changes_to_save` will convert it to an array of HWIAs as a side-effect of adding it to the changes hash. Using `merge!` instead of `[]=` fixes the problem, as `merge!` copies any array values in the provided hash instead of mutating them.
-
由 Eugene Kenny 提交于
`changed_attribute_names_to_save` is called in `keys_for_partial_write`, which is called on every save when partial writes are enabled. We can avoid generating the full changes hash by asking the mutation tracker for just the names of the changed attributes. At minimum this saves one array allocation per attribute, but will also avoid calling `Attribute#original_value` which is expensive for serialized attributes.
-
- 08 4月, 2018 7 次提交
-
-
由 Ryuta Kamizono 提交于
Fix leftover references to VariantsController in AS documentation [ci skip]
-
由 dixpac 提交于
VariantsController has been merged to RepresentationsController, this PR fixes outdated references to VariantsController in ActiveStorage documentation.
-
由 Guillermo Iguaran 提交于
Mocha updates
-
由 yuuji.yaginuma 提交于
Because this class includes not only `assert_difference` but also tests of other assertion methods.
-
由 Ryuta Kamizono 提交于
Enable verbose option in ActiveStorage
-
由 Yoshiyuki Hirano 提交于
-
由 Xavier Noria 提交于
rewords a bit RDOC_MAIN.rdoc [ci skip]
-