- 09 12月, 2019 5 次提交
-
-
由 Edouard CHIN 提交于
- SQlite allow database to be specified as URL (given that URI filename interpretation was turned on on the connection.) This commit is necessary for the read_uncommitted transaction feature because SQLite doesn't allow to enable the shared-cache mode if the database name is `:memory:`. It has to be a URI (`file::memory`) Ref https://www.sqlite.org/sharedcache.html#shared_cache_and_in_memory_databases
-
由 Edouard CHIN 提交于
- ### Use case I'd like to be able to see changes made by a connection writer within a connection reader before the writer transaction commits (aka `read_uncommitted` transaction isolation level). ```ruby conn1.transaction do Dog.create(name: 'Fido') conn2.transaction do Dog.find(name: 'Fido') # -> Can't see the dog untill conn1 commits the transaction end end ``` Other adapters in Rails (mysql, postgres) already supports multiple types of isolated db transaction. SQLite doesn't support the 4 main ones but it supports `read_uncommitted` and `serializable` (the default one when opening a transaction) ### Solution This PR allow developers to open a `read_uncommitted` transaction by setting the PRAGMA `read_uncommitted` to true for the duration of the transaction. That PRAGMA can only be enabled if the SQLite connection was established with the [shared-cache mode](https://www.sqlite.org/sharedcache.html) This feature can also benefit the framework and we could potentially get rid of the `setup_shared_connection_pool` inside tests which was a solution in the context of a multi-db app so that the reader can see stuff from the open transaction writer but has some [caveats](https://github.com/rails/rails/issues/37765#event-2828609021). ### Edge case Shared-cache mode can be enabled for in memory database as well, however for backward compatibility reasons, SQLite only allows to set the shared-cache mode if the database name is a URI. It won't allow it if the database name is `:memory`; it has to be changed to `file::memory` instead.
-
由 Rafael Mendonça França 提交于
This reverts commit 4e105385, reversing changes made to 62b43839. The change in Ruby that made those changes required was reverted in https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/8852fa876039ed177fd5e867f36177d8a9ff411c
-
由 Rafael França 提交于
Rails::Application#config_for merges shared configuration deeply
-
由 kirikiriyamama 提交于
-
- 08 12月, 2019 3 次提交
-
-
由 kirikiriyamama 提交于
-
由 Dalto Curvelano 提交于
[ci skip]
-
由 finn 提交于
Add a yellow "NOTE" block to see if the guide looks better.
-
- 07 12月, 2019 10 次提交
-
-
由 Shu Fujita 提交于
-
由 Peter Zhu 提交于
-
由 Gannon McGibbon 提交于
Remove unused query params in DiskService
-
由 Peter Zhu 提交于
-
由 Gannon McGibbon 提交于
Use DiskController for both public and private files
-
由 Peter Zhu 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
- 06 12月, 2019 14 次提交
-
-
由 Rafael França 提交于
Bring back feature that allows loading external route files:
-
由 Carlos Antonio da Silva 提交于
-
由 Edouard CHIN 提交于
= This feature existed back in 2012 https://github.com/rails/rails/commit/5e7d6bba79393de0279917f93b82f3b7b176f4b5 but got reverted with the incentive that there was a better approach. After discussions, we agreed that it's a useful feature for apps that have a really large set of routes. Co-authored-by: NYehuda Katz <wycats@gmail.com>
-
由 Xavier Noria 提交于
I added myself links to the Ruby on Rails Tutorial years ago, after meeting Michael in a RailsConf. By then, the book was a commercial product, but had a free online version and I thought it could be a good resource complementing the official documentation. Nowadays, only a few sample chapters are available for free, and I don't consider these links to be fair with the rest of commercial books about Rails anymore.
-
由 Ryuta Kamizono 提交于
Revert "Use `app.config.file_watcher` for watcher in `RoutesReloader`"
-
由 Alan Tan 提交于
This reverts commit 28e44f47. A limitation of Listen is that it currently only supports watching directories. Therefore, watching `config/routes.rb` will end up watching the entire `config` directory if we use the evented file watcher. This causes problems especially if symlinks are present in the `config` directory.
-
由 Ryuta Kamizono 提交于
system tests: properly set driver options for non-headless drivers
-
由 Ryuta Kamizono 提交于
Use `app.config.file_watcher` for watcher in `RoutesReloader`
-
由 Ryuta Kamizono 提交于
Upgrade listen to 3.2.1 for darwin fixes
-
由 George Claghorn 提交于
-
由 Alan Tan 提交于
Pulls in a fix where the darwin adapter no longers create a `fsevent_watch` process for each directory that Listen has been asked to watch.
-
由 Kasper Timm Hansen 提交于
Closes #37666
-
由 Santiago Bartesaghi 提交于
-
由 George Claghorn 提交于
-
- 05 12月, 2019 8 次提交
-
-
由 Ryuta Kamizono 提交于
Don't parse DB specific locking docs as code [ci skip]
-
由 Ryuta Kamizono 提交于
Add guide for inline around_action
-
由 George Claghorn 提交于
-
由 Ryo Nakamura 提交于
-
由 yuuji.yaginuma 提交于
This reverts commit 5bbb2a65, reversing changes made to f9e4906c. Reason: Since #36866, we use `azure-storage-blob` gem. So the original description is correct.
-
由 Ryuta Kamizono 提交于
Small doc fixes for ActiveJob::Exceptions::ClassMethods#retry_on [ci skip]
-
由 Ryuta Kamizono 提交于
Should keep the original parts for zero duration
-
由 T.J. Schuck 提交于
Follow up to https://github.com/rails/rails/pull/31872 Particularly, the closing `</tt>` tag of the documented wait algorithm had a misplaced `<`. Threw in a space between `15% (0.15)` for good measure. [ci skip]
-