- 29 8月, 2012 9 次提交
-
-
由 Xavier Noria 提交于
Changes in old branches needed to be manually synched in CHANGELOGs of newer ones. This has proven to be brittle, sometimes one just forgets this manual step. With this commit we switch to CHANGELOGs per branch. When a new major version is cut from master, the CHANGELOGs in master start being blank. A link to the CHANGELOG of the previous branch allows anyone interested to follow the history.
-
由 Xavier Noria 提交于
Nowadays circular autoloads do not work, but the user gets a NameError that says some constant is undefined. That's puzzling, because he is normally trying to autoload a constant he knows can be autoloaded. With this check we can give a better error message.
-
由 Rafael Mendonça França 提交于
Fix method redefined warnings.
-
由 kennyj 提交于
-
由 José Valim 提交于
Fixes warnings when executing rake test in ActionMailer.
-
由 José Valim 提交于
Tiny fixes in railties/test/application.
-
由 kennyj 提交于
-
由 kennyj 提交于
-
- 28 8月, 2012 31 次提交
-
-
由 Xavier Noria 提交于
loaded stores file names without the .rb extension, but search_for_file returns file names with the extension. The solution is hackish, but this file needs a revamp.
-
由 Rafael Mendonça França 提交于
removed : warning: `*' interpreted as argument prefix
-
由 Arun Agrawal 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Memcached to dalli for actionpack test.
-
由 José Valim 提交于
Change generators controller help from singular to plural example.
-
由 Philipp Weissensteiner 提交于
When running `rails generate controller --help` an example with creating a (singular) "CreditCard" controller is shown. The convention is to generate controllers with plural names though.
-
由 Rafael Mendonça França 提交于
fix order dependent test in AR::BasicsTest
-
由 Piotr Sarnacki 提交于
This branch contains set of changes that will allow to extract Action View out of Action Pack in the future. This work will be probably done after Rails 4.0 release, because of a few deprecations that were done to make decoupling possible.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
Methods provided by RecordIdentifier are not widely used in controllers nowadays as they're view specific (this is probably a legacy left after RJS rendering directly in controllers). However if people still need to use it, it's trivial to include ActionView::RecordIdentifier by themselves.
-
由 Piotr Sarnacki 提交于
We extend it with self, but the methods were not working properly were used directly on module.
-
由 Piotr Sarnacki 提交于
When module is extended ActiveSupport::Concern, include calls are lazily loaded, so there is no need to wrap it with included hook.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
AV::Template::Types is a small abstraction to allow to specify template types that can be used in ActionView. When Action Pack is loaded it's replaced with Mime::Type.
-
由 Piotr Sarnacki 提交于
ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This was changed by splitting previous implementation of UrlHelper into 2 modules: ActionView::Helpers::UrlHelper and ActionView::Routing::UrlHelper. The former one keeps only basic implementation of url_for. The latter adds features that allow to use routes and is only required when url_helpers or mounted_helpers are required.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
default_formats array is used by LookupContext in order to allow rendering templates when :formats option is not passed. Previously it was always set to Mime::SET, which created dependency on Action Pack. In order to remove this dependency, Mime::SET is used only if ActionController is loaded.
-
由 Piotr Sarnacki 提交于
Action View should not be responsible for translating mime types. Any translation that's needed should be handled at controller level.
-
由 Piotr Sarnacki 提交于
Automatically handling mime types for things other than :rss and :atom is not functionality that justifies dependency on Mime::Type from actionpack.
-
由 Piotr Sarnacki 提交于
I've talked to José Valim, who added this comment, and there is no need to remove old API. It's good to have a simple way to instantiate ActionView::Base, by just passing view paths as a first argument, instead of constructing LookupContext and then the Renderer. [ci skip]
-
由 Piotr Sarnacki 提交于
We can use another way to instantiate ActionView::Base, by passing renderer as a first option. Thanks to that we can just pass prefixes to LookupContext instead stubbing them on the controller. This is also good, because that kind of API is used in Rails code.
-
由 Piotr Sarnacki 提交于
This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
It's just a duplicate of ActionController::ModelNaming. These are just a simple helpers for decoupling Active Model, so it does not make sense to extract it to Active Support, but the point is to decouple also Action View and Action Pack
-
由 Piotr Sarnacki 提交于
Since it's more about DOM classes and ids it belongs to Action View better. What's more, it's more convenient to make it part of Action View to follow the rule that Action Pack can depend on Action View, but not the other way round.
-
由 Piotr Sarnacki 提交于
Since Action View should not depend on actionpack, it's best to delegate invalid_asset_host! to controller and just rely on such simple contract instead of raising ActionController::RoutingError directly.
-
由 Rafael Mendonça França 提交于
ensures that the test repairs the validation setup
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
This test https://github.com/rails/rails/blob/master/activerecord/test/cases/base_test.rb#L381 is failing because is not setting `CreditCard.pluralize_table_name` to `false`. In this case, i prefer to change to another model that is not in the `GUESSED_CLASSES` array.
-