The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.

The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.

The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.

The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.

`rack/test` is require at the top of file.
https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L3

In addtion, `Rack::Test::Methods` is include in class, extend is unnecessary.
https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L9

This commit suppressed
`warning: instance variable @session_store not initialized`.
e5a6f7ee introduced these
warnings.

I dropped the version constraint in web-console with the idea it will be
easier to upgrade the console between Rails releases. However, issues
like #25899 started popping up.

I'm reintroducing the constraint, but this time, I don't set an upper
limit to the major version. This will keep the web-console in a version
that always works for the current Rails version and can be easily
upgraded to the last one with `bundle update`.

We may need to backport this for Rails 5.0.1.

Fixes #25899.

- By default the session store will be set to cookie store with
  application name as session key.
- Older apps are not affected as they will have the session store
  initializer generated by Rails in older versions, and Rails will not
  overwrite the session store if it is already set or disabled.
- But new apps will not have the initializer, instead the session store
  will be set to cookie store by default.
- Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.

Refactor the existing session_store to use keyword args and raise early when set to activerecord session store

- Use keyword args as it is possible to use them now.
- The error message for activerecord-session_store gem was added in 1807384c.
- But it was added for a code path which gets called when we try to
  **access** the session store, not when we **set** it.
- So the test expecting the exception started failing because now the
  session store is set via railtie again **after** setting it first with
  :active_record_store in the test.
- As the error is not raised while setting the store to
  :active_record_store, the store gets overwritten by railtie and when
  we access it via `session_store` while building the default middleware
  stack, the exception is not raised.
- This commit moves the code for raising the exception to the path where
  we try to set the store.

- We need to ability to check whether the session store it is set or
   not so that we can set it ourselves in an internal initializer.
- We can't rely on return value of `config.session_store` as it can
  return `nil` when set to `disabled` and we will accidentally override it
  and set to default cookie store.
- So introduced new method which just tells us whether it is set or not.

- Also minor weekly CHANGELOG cleanup.

A mailer preview test description misspelled the word configuration.
This commit updates the test description to spell the word correctly.

Only include files that contain changes since the last generation
of the API documentation.

Thus, only modified files are re-generated instead of the whole API.

The `created.rid` file won't contain the whole list of files anymore
if we generate several times the API but we don't really care about it,
only the generation date and time is important.

It is possible to fall back to the previous behavior by defining the ALL
environment variable running the `rake rdoc` task.

`class_variable_get` is public from Ruby 1.9.
Ref: http://ruby-doc.org/core-2.2.0/Module.html#method-i-class_variable_get

- Cleanup Active Record CHANGELOG.
- Add missing CHANGELOG for https://github.com/rails/rails/pull/25688.
- Clarify that assets requests logging is suppressed.

accidently set it to.

Made the change and test still passes.

The options used in this file are *not* directly described in the Rails 5.0
release notes (http://edgeguides.rubyonrails.org/5_0_release_notes.html), but
instead in section 2 of the Guide for Upgrading Ruby on Rails document
(http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html).

Additional directories can be added using
SourceAnnotationExtractor::Annotation.register_directories("spec", "other_dir")

Result: rake notes will now extract notes from these directories.

- The `boot_rails` method from abstract_unit.rb is empty after 2abcdfd9.
- So let's remove it and its usage.

Follow up to #25431

Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.

- Cleaned up backtrace cleaner test code and removed instaces variables

Add handling of cleaning up backtrace from IRB console in case of errors