1. 01 2月, 2017 1 次提交
    • Y
      correctly set test adapter when configure the queue adapter on a per job (#26690) · 80dc3098
      Yuji Yaginuma 提交于
      The `ActiveJob::TestHelper` replace the adapter to test adapter in
      `before_setup`. It gets the target class using the `descendants`, but if
      the test target job class is not loaded, will not be a replacement of
      the adapter.
      Therefore, instead of replacing with `before_setup`, modified to
      replace when setting adapter.
      
      Fixes #26360
      80dc3098
  2. 31 1月, 2017 1 次提交
  3. 28 1月, 2017 1 次提交
  4. 18 1月, 2017 1 次提交
  5. 17 1月, 2017 1 次提交
  6. 15 1月, 2017 1 次提交
  7. 05 1月, 2017 1 次提交
  8. 04 1月, 2017 1 次提交
  9. 03 1月, 2017 1 次提交
    • F
      Fix generator command for nested (namespaced) rails engine · 085546df
      Fumiaki MATSUSHIMA 提交于
      If we create nested (namespaced) rails engine such like bukkits-admin,
      `bin/rails g scaffold User name:string age:integer`
      will create
      `bukkits-admin/app/controllers/bukkits/users_controller.rb`
      but it should create
      `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
      
      In #6643, we changed `namespaced_path` as root path
      because we supposed application_controller is always in root
      but nested rails engine's application_controller will not.
      085546df
  10. 31 12月, 2016 1 次提交
  11. 30 12月, 2016 2 次提交
  12. 25 12月, 2016 1 次提交
  13. 24 12月, 2016 2 次提交
  14. 23 12月, 2016 1 次提交
  15. 22 12月, 2016 1 次提交
    • K
      Remove warning in ActiveJob · 2f421fa2
      Kir Shatrov 提交于
      Currently it causes:
      
      ```
      activejob/Rakefile:5: warning: already initialized constant ACTIVEJOB_ADAPTERS
      ```
      2f421fa2
  16. 13 12月, 2016 1 次提交
  17. 30 11月, 2016 1 次提交
  18. 18 11月, 2016 1 次提交
    • Y
      remove Ruby warning from Active Job test helper methods · 5b825c55
      yuuji.yaginuma 提交于
      This removes the following warnings.
      
      ```
      /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:241: warning: shadowing outer local variable - job
      /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:265: warning: shadowing outer local variable - job
      ```
      5b825c55
  19. 17 11月, 2016 1 次提交
  20. 29 10月, 2016 1 次提交
  21. 27 10月, 2016 1 次提交
  22. 25 10月, 2016 1 次提交
  23. 21 10月, 2016 1 次提交
  24. 14 10月, 2016 1 次提交
  25. 11 10月, 2016 2 次提交
  26. 09 10月, 2016 1 次提交
  27. 08 10月, 2016 1 次提交
  28. 20 9月, 2016 1 次提交
  29. 05 9月, 2016 1 次提交
  30. 02 9月, 2016 1 次提交
  31. 25 8月, 2016 1 次提交
    • R
      Add load hooks to all tests classes · 0510208d
      Rafael Mendonça França 提交于
      Usually users extends tests classes doing something like:
      
          ActionView::TestCase.include MyCustomTestHelpers
      
      This is bad because it will load the ActionView::TestCase right aways
      and this will load ActionController::Base making its on_load hooks to
      execute early than it should.
      
      One way to fix this is using the on_load hooks of the components like:
      
          ActiveSupport.on_load(:action_view) do
            ActionView::TestCase.include MyCustomTestHelpers
          end
      
      The problem with this approach is that the test extension will be only
      load when ActionView::Base is loaded and this may happen too late in the
      test.
      
      To fix this we are adding hooks to people extend the test classes that
      will be loaded exactly when the test classes are needed.
      0510208d
  32. 20 8月, 2016 1 次提交
  33. 19 8月, 2016 1 次提交
  34. 17 8月, 2016 1 次提交
  35. 16 8月, 2016 1 次提交
  36. 10 8月, 2016 1 次提交
  37. 08 8月, 2016 1 次提交
    • X
      code gardening: removes redundant selfs · a9dc4545
      Xavier Noria 提交于
      A few have been left for aesthetic reasons, but have made a pass
      and removed most of them.
      
      Note that if the method `foo` returns an array, `foo << 1`
      is a regular push, nothing to do with assignments, so
      no self required.
      a9dc4545