- 01 2月, 2017 1 次提交
-
-
由 Yuji Yaginuma 提交于
The `ActiveJob::TestHelper` replace the adapter to test adapter in `before_setup`. It gets the target class using the `descendants`, but if the test target job class is not loaded, will not be a replacement of the adapter. Therefore, instead of replacing with `before_setup`, modified to replace when setting adapter. Fixes #26360
-
- 31 1月, 2017 1 次提交
-
-
由 Alexander Pauly 提交于
Refactored ActiveJob TestAdapter Updated ActiveJob changelog Fixed typo in changelog Fixed formatting issue in changelog
-
- 28 1月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Currently, backburner integration test is not running on CI. https://travis-ci.org/rails/rails/jobs/196005322#L610 Using `Backburner::Worker.connection` to check whether beanstalkd is running. But `Backburner::Worker.connection` was removed in backburner 1.2.0. https://github.com/nesquena/backburner/commit/81fde499c2263abe8dedee59a3d0e03e92d72627 Therefore, this check process always becomes false, so the test is no longer done. I fixed it so that check processing is done correctly.
-
- 18 1月, 2017 1 次提交
-
-
由 Michael Elfassy 提交于
-
- 17 1月, 2017 1 次提交
-
-
由 Akira Matsuda 提交于
[ci skip]
-
- 15 1月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
`InlineAdapter` is not used from 1f8558fa.
-
- 05 1月, 2017 1 次提交
-
-
由 Akira Matsuda 提交于
Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
-
- 04 1月, 2017 1 次提交
-
-
由 Rafael Mendonça França 提交于
This reverts commit 1e969bfb, reversing changes made to a5041f26. Reason: It breaks the public API
-
- 03 1月, 2017 1 次提交
-
-
由 Fumiaki MATSUSHIMA 提交于
If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
-
- 31 12月, 2016 1 次提交
-
-
由 Jon Moss 提交于
Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip]
-
- 30 12月, 2016 2 次提交
-
-
-
由 Rafael Mendonça França 提交于
-
- 25 12月, 2016 1 次提交
-
-
由 Akira Matsuda 提交于
-
- 24 12月, 2016 2 次提交
-
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
- 23 12月, 2016 1 次提交
-
-
由 Akira Matsuda 提交于
-
- 22 12月, 2016 1 次提交
-
-
由 Kir Shatrov 提交于
Currently it causes: ``` activejob/Rakefile:5: warning: already initialized constant ACTIVEJOB_ADAPTERS ```
-
- 13 12月, 2016 1 次提交
-
-
由 utilum 提交于
-
- 30 11月, 2016 1 次提交
-
-
由 Matthew Draper 提交于
Make sure the file doesn't exist until we've finished writing it.
-
- 18 11月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
This removes the following warnings. ``` /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:241: warning: shadowing outer local variable - job /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:265: warning: shadowing outer local variable - job ```
-
- 17 11月, 2016 1 次提交
-
-
由 Maxime Boisvert 提交于
-
- 29 10月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 27 10月, 2016 1 次提交
-
-
由 Xavier Noria 提交于
-
- 25 10月, 2016 1 次提交
-
-
由 Gabi Stefanini 提交于
Change ActiveJob::Base.queue_adapter to use queue_adapter method to make test code consistent.
-
- 21 10月, 2016 1 次提交
-
-
由 Gabi Stefanini 提交于
-
- 14 10月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 11 10月, 2016 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
- 09 10月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059
-
- 08 10月, 2016 1 次提交
-
-
- 20 9月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
`1-x-stable` branch does not exist, `master` is 1.x branch. Ref: http://words.steveklabnik.com/rescuing-resque-again
-
- 05 9月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
`subclasses` get only child classes. Therefore, if create a job common parent class as `ApplicationJob`, inherited class does not get properly.
-
- 02 9月, 2016 1 次提交
-
-
由 Xavier Noria 提交于
-
- 25 8月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed.
-
- 20 8月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059
-
- 19 8月, 2016 1 次提交
-
-
由 InJung Chung 提交于
This will fix issues in [resque-scheduler](https://github.com/resque/resque-scheduler) `#job_to_hash` method, so we can use `#enqueue_delayed_selection`, `#remove_delayed` method in resque-scheduler smoothly.
-
- 17 8月, 2016 1 次提交
-
-
由 David Heinemeier Hansson 提交于
Yield the job instance so you have access to things like `job.arguments` on the custom logic after retries fail
-
- 16 8月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
-
- 10 8月, 2016 1 次提交
-
-
由 Vipul A M 提交于
-
- 08 8月, 2016 1 次提交
-
-
由 Xavier Noria 提交于
A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
-