- 24 4月, 2018 2 次提交
-
-
由 Rafael Barbolo 提交于
* Remove key from session by using session.delete You are not deleting a key from session when you assign nil to that key. * Update guides on how to destroy a user session In this commit, the user id is removed from session and controller's variables related to the user are nullified. [Rafael Mendonça França + Rafael Barbolo]
-
由 Rafael França 提交于
Update rails-ujs readme
-
- 23 4月, 2018 6 次提交
-
-
由 yuuji.yaginuma 提交于
Since other views use the `h2` tag, should also use `h2` on `missing_exact_template.html.erb`. https://github.com/rails/rails/blob/76acaf6eb9ef3635e4c6f2ca9dba34edb50f541d/actionpack/lib/action_dispatch/middleware/templates/rescues/routing_error.html.erb#L5 https://github.com/rails/rails/blob/76acaf6eb9ef3635e4c6f2ca9dba34edb50f541d/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb#L11 https://github.com/rails/rails/blob/76acaf6eb9ef3635e4c6f2ca9dba34edb50f541d/actionpack/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb#L5
-
由 Guillermo Iguaran 提交于
Update results of command in Testing guides [ci skip]
-
由 Guillermo Iguaran 提交于
Refactor guides javascripts
-
由 Yoshiyuki Hirano 提交于
* Remove `$` prefix from all variables (`$` prefix means jQuery object) * Old browsers doesn't support forEach. So use for instead of forEach.
-
由 Yoshiyuki Hirano 提交于
* Results of command in testing guides are different from actual ones. * Updated them.
-
由 Guillermo Iguaran 提交于
✂ jQuery for Rails Guides
-
- 22 4月, 2018 15 次提交
-
-
由 Ryuta Kamizono 提交于
Fix indentation manually
-
由 Yoshiyuki Hirano 提交于
Rubocop auto-correct doesn't work well, so I fixed indentation manually.
-
由 Guillermo Iguaran 提交于
Gracefully handle extra "controller" when generating controller
-
由 Ryuta Kamizono 提交于
In the previous code incorrectly removes intermediate words.
-
由 Ryuta Kamizono 提交于
Rubocop 0.54
-
由 Ryuta Kamizono 提交于
Fix duplicated suffix for JobGenerator
-
由 Ryuta Kamizono 提交于
Add test case to ChannelGeneratorTest
-
由 Yoshiyuki Hirano 提交于
* Add a test case to ensure avoid duplicated suffix in channel generator
-
由 Yoshiyuki Hirano 提交于
-
由 yuuji.yaginuma 提交于
-
由 George Claghorn 提交于
Reset RAW_POST_DATA between test requests
-
由 Ryuta Kamizono 提交于
Follow up of #32514.
-
由 Ryuta Kamizono 提交于
Fix .new with multiple through associations
-
由 Bart de Water 提交于
-
由 Bart de Water 提交于
Fix `.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout` warning
-
- 21 4月, 2018 17 次提交
-
-
由 Ryuta Kamizono 提交于
So `target.is_a?(Array)` is meaningless, and just use `target.empty?` instead of `target.blank?`.
-
由 Yoshiyuki Hirano 提交于
* Rewrite with Vanilla JS * Confirmed with Chrome, Safari, Firefox
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Relax assertions in connection config tests
-
由 Daniel Colson 提交于
At the moment these two ActiveRecord tests pass with `rake test:sqlite3`, but fail with `ARCONN=sqlite3 bin/test`. `Rails.root` is defined when running `bin/test`, but not when running the rake task. When `Rails.root` is defined, `config[:database]` will look something like `vagrant/rails/activerecord/db/primary.sqlite3` instead of just `db/primary.sqlite3`. (See https://github.com/rails/rails/blob/00caf95e14b90782ab17fbd6d2b930844df99980/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L27) Relaxing `assert_equal` to `assert_match` will allow these tests to pass regardless of how they are run. I do have a question why we need both ways to run tests. I have been using `bin/test` lately, but I see from #32426 that this is not the preferred method.
-
由 Eugene Kenny 提交于
`RAW_POST_DATA` is derived from the `rack.input` header, which changes with each test request. It needs to be cleared in `scrub_env!`, or all requests within the same test will see the value from the first request.
-
由 Rafael Mendonça França 提交于
Preloading through polymorphic associations (still raises for typos on regular associations)
-
由 Dana Sherson 提交于
-
由 Rafael França 提交于
Add `touch_all` method to `ActiveRecord::Relation`
-
由 Rafael Mendonça França 提交于
Create MissingExactTemplate exception with separate template
-
由 Rafael França 提交于
[ci skip] belongs_to in self join association needs optional: true, if it's over 5.0 ver of rails
-
由 Guillermo Iguaran 提交于
-
由 Rafael França 提交于
[ci skip] Improve Rails::SourceAnnotationExtractor documentation
-
由 Rafael França 提交于
Allow `primary_key` argument to `empty_insert_statement_value`
-
由 Alberto Almagro 提交于
After renaming and deprecation of SourceAnnotationExtractor documentation has been updated to reflect the new name Rails::SourceAnnotationExtractor
-
由 Alberto Almagro 提交于
The previous documentation version listed only the default registered extensions. This was misleading because if more extensions get registered with <tt>SourceAnnotationExtractor::Annotation.register_extensions</tt>, they would be also taken into account. By saying that we consider all registered extensions we document what happens in reality.
-