- 05 7月, 2018 3 次提交
-
-
由 Rafael França 提交于
Better compatibility with SPEC.
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Use class_eval or instance_eval when triggering lazy load hooks
-
- 04 7月, 2018 9 次提交
-
-
由 Edouard CHIN 提交于
- When lazy load hooks were triggered we were using `Object.instance_eval` which evaluates the block in the context of the class being passed. Most of the time that class was a `Class`. If one wants to define a instance method on the class then it wasn't possible. ```ruby class A; end; A.instance_eval do def foo puts 'bar' end end A.new.foo #> NoMethodError: undefined method `foo` A.foo #> bar ``` - This PR checks what object is passed when triggering the hooks and either call `class_eval` or `instance_eval`. My rational and assumptions being that if an instance of a class is passed, then the blocks needs to evaluate in the context of that instance (i.e. defining a method should only define it on that instance). On the other hand, if a Class or Module is passed when triggering hooks, then defining a method should define it on the class itself - #32776 Pushed me to introduce this change
-
由 Samuel Williams 提交于
If `env` is duped or otherwise not the same as the original `env` that was generated at the top of rack middleware, it is impossible for the server hijack proc to update the right `env` instance. Therefore, capturing the return value is more reliable. This is the recommendation of the rack SPEC.
-
由 Ryuta Kamizono 提交于
Add changelog entry for 42c35370 [ci skip]
-
由 Ryuta Kamizono 提交于
Remove old TODO comment [ci skip]
-
由 Alberto Almagro 提交于
This TODO comment has been here more than 7 years and doesn't seem to be a temporary implementation anymore.
-
由 Juan Broullon 提交于
-
由 Rafael França 提交于
Fix route eager loading
-
由 Rafael França 提交于
ActiveJob::Base no longer dependents on ActiveJob::Serializers
-
由 Kasper Timm Hansen 提交于
Add safe html support to arrays of translations
-
- 03 7月, 2018 9 次提交
-
-
由 Juan Broullon 提交于
-
由 Eileen M. Uchitelle 提交于
Update sprockets to Security release for CVE-2018-3760
-
由 alpaca-tc 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Currently, the seen object cache is shared if join nodes have the same target class. But it is a wrong assumption, we can't share the seen object cache between different join nodes (e.g. `:readonly_account` and `:accounts` have the same target class `Account`, but the instances have the different state `readonly`). Fixes #26805. Closes #27737.
-
由 Kasper Timm Hansen 提交于
Change location for running copy migrations command
-
由 Ryuta Kamizono 提交于
Support readonly option in SQLite3Adapter
-
由 Carl Brasic 提交于
Readonly sqlite database files are very useful as a data format for storing configuration/lookup data that is too complicated for YAML files. But since such files would typically be committed to a source control repository, it's important to ensure that they are truly safe from being inadvertently modified. Unfortunately using unix permissions isn't enough, as sqlite will "helpfully" add the write bit to a database file whenever it's written to. sqlite3-ruby has supported a `:readonly` option since version 1.3.2 (see https://github.com/sparklemotion/sqlite3-ruby/commit/c20c9f5dd2990042) This simply passes that option through to the adapter if present in the config hash. I think this is best considered an adapter-specific option since no other supported database has an identical concept.
-
- 02 7月, 2018 3 次提交
-
-
由 Kasper Timm Hansen 提交于
[ci skip] fix error of a file name
-
由 sohopro 提交于
-
由 Kasper Timm Hansen 提交于
Fix app:update when hyphenated name is given
-
- 01 7月, 2018 5 次提交
-
-
由 Kasper Timm Hansen 提交于
It breaks Active Job when run in isolation. E.g. bin/test test/cases/logging_test.rb: https://travis-ci.org/rails/rails/jobs/398779028 Consider Rafaels suggestion of reviewing the eager loading instead: https://github.com/rails/rails/pull/33234#issuecomment-401027419 This reverts commit cb0fdaac, reversing changes made to a0a1abb3.
-
由 Kasper Timm Hansen 提交于
Firstly, increment and decrement shouldn't care about the particulars of key expiry. They should only know that they have to pass that responsibility on to somewhere else. Secondly, it moves the key normalization back inside the instrumentation like it was originally. I think that matches the original design intention or at the very least it lets users catch haywire key truncation. Thirdly, it moves the changelog entry to the top of the file, where new entries go. I couldn't understand what the entry was saying so I tried to rewrite it.
-
由 Kasper Timm Hansen 提交于
Fix assignment of TESTOPTS in railties test task
-
由 Ryuta Kamizono 提交于
Allow `queue` option to `assert_no_enqueued_jobs`
-
- 30 6月, 2018 9 次提交
-
-
由 bogdanvlviv 提交于
It can be asserted that no jobs are enqueued to a specific queue: ```ruby def test_no_logging assert_no_enqueued_jobs queue: 'default' do LoggingJob.set(queue: :some_queue).perform_later end end ```
-
由 Ryuta Kamizono 提交于
Fix Ruby warnings tickled by the test suite
-
由 Ryuta Kamizono 提交于
Clarify activejob/lib/active_job/test_helper.rb
-
由 Ryuta Kamizono 提交于
Remove erroneous remove_column option from example [ci skip]
-
由 utilum 提交于
-
由 Ryuta Kamizono 提交于
Fix Cache :redis_store increment/decrement ttl check and add more tests.
-
由 Jason Lee 提交于
-
由 bogdanvlviv 提交于
Rename `in_block_job` to `enqueued_job` since this variable can refer not only to jobs that were created in the block. See #33258. Return back accidentally removed test to activejob/test/cases/test_helper_test.rb See #33258. Fix name of tests.
-
由 George Semenov 提交于
-
- 29 6月, 2018 2 次提交
-
-
由 Rafael França 提交于
Fix docs of `assert_no_emails` [ci skip]
-
由 bogdanvlviv 提交于
`assert_no_emails` is shortcut for `assert_emails 0, &block`.
-