- 23 10月, 2018 7 次提交
-
-
由 Ryuta Kamizono 提交于
Remove "Upgrading from Old Versions" from Asset Pipeline Guide [skip ci]
-
由 George Claghorn 提交于
Add missing dot in comment in .gitignore template
-
由 Rafael França 提交于
Unify changelog entries related to `database` option of Rails generators [ci skip]
-
由 Jochem Schulenklopper 提交于
My submission for the tiniest commit and PR contest: add a missing dot in a comment line in the generator template for .gitignore. (I just noticed this missing; consistency is king :-)
-
由 Gannon McGibbon 提交于
Fix #33914 : Remove dependent: :destroy option from the belong_to example since there is a warning associated with the usage of dependent: :destroy along with belongs_to
-
由 Raghu Kamat 提交于
This commit removes the dependent: :destroy option from the belong_to example since there is a warning associated with the usage of dependent: :destroy along with belongs_to. Based on the feedback on the issue #33914, I replaced dependent: :destroy with touch: :books_updated_at which will make the example consistent with the example that already exists on that page. * Also Removing the touch option from the belong_to scopes example as the option doesnt have any relation to association scope.
-
由 Rafael França 提交于
Clarify i18n load paths gotcha
-
- 22 10月, 2018 13 次提交
-
-
由 Gannon McGibbon 提交于
Clarify `I18n.load_paths` vs `Rails.application.config.i18n.load_paths` behaviour. [Gannon McGibbon + Alberto Almagro Sotelo]
-
由 Ryuta Kamizono 提交于
Remove extra call `remove_file` on `rails new` with `--skip_action_cable`
-
由 Eileen M. Uchitelle 提交于
Rename event variable
-
由 Ryuta Kamizono 提交于
Remove yarn's files from `.gitignore` template
-
由 bogdanvlviv 提交于
There is no need to remove this file since the line below removes entire directory in which that file is placed.
-
由 Ryuta Kamizono 提交于
Merge pull request #34277 from bogdanvlviv/remove-javascripts-javascripts_engine-options-for-generators Remove `javascripts` and `javascript_engine` options for generators
-
由 Ryuta Kamizono 提交于
Remove `:javascript` from `Rails::PluginBuilder::PASSTHROUGH_OPTIONS`
-
由 bogdanvlviv 提交于
It is unused since #33079
-
由 bogdanvlviv 提交于
`--javascript` option was removed by 42198064
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
Webpacker already does it, see https://github.com/rails/webpacker/blob/895d2cfc15eda2edae9e667c642a02523d958f53/lib/install/template.rb#L25-L33 I also opened PR https://github.com/rails/webpacker/pull/1765 in order to make it add `/yarn-error.log` file too.
-
由 Bogdan 提交于
* Fix assertions of auto-generated ActiveStorage JS Since #33079 * Correct message on the `assert_equal` failure Related to #33079 * Test ActionCable's js files This commit adds `app/javascript/channels/consumer.js`, and `app/javascript/channels/index.js` to `DEFAULT_APP_FILES` in order to assert their existance in `test_skeleton_is_created`. Related to #33079 * Assert no match `javascript_pack_tag` in `application.html.erb` Since #33079 `rails new` generates `application.html.erb` file with `javascript_pack_tag` instead of `javascript_include_tag`. Note that there some tests that asserting no matching `javascript_include_tag` in the `application.html.erb` file for newly generated rails plugins. It is related to #34009 and shouldn't be changed right now.
-
由 Ryuta Kamizono 提交于
Reduce string allocations in read/write_attribute
-
- 21 10月, 2018 6 次提交
-
-
由 Alberto Almagro 提交于
Improve variable naming by renaming from `e` to `event`. The arguments to rename this are: * The naming `e` is usually a convention used for exceptions. * No other method in this class uses the naming `e`. All other methods are using `event`.
-
由 Eugene Kenny 提交于
When `attr_name` is passed as a symbol, it's currently converted to a string by `attribute_alias?`, and potentially also `attribute_alias`, as well as by the `read_attribute`/`write_attribute` method itself. By converting `attr_name` to a string up front, the extra allocations related to attribute aliases can be avoided.
-
由 Ryuta Kamizono 提交于
Add message to exception in datetime type
-
由 wilddima 提交于
-
由 Francesco Rodríguez 提交于
-
由 Jeremy Daer 提交于
Improve layout of Rails Guides index
-
- 20 10月, 2018 14 次提交
-
-
由 Ryuta Kamizono 提交于
Since #29294, `mattr_acessor` uses kwargs for `instance_reader`, `instance_writer`, and `instance_accessor` options. `thread_mattr_accessor` and `config_accessor` also take the same options, so let's maintain these options handles the same.
-
由 Ryuta Kamizono 提交于
Remove unnecessary escape character
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
`ruby -ractive_support/core_ext/range/conversions.rb -ep` dies with uninitialized constant ActiveSupport
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 yuuji.yaginuma 提交于
If use `run_generator` to run the generator, `--skip-webpack-install` is specified automatically. https://github.com/rails/rails/blob/3101a4136bd62787e252d2658eee23001036fa0f/railties/lib/rails/generators/testing/behaviour.rb#L71 However, when executing the generator independently (for example, to use stub), `webpacker:install` was executed. Since this includes `yarn install`, it should be avoided in unnecessary testing.
-
由 Olivier Lacan 提交于
The previous version wasn’t matching the Rails Guides logo source file listed at https://github.com/rails/homepage/blob/master/materials/rails_guides_logo.psd somehow. It was also a GIF when an 8-bit PNG results in a smaller file (2KB vs 4KB) which should be just as widely compatible with browsers. And that’s just for the 1x version. I added a new 2x version for “retina” or high-density displays and a CSS @media query to progressively enhance with this high density version of the logo. I’ve ensured that this query is supported across browsers by using vendor-specific versions when necessary. See: https://caniuse.com/#feat=css-media-resolution [ci skip]
-
由 Olivier Lacan 提交于
The names are only used in the Guides Index overlay and several of them are longer than they need to be. For example “Ruby on Rails” is mentioned over and over again in the Release Notes section although these are obviously all Rails versions we’re listing. There’s a Maintenance Policy category with a Maintenance Policy article which is redundant. Policies makes much more sense as a category. Similarly, Contributing to Ruby on Rails is both a category and an article. “Contributions” is a better category title. “Ruby on Rails Guides Guidelines” is a gigantic mouthful. We are *in* the Rails Guides, we don’t need to specify what guides we’re talking about here. As a final added advantage, all of these shortenings make the index much easier to parse in order to find an article. [ci skip]
-
由 Olivier Lacan 提交于
This notably allows us to tile each category without pushing the page down vertically as much as we previously did on any viewport wider than mobile sizes. It also means we can fit more guides which will become useful in the future since we have several new guides in the work. Finally the new layout allows three clearly distinct columns to emerge: - Start Here and Rails basics: Models, Views, Controllers, Other Components - Digging Deeper, Extending Rails, Contributing, Maintenance - Release Notes Having Release Notes shoot back up to the top of the third column is great because that makes finding the latest released version and its associated release notes much easier without having to scroll down a bunch. [ci skip]
-
由 Richard Schneeman 提交于
Add guides section on verbose query logs to Debugging
-
由 Matilda Smeds 提交于
* How to upgrade Rails 2.x/3.2 not relevant for this Guide * All configuration changes are already included in Upgrading Ruby on Rails Guide
-