- 04 9月, 2017 5 次提交
-
-
由 Matthew Draper 提交于
While this avoids shell argument parsing, we still pass through everything in our stack.
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
由 Ryuta Kamizono 提交于
Defined scope treats nil as `all`, but scope in associations isn't so. If the result of the scope is nil, most features on associations will be broken. It should treat nil as `all` like defined scope. Fixes #20823.
-
- 03 9月, 2017 2 次提交
-
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
This effectively reverts 200cf32e, restoring a variant of 5a0e0e72.
-
- 02 9月, 2017 16 次提交
-
-
由 Ryuta Kamizono 提交于
Because this is not a test case.
-
由 Ryuta Kamizono 提交于
Remove outdated comment [ci skip]
-
由 yuuji.yaginuma 提交于
We do not use double assign since 61f92f8b.
-
由 Matthew Draper 提交于
-
由 Ryuta Kamizono 提交于
If `reflection_scope.where_clause` is not empty, `through_scope` should be joined the source association. But if `values[:references]` in `reflection_scope` is empty, the source association will not be joined. It should use `source_reflection.table_name` in that case. Fixes #22535. Closes #28763.
-
由 Ryuta Kamizono 提交于
Fix `can't modify frozen String` error in AC::Rendering
-
由 Koichi ITO 提交于
-
由 Ryuta Kamizono 提交于
Replace unnecessary link with typewriter text [ci skip]
-
由 George Claghorn 提交于
-
由 Yoshiyuki Hirano 提交于
-
由 Ryuta Kamizono 提交于
If `reflection_scope.where_clause` is not empty, `through_scope` should be joined the source association. But if the through association doesn't have explicit `:source`, `options[:source]` will be nil and `scope.includes_values` will also be empty. It should use `source_reflection.name` rather than `options[:source]`. Fixed by a26cff3c. Fixes #11078. Fixes #26129. Closes #14312. Closes #29155. Closes #29841.
-
由 Ryuta Kamizono 提交于
Without this fix, preloading `:comments_with_include` will cause the following error: ``` % bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_with_has_many_through_join_model_with_include Using sqlite3 Run options: -n test_eager_with_has_many_through_join_model_with_include --seed 1502 E Error: EagerAssociationTest#test_eager_with_has_many_through_join_model_with_include: ActiveRecord::AssociationNotFoundError: Association named 'post' was not found on Post; perhaps you misspelled it? ```
-
由 Ryuta Kamizono 提交于
If `reflection_scope.where_clause` is empty, `scope` isn't changed. So `scope.eager_loading?` is always false.
-
由 Ryuta Kamizono 提交于
Bump PostgreSQL version to the latest version 9.6 at Travis CI
-
由 Yasuo Honda 提交于
Travis CI new default Ubuntu Trusty supports 9.6 https://docs.travis-ci.com/user/database-setup/#Using-a-different-PostgreSQL-Version
-
由 Ryuta Kamizono 提交于
Remove unnecessary `to_i` for old sqlite3 adapter
-
- 01 9月, 2017 17 次提交
-
-
由 Yasuo Honda 提交于
`to_i` was added for SQLite3 adapter which did not handle number but sqlite3 gem already supports it then `to_i` is unnecessary. else condition is kept for adapters which return string, i.e. mysql(not mysql2) and sqlserver. Renamed `test_cache_does_not_wrap_string_results_in_arrays` to `test_cache_does_not_wrap_results_in_arrays` to explain the current behavior. most of adapters return integer, not only string. * Refer these commits: "future proofing the sqlite3 adapter code" https://github.com/rails/rails/commit/beda2d43d6ac5c3435fc2fba0cbd108c20fe1c67 "Refactor calculation test to remove unneeded SQLite special case." https://github.com/rails/rails/commit/47d568ed3fc701934ebe80b276f3d8bf6951c93f "no need to to_i, sqlite does that for us" https://github.com/rails/rails/commit/6cf44a1bd64ba10497742d70ad78fe68faa16e99
-
由 Ryuta Kamizono 提交于
CI with the latest stable(GA) version of MariaDB 10.2
-
由 Ryuta Kamizono 提交于
Fixes #30496.
-
由 Yasuo Honda 提交于
when tested with MariaDB 10.2.8 or higher Refer #30485 https://mariadb.com/kb/en/the-mariadb-library/alter-table/#drop-column-if-exists-col_name-cascaderestrict > MariaDB starting with 10.2.8 > Dropping a column that is part of a multi-column UNIQUE constraint is not permitted.
-
由 Yasuo Honda 提交于
- Travis CI is migrating Ubuntu version to Trusty - MariaDB 10.2 is supported on Ubuntu Trusty
-
由 Ryuta Kamizono 提交于
This is no longer used since 79a5ea9e.
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
since r59328
-
-
由 Akira Matsuda 提交于
`def a() x = x = 1; end` warns since Ruby 2.5 (r59585)
-
由 Ryuta Kamizono 提交于
Remove needless `silence_warnings`
-
由 yuuji.yaginuma 提交于
Since ff30db13, warning is not show.
-
由 Matthew Draper 提交于
Clarify intentions around method redefinitions
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
Don't use remove_method or remove_possible_method just before a new definition: at best the purpose is unclear, and at worst it creates a race condition. Instead, prefer redefine_method when practical, and silence_redefinition_of_method otherwise.
-
由 George Claghorn 提交于
-