Use proc as default argument to recaculate recipients array every time

add 'include_hidden' option to select tag, closes #5402

Revert "Fixed Issue #2884 ActiveModel::SecurePassword code / rdoc conflict; an elucidated explanation has been provided and ActiveModel en-locale updated to present a less confusing attribute name for 'password_digest' in form errors due to "has_secure_password""

This reverts commit ddbea947.

Reason: Includes non-doc changes.

Fix GH #5399. connection_pools's keys are ActiveRecord::Base::ConnectionSpecification objects.

Do not use the attributes hash in the scaffold functional tests

Undo unwarranted change to coding conventions. I am not a fan of the aesthetics of private/public at the root but more importantly, we should not be changing coding conventions with almost a decades worth of history at a whim. The conventions are there to have a consistent coding style, that is their primary purpose. When there is so much existing code with the existing style, any change will have to lift an enormous burden of proof as to why its overwhelmingly superior. That is not the case here, so this is being reverted.

Fix issue #5193 in master

'module' is reserved word. Sample of code with error - not cool.

Fixed problem when fixture_path is not always defined (incidentally, only when ActiveRecord is according to test_help.rb).

Updated description of #retrieve_collector_from_mimes

allow people to specify custom formatters, use the default formatter in production so that PID and timestamp are logged. fixes #5388

Refactoring of `arel_attributes_values` method

retrieve_cache_key should work on objects that act like arrays.

assert_template matches against Regexp

ensure u2029 is escaped in escape_javascript helper

deprecated clear_stale_active_connections! can call #reap 

deprecated clear_stale_active_connections! can call #reap instead of no-op'ing, #reap does the same thing