- 22 9月, 2016 1 次提交
-
-
由 Kir Shatrov 提交于
TestRequest have been overrriding request_method setter since 2009, but the actual implementation in Request (not TestRequest) has been changed since that. Now it's also using @request_method instance variable to keep the state. The override in TestRequest have not been calling `super`, which caused a bug that after accessing #requst_method the value was memoized and then we've never been able to change it anymore: ``` req = ActionDispatch::TestRequest.create puts "was: #{req.request_method}" # memoized here req.request_method = "POST" puts "became: #{req.request_method}" ``` output: ``` was: GET became: GET ``` Since the whole purpose of overriding the setter in TestRequest is to upcase it, I'm changing it to `super(method.to_s.upcase)`
-
- 09 9月, 2016 1 次提交
-
-
由 Kasper Timm Hansen 提交于
Pass `set_inverse_instance` block to `sc.execute` for `SingularAssociation`
-
- 08 9月, 2016 4 次提交
-
-
由 प्रथमेश Sonpatki 提交于
Fix table name typos [ci skip]
-
由 Waitaya Krongapiradee 提交于
-
由 Jon Moss 提交于
update doc about default `cache_store` [ci skip]
-
由 yuuji.yaginuma 提交于
The default `cache_store` has changed in 8f0e0b63 to use `file_store`.
-
- 07 9月, 2016 14 次提交
-
-
由 Richard Schneeman 提交于
call `.to_h` to avoid using deprecated method
-
由 Vipul A M 提交于
Clarify expires_now documentation
-
由 yuuji.yaginuma 提交于
`ActionController::Parameters#merge` call `HashWithIndifferentAccess#merge`. In addition, it calls `HashWithIndifferentAccess#update` from `HashWithIndifferentAccess#merge`, where it is called the `#to_hash` of argument. But `ActionController::Parameters#to_hash` is deprecated, warning message is displayed. To avoid this, modify to convert object to `Hash`. Fixes #26415
-
由 Nate Berkopec 提交于
[ci skip]
-
由 Vipul A M 提交于
[ci skip] Simply formatting documents
-
由 Neodelf 提交于
-
由 Guillermo Iguaran 提交于
Revert " [ci skip] Remove duplicate example."
-
由 Vipul A M 提交于
-
由 Vipul A M 提交于
[ci skip] Remove duplicate example.
-
由 Aditya Kapoor 提交于
-
由 Vijay Dev 提交于
Selectively add `li ul, li ol { margin:0 1.5em; }` to subColl as needed
-
由 Vipul A M 提交于
Remove the word "mongrel" from documents [ci skip]
-
由 Ryunosuke Sato 提交于
Currently mongrel is not maintained. And it couldn't be built with any Ruby versions that supported by Rails. It is reasonable to remove the word "mongrel" in order to avoid confusion from newcomer.
-
由 Xavier Noria 提交于
Fix Remaining Case-In-Assignment Statement Formatting
-
- 06 9月, 2016 9 次提交
-
-
由 Vipul A M 提交于
Minor grammar fix in engines.md [ci skip]
-
由 Mark Sun 提交于
-
由 Alex Kitchens 提交于
Recently, the Rails team made an effort to keep the source code consistent, using Ruboco (bb1ecdcc and below). Some of the case statements were missed. This changes the case statements' formatting and is consistent with changes in 810dff7c and db63406c.
-
由 Andrew White 提交于
Remove redundant `!loaded?` condition
-
由 Matthew Draper 提交于
Remove not used alias method
-
由 yui-knk 提交于
Bang methods of `AR::QueryMethods` are used only internally. We only use `left_outer_joins!`, so we can remove this alias.
-
由 Ryuta Kamizono 提交于
Already checked `if !find_target? || loaded?`, unnecessary `!loaded?` in elsif condition.
-
由 Andrew White 提交于
Move `require "models/post"` before `require "models/comment"`
-
由 Andrew White 提交于
use `descendants` to get class that inherited `ActiveJob::Base`
-
- 05 9月, 2016 4 次提交
-
-
由 Andrew White 提交于
Remove unnecessary `query_scope`
-
由 Vipul A M 提交于
change `Class#descendants` to public API [ci skip]
-
由 yuuji.yaginuma 提交于
`Class#descendants` has already been displayed in Rails guide, so I think that may be displayed in doc. http://guides.rubyonrails.org/active_support_core_extensions.html#descendants
-
由 yuuji.yaginuma 提交于
`subclasses` get only child classes. Therefore, if create a job common parent class as `ApplicationJob`, inherited class does not get properly.
-
- 04 9月, 2016 7 次提交
-
-
由 Eileen M. Uchitelle 提交于
rename test method to avoid overriding
-
由 Eileen M. Uchitelle 提交于
Remove unnecessary `count` method for collection proxy
-
由 Eileen M. Uchitelle 提交于
make `fixture_file_upload` work in integration tests
-
由 yuuji.yaginuma 提交于
Currently, `fixture_file_upload` does not work in integration test. Because, `TestProcess` module has been include in `Session` class, but `fixture_path` can not get from `Session` class. Modify to include `TestProcess` in `IntegrationTest` class in order to get correct value of `fixture_path`.
-
由 Ryuta Kamizono 提交于
Simply use its own method because `CollectionProxy` inherits `Relation`.
-
由 Vipul A M 提交于
Update ActiveRecord callback guide for exceptions [ci skip]
-
由 Nathan Wenneker 提交于
07d3d402 changed how exceptions are handled in after_commit and after_destroy callbacks. This commit updates the 5.0 release notes and the ActiveRecord callback guide to reflect the new behavior. [ci skip]
-