This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct.

Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to *does* change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things.

Phew, long commit message!

Some basic tests for the :foreign_type option on belongs_to, which was previously completely untested.

If a has_many goes :through a belongs_to, and the foreign key of the belongs_to changes, then the has_many should be considered stale.

- persisted? is the API defined in ActiveModel
- makes it easier for extension libraries to conform to ActiveModel APIs
  without concern for whether the extended object is specifically
  ActiveRecord

[#5927 state:committed]
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Convert :primary_key in association to a string before comparing to column names, so that for example :primary_key => :another_pk works as well [#5605 state:resolved]

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them

[#2786 state:committed]
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

[#5153 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

[#4645 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

[#765 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Oracle stores '' string as NULL
Oracle cannot have identifiers larger than 30 characters
added missing fixtures to test setup method

[#765 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

[#1617 state:resolved]

Ensure belongs_to association with a counter cache in name spaced model works [#1678 state:resolved]
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Ensure methods called on association proxies respect access control. [#1083 state:resolved] [Adam Milligan, Pratik]

There are several situations it doesn't cater for, and the inconsistency isn't worth blocking 2.2.

Support for updating a belongs to association from the foreign key (without saving and reloading the record)
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#142 state:committed]

Signed-off-by: NJoshua Peek <josh@joshpeek.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

belongs_to polymorphic association assignments update the foreign_id and foreign_type fields regardless of whether the record being assigned is new or not.

fixes the following scenarios:
* I have validates_inclusion_of on the type field for a polymorphic belongs_to association.  I assign a new record to the model's polymorphic relationship of the proper type.  validation fails because the type field has not been updated.

* I replace the value for a ppolymorphic association to a new record of another class.  The type field still says its the previous class, and the id field points to the previous record as well.

[#191 state:closed]

belongs_to polymorphic association assignments update the foreign_id and foreign_type fields regardless of whether the record being assigned is new or not.

fixes the following scenarios:
* I have validates_inclusion_of on the type field for a polymorphic belongs_to association.  I assign a new record to the model's polymorphic relationship of the proper type.  validation fails because the type field has not been updated.

* I replace the value for a ppolymorphic association to a new record of another class.  The type field still says its the previous class, and the id field points to the previous record as well.

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#241 state:resolved]