- 09 3月, 2017 5 次提交
-
-
由 eileencodes 提交于
Previously the system test subclasses would call `driven_by` when the app booted and not again when the test was initialized which resulted in the driver from whichever class was called last to be used in tests. In rails/rails#28144 the `driven_by` method was changed to run `use` on setup and `reset` on teardown. While this was a viable fix this really pointed to the problem that system test `driven_by` was a global setting, rather than a per-class setting. To alieviate this problem calling the driver should be done on an instance level, rather than on the global level. I added an `initialize` method to `SystemTestCase` which will call `use` on the superclass driver. Running the server has been moved to `start_application` so that it only needs to be called once on boot and no options from `driven_by` were being passed to it. This required a largish rewrite of the tests. Each test needs to utilize the subclass so that it can properly test the drivers. `ActionDispatch::SystemTestCase` shouldn't be called directly anymore.
-
由 eileencodes 提交于
Since using a browser is only for selenium it doesn't really make sense to have a separate class for handling it there. This brings a lot of the if/else out of the main SystemTestCase class and into the Driver class so we can abstract away all that extra work.
-
由 Xavier Noria 提交于
See the rationale in the comment found in the patch.
-
由 Jon Moss 提交于
Document using `default_url_options` in an ActionMailer class.
-
由 Rafael França 提交于
Tests for delegated public methods on AC::Parameters
-
- 08 3月, 2017 7 次提交
-
-
由 Krzysztof Zych 提交于
-
由 Kasper Timm Hansen 提交于
Use appropriate type in generators test
-
由 yuuji.yaginuma 提交于
This fixes the following thor's warning. ``` Expected string default value for '--generate'; got false (boolean) ```
-
由 T.J. Schuck 提交于
-
由 Jon Moss 提交于
[ci skip]
-
由 Jon Moss 提交于
Document delegated public methods on AC::Parameters
-
由 T.J. Schuck 提交于
[ci skip]
-
- 07 3月, 2017 10 次提交
-
-
由 Vipul A M 提交于
Improve foreign key description in guides
-
由 Andrew White 提交于
In #27674 we changed the migration generator to generate migrations at the path defined in `Rails.application.config.paths` however the code checked for the presence of the `Rails` constant but not the `Rails.application` method which caused problems when using Active Record and generators outside of the context of a Rails application. Fixes #28325.
-
由 Vipul A M 提交于
Remove `:on` option that does ot exist [ci skip]
-
由 yuuji.yaginuma 提交于
That option was removed in 0a683085
-
由 Akira Matsuda 提交于
-
由 Jon Moss 提交于
Fix typo `titlelize` -> `titleize` [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Andrew White 提交于
In 4b685aad the regex in `titlelize` was updated to not match apostrophes to better reflect the nature of the transformation. Unfortunately this had the side effect of breaking capitalization on the first word of a sub-string, e.g: >> "This was 'fake news'".titleize => "This Was 'fake News'" This is fixed by extending the look-behind to also check for a word character on the other side of the apostrophe. Fixes #28312.
-
由 Andrew White 提交于
Update `database.yml` when `rails new <new_app> -d oracle` specified
-
- 06 3月, 2017 11 次提交
-
-
由 Krzysztof Maicher 提交于
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Fix malformed asset_url in ActionController::Renderer
-
由 Andrew White 提交于
Extract `SchemaMigration.all_versions`
-
由 Giorgos Vrettos 提交于
-
由 Andrew White 提交于
Fix `deserialize` with JSON array
-
由 Jon Moss 提交于
Fix `direct` with params example [ci skip]
-
由 Ryuta Kamizono 提交于
Use `SchemaMigration.all_versions` instead of `SchemaMigration.all.map(&:version)` to avoid to instantiate AR objects.
-
由 Ryuta Kamizono 提交于
Fixes #28285.
-
由 yuuji.yaginuma 提交于
Since `ActionController:Parameters` does not inherit `Hash`, need to explicitly convert it to `Hash`. Also, `Parameters#to_h` returns `Hash` whose key is `String`. Therefore, if merge as it is, the value will not be overwritten as expected.
-
由 Jon Moss 提交于
Fix CI failure due to contain <U+2028>
-
- 05 3月, 2017 7 次提交
-
-
由 Ryuta Kamizono 提交于
```diff diff --git a/actionpack/lib/action_controller/metal/redirecting.rb b/actionpack/lib/action_controller/metal/redirecting.rb index a3159c29dd..1836a07d4e 100644 --- a/actionpack/lib/action_controller/metal/redirecting.rb +++ b/actionpack/lib/action_controller/metal/redirecting.rb @@ -50,8 +50,8 @@ module Redirecting # redirect_to post_url(@post), status: 301, flash: { updated_post_id: @post.id } # redirect_to({ action: 'atom' }, alert: "Something serious happened") # - # Statements after redirect_to in our controller get executed, so redirect_to doesn't stop the execution of the function. - <U+2028># To terminate the execution of the function immediately after the redirect_to, use return. + # Statements after +redirect_to+ in our controller get executed, so +redirect_to+ doesn't stop the execution of the function. + # To terminate the execution of the function immediately after the +redirect_to+, use return. # redirect_to post_url(@post) and return def redirect_to(options = {}, response_status = {}) raise ActionControllerError.new("Cannot redirect to nil!") unless options ``` https://travis-ci.org/rails/rails/jobs/207908041#L549
-
由 Eileen M. Uchitelle 提交于
Remove useless `Migrator.schema_migrations_table_name`
-
由 Vipul A M 提交于
[ci skip] Use return with redirect_to
-
由 Eileen M. Uchitelle 提交于
Do not take screenshot if driver does not support screenshot
-
由 eileencodes 提交于
This reverts commit 84c1b107. Reverted #28283 so reverted it's changelog update as well.
-
由 eileencodes 提交于
This reverts commit 0d73f911, reversing changes made to 21ff8a49. We don't want to silence Puma because it's start up messages can be useful (to see threads, port etc). #28109 was instead fixed by not running system tests by defaul with `bin/rails test` in #28286.
-
由 Eileen M. Uchitelle 提交于
Avoid running system tests by default
-