1. 16 1月, 2017 3 次提交
    • K
      Revert "Merge pull request #27686 from koic/friendly_bigdecimal_inspect" · 7c3a99ee
      Kasper Timm Hansen 提交于
      The exact inspect output of a BigDecimal is out of scope for what we're trying
      to communicate about `dup` and `duplicable?` here.
      
      Adding two examples distracts is disctracting, so keep the docs from before
      since our minimal version is Ruby 2.2.2.
      
      [ Koichi ITO, Jon Moss, Kasper Timm Hansen ]
      
      This reverts commit 2163874d, reversing
      changes made to 46fdbc52.
      7c3a99ee
    • K
      Don't guard against `touch: []`. · a0a1ede8
      Kasper Timm Hansen 提交于
      Closes #27683.
      
      Seeing a code sample that leads to what we're guarding against:
      
      ```ruby
      Topic.update_counters(1, replies_count: 1, touch: [])
      ```
      
      It doesn't look like a case people would ever intentionally end
      up with. Thus we're better off sparing the conditional.
      
      Note: it could happen if a method returns an empty array
      that's then passed to `update_counters` and its touchy friends.
      But `[].presence` can fix that once people see their query blow
      up.
      
      [ Eugene Kenny & Kasper Timm Hansen ]
      a0a1ede8
    • K
      Merge pull request #27690 from y-yagi/remove_unused_require · 1f2a2833
      Kasper Timm Hansen 提交于
      remove unused require
      1f2a2833
  2. 15 1月, 2017 20 次提交
  3. 14 1月, 2017 9 次提交
  4. 13 1月, 2017 8 次提交