See parent commit for more info.

Thor will show a deprecation if a command fails and this method is not
define. We should investigate which command we want to return a non-zero
status when it fails but for now I'm just disabling the warning and
keeping the old behavior.

Since 9c913116, if you run `rackup`
in a machine that doesn't have that folder, the server will not start.

This doesn't happen on `rails s` because we create that folder when
starting the server on
https://github.com/rails/rails/blob/8c8b02784a637570451d7810fd3dfed4eae9a77d/railties/lib/rails/commands/server/server_command.rb#L70-L74.

Ruby 2.7 warning: creating a Proc without a block

Add pidfile option to puma config template

When generating a new rails application (rails new) using a custom template that
includes gems from an authenticated source, the user has to provide credentials to
bundler.

One way to do this is by exporting environment variables, for example:

export BUNDLE_GITHUB__COM=user:pass: provides credentials for bundler to fetch
gems from github.com.

The problem this PR addresses is that we are currently scrubs all /BUNDLE_.*/
environment variables by wrapping our system calls in Bundler.with_clean_env.

We do this because we don't want our commands executed against the generated project
to use the generator's bundler environment (e.g. our gems): the generated project should
use it's own configuration.

The problem with Bundler.with_clean_env is that, on top of restoring environment
variables to their original state, it also scrubs any /BUNDLE_.*/ variables, which is harmful for authenticated gem sources.

This PR replaces Bundler.with_clean_env with Bundler.with_original_env, which only
restores environment variables to their initial state, without additional scrubbing.

https://buildkite.com/rails/rails/builds/61006#c49e1c0d-4c3c-4621-bde5-7cb3cde5ef63

[#35782] Allow loading seeds without ActiveJob (~> 5.2.3)

Only override async adapter when seeding

Make application work without tmp directory

This streamlines the lovely foundation Bogdan added. Mainly to add
guidance around encryption keys and remove some backticks.

Finally it adds some mention of how to access these files from Ruby
in apps.

[ Kasper Timm Hansen & bogdanvlviv ]

Improve output of `rails encrypted(:edit/:show) --help`

* Bump RAILS_VERSION
* Bundle
* rake update_versions
* rake changelog:header

If the secret_key_base is nil in dev or test generate a key from random
bytes and store it in a tmp file. This prevents the app developers from
having to share / checkin the secret key for dev / test but also
maintains a key between app restarts in dev/test.

[CVE-2019-5420]
Co-Authored-By: Neileencodes <eileencodes@gmail.com>
Co-Authored-By: NJohn Hawthorn <john@hawthorn.email>

* This `if RUBY_ENGINE == 'ruby'` was meant to only skip `byebug` since
  its introduction in 059bdc34.
  Listen was added in de6ad566.
* Others gems already have appropriate checks for their inclusion.
* Test that the listen gem is included when RUBY_ENGINE is not 'ruby'.

Don't load app environment when editing credentials

Seed database with inline ActiveJob job adapter

Respect Rails.env when running `rails yarn:install`

Fix boolean interaction in scaffold system tests

What is important to tell is that the database configuration could not
be loaded.

Fixes #34296.

Disable content security policy for mailer previews

`spec` is the same variable name as gemspec generated by bundler, and its
intention is easier to understand than a one-letter variable.
https://github.com/bundler/bundler/blob/00fd58eaa69015092ee272c4cb5aa92a5e7ee45c/lib/bundler/templates/newgem/newgem.gemspec.tt#L11

This is follow up 685cf0d5. `spec` is already in use there.

This will avoid gems that are made to be private to be pushed to public
repositories.

In the system test template, enter a value based on label.
However, since `label` method does not use `titleize` by default.
If generate a value including underscore, cannot find a label and the test
will fail.

```
$ ./bin/rails g scaffold user name:string phone_number:string
$ ./bin/rails t test/system/users_test.rb

E

Error:
UsersTest#test_creating_a_User:
Capybara::ElementNotFound: Unable to find field "Phone Number"
    test/system/users_test.rb:18:in `block in <class:UsersTest>'
```

This removes unnecessary `titleize` so that the generated file will pass
even if the attribute contains an underscore.

Log the remote IP addr of clients behind a proxy

`load_default "5.2"` sets
`Rails.application.config.action_view.form_with_generates_ids` to true
but new_framework_defaults_5_2.rb does not mention about it.

refs 36ac675d