1. 28 8月, 2014 4 次提交
    • A
      remove dead code · 7a2622bc
      Aaron Patterson 提交于
      the ERB has already been compiled to Ruby code by the time we're calling
      module_eval.  Nothing that module eval raises will be caught by a blank
      `rescue`, so I think we can remove this
      7a2622bc
    • G
      Merge pull request #16544 from schneems/schneems/death-to-dir-glob · 728f2ebd
      Guillermo Iguaran 提交于
      Refactor out Dir.glob from ActionDispatch::Static
      728f2ebd
    • S
      Refactor out Dir.glob from ActionDispatch::Static · 0b1a87f7
      schneems 提交于
      Dir.glob can be a security concern. The original use was to provide logic of fallback files. Example a request to `/` should render the file from `/public/index.html`. We can replace the dir glob with the specific logic it represents. The glob {,index,index.html} will look for the current path, then in the directory of the path with index file and then in the directory of the path with index.html. This PR replaces the glob logic by manually checking each potential match. Best case scenario this results in one less file API request, worst case, this has one more file API request.
      
      Related to #16464
      
      Update: added a test for when a file of a given name (`public/bar.html` and a directory `public/bar` both exist in the same root directory. Changed logic to accommodate this scenario.
      0b1a87f7
    • Z
      Merge pull request #16723 from rubys/mention_assert_select_changes · 5bcd5a32
      Zachary Scott 提交于
      [ci skip] mention assert_select in release notes
      5bcd5a32
  2. 27 8月, 2014 28 次提交
  3. 26 8月, 2014 8 次提交