- 25 6月, 2013 9 次提交
-
-
由 Yves Senn 提交于
Fixing issue #11083
-
由 Akshay Khole 提交于
Removing other occurrences of `the` appearing twice
-
由 Yves Senn 提交于
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Merge `:action` from routing scope and assign endpoint if both `:controller` and `:action` are present. The endpoint assignment only occurs if there is no `:to` present in the options hash so should only affect routes using the shorthand syntax (i.e. endpoint is inferred from the the path). Fixes #9856
-
由 Yves Senn 提交于
-
由 Guillermo Iguaran 提交于
Flag cookies as secure with ignore case in ActionDispatch::SSL
-
由 Guillermo Iguaran 提交于
ActionDispatch:SSL: don't include STS header in non-https responses
-
由 Rafael Mendonça França 提交于
[ci skip] Conflicts: actionpack/CHANGELOG.md
-
- 24 6月, 2013 7 次提交
-
-
由 Yves Senn 提交于
Remove `another_contract` as it isn't being used
-
由 Vipul A M 提交于
-
由 Yamagishi Kazutoshi 提交于
-
由 Jared Armstrong 提交于
-
由 Guillermo Iguaran 提交于
replace all older rocket sign to new ":" from examples of active record ...
-
由 Rajarshi Das 提交于
-
由 Geoff Buesing 提交于
-
- 23 6月, 2013 3 次提交
-
-
由 Piotr Sarnacki 提交于
Those vars can be used in tasks, which not call load_config.
-
由 Piotr Sarnacki 提交于
In commit d1d7c86d I moved setting migrations paths into activerecord's railtie to remove Rails dependency on databases.rake. However, it introduced a regression, ENGINE_PATH was not available at the moment, so engine's migrations where not added properly to paths. Fix was added at 97a4a771, but it changes a way things work from using ENGINE_PATH to APP_RAKEFILE. Additionally, the config runs when the code loads, while previously it ran in the db:load_config rake task In order to make it more in pair with original version this commit changes the config to run only on load_config task. This code uses the fact that defining a task in rake does not overwrite, but only appends. It also allows to get back to checking for ENGINE_PATH
-
由 José Valim 提交于
Those two files are required by active_support/rails.rb loaded in active_model.rb It is common to require common dependencies on the root files to avoid boilerplate in each file. This reverts commit 763635e3, reversing changes made to 4f46ef36.
-
- 22 6月, 2013 11 次提交
-
-
由 Yves Senn 提交于
Closes #11026
-
由 Yves Senn 提交于
Add explicit dependencies of ActiveSupport to enable independent usage of ActiveModel::Name
-
由 Jon Leighton 提交于
flatten merged join_values before building the joins
-
由 Steven Yang 提交于
There are two missing ActiveSupport dependencies to use ActiveModel::Name class or ActiveModel::Naming module independently. Missing dependencies for Module#delegate defined in `active_support/core_ext/module/delegation`, used at [L148](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L148) Missing dependencies for Object#blank? defined in `active_support/core_ext/object/blank`, used at [L131](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L131)
-
由 Neeraj Singh 提交于
fixes #10669 While joining_values special treatment is given to string values. By flattening the array it ensures that string values are detected as strings and not arrays.
-
由 Carlos Antonio da Silva 提交于
Remove code related to the rails test command
-
由 Robin Dupret 提交于
Remove the mention about this command in the rails command's help message and remove the "t" alias related to it.
-
由 Jon Leighton 提交于
do not load all child records for inverse case
-
由 Neeraj Singh 提交于
currently `post.comments.find(Comment.first.id)` would load all comments for the given post to set the inverse association. This has a huge performance penalty. Because if post has 100k records and all these 100k records would be loaded in memory even though the comment id was supplied. Fix is to use in-memory records only if loaded? is true. Otherwise load the records using full sql. Fixes #10509
-
由 Jon Leighton 提交于
fix bad test by making number that fits for integer
-
由 Neeraj Singh 提交于
PR https://github.com/rails/rails/pull/10566 had to be reverted because after applying the fix test "test_raise_record_not_found_error_when_invalid_ids_are_passed" started failing. In this test invalid_id is being assigned a really large number which was causing following failure when PR #10566 was applied. ``` RangeError: bignum too big to convert into `long long' SELECT `interests`.* FROM `interests` WHERE `interests`.`man_id` = ? AND `interests`.`id` = ? LIMIT 1 [["man_id", 970345987], ["id", 2394823094892348920348523452345]] ``` This test is not failing in master because when test code `man.interests.find(invalid_id)` is executed then interests are fully loaded in memory and no database query is executed. After PR #10566 was merged then test code `man.interests.find(invalid_id)` started executing sql query and hence the error. In case someone is wondering why the second part of query is not failing, then that's because the actual query does not require any variable substituation where the number is large. In that case the sql generate is following. ``` SELECT `interests`.* FROM `interests` WHERE `interests`.`man_id` = ? AND `interests`.`id` IN (8432342, 2390102913, 2453245234523452) [["man_id", 970345987]] ```
-
- 21 6月, 2013 10 次提交
-
-
由 Guillermo Iguaran 提交于
#10428: Added tests for config.assets.precompile
-
由 Carlos Antonio da Silva 提交于
Fix documents for create_join_table [ci skip]
-
由 Carlos Antonio da Silva 提交于
Saying gemcutter => rubygems [ci skip]
-
由 Xavier Noria 提交于
fix the path of action view from actionpack/lib/action_view => actionvie...
-
由 Rajarshi Das 提交于
-
由 Arun Agrawal 提交于
-
由 Xavier Noria 提交于
Backport #11033 to master
-
由 Robin Dupret 提交于
Since docrails as moved from lifo/docrails to rails/docrails we have to ask for commit rights or submit patches directly to the rails repository
-
由 Satoshi Ebisawa 提交于
-
由 Piotr Sarnacki 提交于
Previously when app was mounted as following: class Foo def call(env) [200, {}, [env['PATH_INFO']]] end end RackMountRailsBug::Application.routes.draw do mount RackTest.new => "/foo" end trailing slash was removed from PATH_INFO. For example requesting GET /foo/bar/ on routes defined above would result in a response containing "/foo/bar" instead of "/foo/bar/". This commit fixes the issue. (closes #3215)
-