1. 01 11月, 2019 1 次提交
  2. 20 10月, 2019 1 次提交
  3. 11 10月, 2019 1 次提交
  4. 10 10月, 2019 1 次提交
  5. 03 9月, 2019 1 次提交
  6. 17 8月, 2019 2 次提交
  7. 10 8月, 2019 1 次提交
  8. 09 8月, 2019 1 次提交
  9. 07 8月, 2019 1 次提交
    • E
      Fix Gemfile.lock · fb716a65
      eileencodes 提交于
      The PR #36860 changed ActionView's required version of
      rails-html-sanitizer, but I missed that we needed to run
      bundle, otherwise we end up with changes every time.
      fb716a65
  10. 05 8月, 2019 1 次提交
  11. 23 7月, 2019 1 次提交
  12. 07 7月, 2019 2 次提交
  13. 01 7月, 2019 1 次提交
    • X
      bumps Zeitwerk · f51fae1f
      Xavier Noria 提交于
      This version makes eager loading and autoloading consistent,
      as documented in the upgrading guide.
      f51fae1f
  14. 25 4月, 2019 1 次提交
  15. 23 4月, 2019 1 次提交
    • X
      upgrades Zeitwerk to 2.1.4 · 1b2efe5a
      Xavier Noria 提交于
      This commit more or less undoes 9b5401fc, restores autoloaded? not to
      touch the descendants tracker, and autoloaded_constants because it is
      documented in the guide.
      1b2efe5a
  16. 18 4月, 2019 1 次提交
  17. 16 4月, 2019 1 次提交
    • K
      Bump RuboCop to 0.67.2 · c6379fd2
      Koichi ITO 提交于
      Performance cops will be extracted from RuboCop to RuboCop Performance
      when next RuboCop 0.68 will be released.
      https://github.com/rubocop-hq/rubocop/issues/5977
      
      RuboCop 0.67 is its transition period.
      
      Since rails/rails repository uses Performance cops, This PR added
      rubocop-performance gem to Gemfile.
      
      And this PR fixes some offenses using the following auto-correct.
      
      ```console
      % bundle exec rubocop -a
      
      Offenses:
      
      activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:212:26:
      C: [Corrected] Layout/SpaceAroundOperators: Operator =
      > should be surrounded by a single space.
                    "primary"  => { adapter: "sqlite3", database: "db/primary.sqlite3" }
                               ^^
      activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:239:26:
      C: [Corrected] Layout/SpaceAroundOperators: Operator => should be
      surrounded by a single space.
                    "primary"  => { adapter: "sqlite3", database: "db/primary.sqlite3" }
                               ^^
      actionview/test/template/resolver_shared_tests.rb:1:1: C: [Corrected]
      Style/FrozenStringLiteralComment: Missing magic comment #
      frozen_string_literal: true.
      module ResolverSharedTests
      ^
      actionview/test/template/resolver_shared_tests.rb:10:33: C: [Corrected]
      Layout/SpaceAroundEqualsInParameterDefault: Surrounding space missing in
      default value assignment.
        def with_file(filename, source="File at #{filename}")
                                      ^
      actionview/test/template/resolver_shared_tests.rb:106:5: C: [Corrected]
      Rails/RefuteMethods: Prefer assert_not_same over refute_same.
          refute_same a, b
          ^^^^^^^^^^^
      
      2760 files inspected, 5 offenses detected, 5 offenses corrected
      ```
      c6379fd2
  18. 12 4月, 2019 1 次提交
    • X
      improves the reloading disabled error message · 7b6b1054
      Xavier Noria 提交于
      The original message from Zeitwerk is "can't reload, please call
      loader.enable_reloading before setup (Zeitwerk::Error)", which is not
      very informative for Rails programmers.
      
      Rails should err with a message worded in terms of its interface.
      7b6b1054
  19. 09 4月, 2019 1 次提交
  20. 07 4月, 2019 1 次提交
  21. 05 4月, 2019 1 次提交
  22. 04 4月, 2019 2 次提交
    • F
      Output junit format test report · 61c4be47
      Fumiaki MATSUSHIMA 提交于
      61c4be47
    • R
      Use `execute_batch2` rather than `execute_batch` to fix performance regression for fixture loading · 0908184e
      Ryuta Kamizono 提交于
      d8d6bd5e makes fixture loading to bulk statements by using
      `execute_batch` for sqlite3 adapter. But `execute_batch` is slower and
      it caused the performance regression for fixture loading.
      
      In sqlite3 1.4.0, it have new batch method `execute_batch2`. I've
      confirmed `execute_batch2` is extremely faster than `execute_batch`.
      So I think it is worth to upgrade sqlite3 to 1.4.0 to use that method.
      
      Before:
      
      ```
      % ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids
      Using sqlite3
      Run options: -n test_eager_loading_too_may_ids --seed 35790
      
      # Running:
      
      .
      
      Finished in 202.437406s, 0.0049 runs/s, 0.0049 assertions/s.
      1 runs, 1 assertions, 0 failures, 0 errors, 0 skips
      ARCONN=sqlite3 bundle exec ruby -w -Itest  -n test_eager_loading_too_may_ids  142.57s user 60.83s system 98% cpu 3:27.08 total
      ```
      
      After:
      
      ```
      % ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids
      Using sqlite3
      Run options: -n test_eager_loading_too_may_ids --seed 16649
      
      # Running:
      
      .
      
      Finished in 8.471032s, 0.1180 runs/s, 0.1180 assertions/s.
      1 runs, 1 assertions, 0 failures, 0 errors, 0 skips
      ARCONN=sqlite3 bundle exec ruby -w -Itest  -n test_eager_loading_too_may_ids  10.71s user 1.36s system 95% cpu 12.672 total
      ```
      0908184e
  23. 30 3月, 2019 1 次提交
  24. 27 3月, 2019 3 次提交
  25. 25 3月, 2019 1 次提交
  26. 23 3月, 2019 1 次提交
  27. 22 3月, 2019 1 次提交
  28. 19 3月, 2019 1 次提交
  29. 15 3月, 2019 1 次提交
  30. 14 3月, 2019 1 次提交
  31. 12 3月, 2019 1 次提交
  32. 11 3月, 2019 1 次提交
    • E
      Prep release · 7c87fd56
      eileencodes 提交于
      * Update RAILS_VERSION
      * Bundle
      * rake update_versions
      * rake changelog:header
      7c87fd56
  33. 09 3月, 2019 2 次提交
  34. 07 3月, 2019 1 次提交
    • U
      Update racc to latest version · bfd8e4f7
      utilum 提交于
      racc 1.4.15 includes fixes for compiling with Ruby 2.7 since
      [ruby/ruby@3d1c86a](https://github.com/ruby/ruby/commit/3d1c86a).
      
      Before:
      
      ```
      ruby -v
      ruby 2.7.0dev (2019-03-07 trunk 67189) [x86_64-linux]
      
      bundle install
      ...
      Fetching racc 1.4.14
      Installing racc 1.4.14 with native extensions
      Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
      
      current directory:
      /home/u/.rbenv/versions/2.7.0-dev/lib/ruby/gems/2.7.0/gems/racc-1.4.14/ext/racc
      /home/u/.rbenv/versions/2.7.0-dev/bin/ruby -I
      /home/u/.rbenv/versions/2.7.0-dev/lib/ruby/2.7.0 -r
      ./siteconf20190307-14242-16jzp6c.rb extconf.rb
      checking for rb_ary_subseq()... yes
      creating Makefile
      
      current directory:
      /home/u/.rbenv/versions/2.7.0-dev/lib/ruby/gems/2.7.0/gems/racc-1.4.14/ext/racc
      make "DESTDIR=" clean
      
      current directory:
      /home/u/.rbenv/versions/2.7.0-dev/lib/ruby/gems/2.7.0/gems/racc-1.4.14/ext/racc
      make "DESTDIR="
      make: *** No rule to make target
      '/home/u/.rbenv/versions/2.7.0-dev/include/ruby-2.7.0/defines.h', needed
      by
      'cparse.o'.  Stop.
      
      make failed, exit code 2
      
      Gem files will remain installed in
      /home/u/.rbenv/versions/2.7.0-dev/lib/ruby/gems/2.7.0/gems/racc-1.4.14
      for
        inspection.
        Results logged to
        /home/u/.rbenv/versions/2.7.0-dev/lib/ruby/gems/2.7.0/extensions/x86_64-linux/2.7.0-static/racc-1.4.14/gem_make.out
      
        An error occurred while installing racc (1.4.14), and Bundler cannot
        continue.
        Make sure that `gem install racc -v '1.4.14' --source
        'https://rubygems.org/'`
        succeeds before bundling.
      
        In Gemfile:
          racc
      ```
      bfd8e4f7