- 04 1月, 2014 1 次提交
-
-
由 Godfrey Chan 提交于
Previously, this would give an `ArgumentError`: class Issue < ActiveRecord::Base enum :status, [:open, :finished] end Issue.open.build # => ArgumentError: '0' is not a valid status Issue.open.create # => ArgumentError: '0' is not a valid status PR #13542 muted the error, but the issue remains. This commit fixes the issue by allowing the enum value to be written directly via the setter: Issue.new.status = 0 # This now sets status to :open Assigning a value directly via the setter like this is not part of the documented public API, so users should not rely on this behavior. Closes #13530.
-
- 02 1月, 2014 1 次提交
-
-
由 Robin Dupret 提交于
Previously, the writer methods would simply check whether the passed argument was the symbol representing the integer value of an enum field. Therefore, it was not possible to specify the numeric value itself but the dynamically defined scopes generate where clauses relying on this kind of values so a chained call to a method like `find_or_initialize_by` would trigger an `ArgumentError`. Reference #13530
-
- 11 12月, 2013 1 次提交
-
-
由 Lauro Caetano 提交于
The dynamic finder was creating the method signature with the parameters name, which may have reserved words and this way creating invalid Ruby code. Closes: #13261 Example: # Before Dog.find_by_alias('dog name') # Was creating this method def self.find_by_alias(alias, options = {}) # After Dog.find_by_alias('dog name') # Will create this method def self.find_by_alias(_alias, options = {})
-
- 05 11月, 2013 1 次提交
-
-
由 Pablo Torres 提交于
-
- 04 11月, 2013 2 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
- 03 11月, 2013 2 次提交
-
-
由 Yury Korolev 提交于
-
由 David Heinemeier Hansson 提交于
Added ActiveRecord::Base#enum for declaring enum attributes where the values map to integers in the database, but can be queried by name
-
- 14 10月, 2013 1 次提交
-
-
由 Neeraj Singh 提交于
Currently `scope_chain` uses same array for building different `scope_chain` for different associations. During processing these arrays are sometimes mutated and because of in-place mutation the changed `scope_chain` impacts other reflections. Fix is to dup the value before adding to the `scope_chain`. Fixes #3882.
-
- 06 8月, 2013 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Aaron Patterson 提交于
-
- 18 5月, 2013 1 次提交
-
-
由 Takehiro Adachi 提交于
According to https://github.com/rails/rails/blob/b601399b72ab56cc01368f02615af99f45d1 4f02/activerecord/lib/active_record/counter_cache.rb#L14, u can pass more then one association to the `reset_counters` method.
-
- 28 3月, 2013 1 次提交
-
-
由 Ken Mazaika 提交于
-
- 21 3月, 2013 1 次提交
-
-
由 Ian Young 提交于
-
- 17 3月, 2013 1 次提交
-
-
由 Mack Earnhardt 提交于
PR #5210 added a Friendship model to illustrate a bug, but in doing so created a confusing structure because both belongs_to declarations in Friendship referred to the same side of the join. The new structure maintains the integrity of the bug test while changing the follower relationship to be more useful for other testing.
-
- 08 3月, 2013 1 次提交
-
-
由 Yves Senn 提交于
Closes #9110
-
- 28 2月, 2013 1 次提交
-
-
由 Steve Klabnik 提交于
This reverts commit 408227d9, reversing changes made to dca0b57d.
-
- 26 2月, 2013 1 次提交
-
-
由 Brendon Murphy 提交于
- Extract max timestamp retrieval for cache_key - Update changelog for cache_key changes
-
- 07 2月, 2013 1 次提交
-
-
由 Dylan Smith 提交于
-
- 28 1月, 2013 1 次提交
-
-
由 Jon Leighton 提交于
This caused a bug with the new associations implementation, because now association conditions are represented as Arel nodes internally right up to when the whole thing gets turned to SQL. In Rails 3.2, association conditions get turned to raw SQL early on, which prevents Relation#merge from interfering. The current implementation was buggy when a default_scope existed on the target model, since we would basically end up doing: default_scope.merge(association_scope) If default_scope contained a where(foo: 'a') and association_scope contained a where(foo: 'b').where(foo: 'c') then the merger would see that the same column is representated on both sides of the merge and collapse the wheres to all but the last: where(foo: 'c') Now, the RHS of the merge is left alone. Fixes #8990
-
- 22 12月, 2012 1 次提交
-
-
由 Rafael Mendonça França 提交于
Fix #8575
-
- 11 12月, 2012 1 次提交
-
-
由 Rafael Mendonça França 提交于
Conflicts: activerecord/test/models/bulb.rb activerecord/test/schema/schema.rb
-
- 16 11月, 2012 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 26 10月, 2012 1 次提交
-
-
由 Jon Leighton 提交于
In the end I think the pain of implementing this seamlessly was not worth the gain provided. The intention was that it would allow plain ruby objects that might not live in your main application to be subclassed and have persistence mixed in. But I've decided that the benefit of doing that is not worth the amount of complexity that the implementation introduced.
-
- 02 10月, 2012 1 次提交
-
-
由 lulalala 提交于
The counter column name in the intermediate model need to be access via the through reflection.
-
- 12 9月, 2012 1 次提交
-
-
由 beerlington 提交于
Allows you to specify the model association key in a belongs_to relationship instead of the foreign key. The following queries are now equivalent: Post.where(:author_id => Author.first) Post.where(:author => Author.first) PriceEstimate.where(:estimate_of_type => 'Treasure', :estimate_of_id => treasure) PriceEstimate.where(:estimate_of => treasure)
-
- 06 9月, 2012 1 次提交
-
-
由 Ian Lesperance 提交于
-
- 04 9月, 2012 2 次提交
-
-
由 Yves Senn 提交于
All tests with a custom inheritance_column use the `Vegtable` model. The field ruby_type on the Company models is no longer needed
-
由 Yves Senn 提交于
previously the tests with and without a custom `inheritance_column` used the same models. Since the model then has both fields this can lead to false positives.
-
- 03 9月, 2012 1 次提交
-
-
由 Yves Senn 提交于
I had to create a new table because I needed an STI table, which does not have both a "type" and a "custom_type" the test fails with: 1) Error: test_alt_becomes_works_with_sti(InheritanceTest): NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber"> /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes' test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti' test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
-
- 22 8月, 2012 1 次提交
-
-
由 Dave Desrochers 提交于
reset_counters() was crashing when there were multiple belongs_to associations with the same foreign key. This closes #5200.
-
- 28 7月, 2012 1 次提交
-
-
由 Yasuo Honda 提交于
to address ORA-01400 errors with Oracle enhanced adapter. The original commit 3c0bf043 requires :json_data_empty attribute has empty string OR null, then setting `:default => ""` is enough.
-
- 27 7月, 2012 1 次提交
-
-
由 Yasuo Honda 提交于
to address ORA-01400 errors with Oracle enhanced adapter. Issue #4856 had been fixed and tested with the attribute `:null => false, :default => ""`. Now `:null => false` attribute is not necessary to test this issue.
-
- 26 7月, 2012 1 次提交
-
-
由 Yasuo Honda 提交于
to make store works all database adapters.
-
- 25 7月, 2012 1 次提交
-
-
由 Yasuo Honda 提交于
Issue #6115 has been fixed and tested with the attribute `:null => false, :default => ""` However `:null => false` attribute is not necessary to test this issue, which causes many ORA-01400 errors with Oracle enhanced adapter.
-
- 25 6月, 2012 1 次提交
-
-
由 Piotr Sarnacki 提交于
This commit needs to be reverted because it introduces difficulties when using sqlite3 in development and other databases in production. This happens because when you create time column in sqlite3, it's dumped as datetime in schema.rb file. This reverts commit 57d534ee, reversing changes made to 20f049fb. Conflicts: activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
-
- 22 6月, 2012 1 次提交
-
-
由 Andrew White 提交于
Improve the derivation of HABTM join table name to take account of nesting. It now takes the table names of the two models, sorts them lexically and then joins them, stripping any common prefix from the second table name. Some examples: Top level models (Category <=> Product) Old: categories_products New: categories_products Top level models with a global table_name_prefix (Category <=> Product) Old: site_categories_products New: site_categories_products Nested models in a module without a table_name_prefix method (Admin::Category <=> Admin::Product) Old: categories_products New: categories_products Nested models in a module with a table_name_prefix method (Admin::Category <=> Admin::Product) Old: categories_products New: admin_categories_products Nested models in a parent model (Catalog::Category <=> Catalog::Product) Old: categories_products New: catalog_categories_products Nested models in different parent models (Catalog::Category <=> Content::Page) Old: categories_pages New: catalog_categories_content_pages Also as part of this commit the validity checks for HABTM assocations have been moved to ActiveRecord::Reflection One side effect of this is to move when the exceptions are raised from the point of declaration to when the association is built. This is consistant with other association validity checks.
-
- 16 5月, 2012 1 次提交
-
-
由 Erich Menge 提交于
-
- 14 5月, 2012 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 10 5月, 2012 1 次提交
-
-
由 Victor Costan 提交于
-