- 09 5月, 2019 9 次提交
-
-
由 David Rodríguez 提交于
This is the behavior I naively expect for the operator when used with a single digit, but it's definitely an edge case for it, and it doesn't seem to work as expected for including prereleases. Using >= works fine and make the intention more clear anyways.
-
由 Ryuta Kamizono 提交于
bundle update resque-scheduler to latest version
-
由 Rafael França 提交于
Only build middleware proxy when instrumentating
-
由 John Hawthorn 提交于
The instrumentation proxy adds three stack frames per-middleware, even when nothing is listening. This commit, when the middleware stack is built, only adds instrumentation when the `process_middleware.action_dispatch` event has already been subscribed to. The advantage to this is that we don't have any extra stack frames in apps which don't need middleware instrumentation. The disadvantage is that the subscriptions need to be in place when the middleware stack is built (during app boot). I think this is likely okay because temporary AS::Notifications subscriptions are strongly discouraged.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Rafael França 提交于
Fix indentation for config.eager_load nil warning message
-
由 Vipul A M 提交于
Update testing guide to reflect changes from #36047 [ci skip]
-
由 utilum 提交于
Resque 2.0 includes grammar fixes for warnings tickled by our tests. Updating resque-scheduler also requires and updates resque to version 2.0. ``` $ ruby -v ruby 2.6.2p47 (2019-03-13 revision 67232) [x86_64-linux] ```
-
- 08 5月, 2019 9 次提交
-
-
由 Richard Macklin 提交于
In #36047 we moved `take_failed_screenshot` from an `after_teardown` hook to a `before_teardown` hook. However, I didn't realize the Testing rails guide was explicitly mentioning that it happened inside `after_teardown`. So this updates the docs to be consistent with that change. [ci skip]
-
由 Abhay Nikam 提交于
-
由 Ryuta Kamizono 提交于
This offenced code is introduced from forward ported #36196, since looks like 6-0-stable branch isn't checked by CodeClimate.
-
由 Ryuta Kamizono 提交于
-
由 Xavier Noria 提交于
-
由 Eileen M. Uchitelle 提交于
Hide malformed parameters from error page Accidentally merged this to 6-0-stable so forward porting it to master here instead.
-
由 Ryuta Kamizono 提交于
Update directory name in example commands [ci skip]
-
由 st0012 提交于
-
- 07 5月, 2019 10 次提交
-
-
由 Akira Matsuda 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
Remove ignored_sql from SQLCounter by adding "TRANSACTION" to log name
-
由 Yasuo Honda 提交于
This commit adds "TRANSACTION" to savepoint and commit, rollback statements because none of savepoint statements were removed by #36153 since they are not "SCHEMA" statements. Although, only savepoint statements can be labeled as "TRANSACTION" I think all of transaction related method should add this label. Follow up #36153
-
由 Vipul A M 提交于
Fixed typo of dot position [skip ci]
-
由 soartec-lab 提交于
-
由 Akira Matsuda 提交于
The initializer receives `nil` for these options when no cofigurations were given: https://github.com/rails/rails/blob/v6.0.0.rc1/activerecord/lib/active_record/railtie.rb#L91-L97
-
由 Ryuta Kamizono 提交于
Should attempt `committed!`/`rolledback!` to all enrolled records in the transaction
-
由 Ryuta Kamizono 提交于
Remove unnecessary find_partial method
-
由 st0012 提交于
-
由 Ryuta Kamizono 提交于
Currently, `committed!`/`rolledback!` will only be attempted for the first enrolled record in the transaction, that will cause some problematic behaviors. The first one problem, `clear_transaction_record_state` won't be called even if the transaction is finalized except the first enrolled record. This means that de-duplicated records in the transaction won't refer latest state (e.g. won't happen rolling back record state). The second one problem, the enrolled order is not always the same as the order in which the actions actually happened, the first enrolled record may succeed no actions (e.g. `destroy` has already succeeded on another record during `before_destroy`), it will lose to fire any transactional callbacks. To avoid both problems, we should attempt `committed!`/`rolledback!` to all enrolled records in the transaction.
-
- 06 5月, 2019 3 次提交
-
-
由 Ryuta Kamizono 提交于
The `GC.start` was added at b29e8936, but the finalizer has been removed at 7d0ce785 in #35036.
-
由 Ryuta Kamizono 提交于
Clear Resolvers' cache after RenderTestCases tests
-
由 st0012 提交于
The templates rendered in RenderTestCases tests will be cached by the resolvers unexpectedly. And this will break other tests when executed in certain order. (See https://github.com/rails/rails/issues/36154 for more detail) So to fix this issue, we just need to clear the caches on all resolvers.
-
- 05 5月, 2019 1 次提交
-
-
由 yuuji.yaginuma 提交于
The virtual attributes(`attachment` and `rich_text`) can't set value with `fill_in`. So avoid using it. Once #35885 is merged, will be modified to use it. Also, add checking attachment attached or not for avoiding `DelegationError` when attachment didn't attach.
-
- 04 5月, 2019 2 次提交
-
-
由 yuuji.yaginuma 提交于
This fixes the following warnings. ``` /rails/activemodel/test/cases/nested_error_test.rb:9: warning: method redefined; discarding old test_initialize /rails/activemodel/test/cases/error_test.rb:29: warning: previous definition of test_initialize was here ```
-
由 Ryuta Kamizono 提交于
Recover perf for `pluck` by reverting 9c9c950d…
-
- 03 5月, 2019 5 次提交
-
-
由 Guo Xiang Tan 提交于
This reverts commit 9c9c950d.
-
由 Ryuta Kamizono 提交于
Remove redundant `test_too_many_binds`
-
由 Yasuo Honda 提交于
with `ActiveRecord::BindParameterTest#test_too_many_binds` sqlite adapter has its own `bind_params_length`, `ActiveRecord::BindParameterTest#test_too_many_binds` respects it. * Modified `ActiveRecord::BindParameterTest#test_too_many_binds` to show `bind_params_length` value ``` $ git diff diff --git a/activerecord/test/cases/bind_parameter_test.rb b/activerecord/test/cases/bind_parameter_test.rb index 85685d1d00..83cd07f1d7 100644 --- a/activerecord/test/cases/bind_parameter_test.rb +++ b/activerecord/test/cases/bind_parameter_test.rb @@ -108,6 +108,7 @@ def test_statement_cache_with_sql_string_literal def test_too_many_binds bind_params_length = @connection.send(:bind_params_length) + p bind_params_length topics = Topic.where(id: (1 .. bind_params_length).to_a << 2**63) assert_equal Topic.count, topics.count $ ``` * Executed modified `ActiveRecord::BindParameterTest#test_too_many_binds` ``` $ bin/test test/cases/bind_parameter_test.rb -n test_too_many_binds Using sqlite3 Run options: -n test_too_many_binds --seed 47321 999 . Finished in 0.075249s, 13.2892 runs/s, 26.5784 assertions/s. 1 runs, 2 assertions, 0 failures, 0 errors, 0 skips $ ```
-
由 Yuji Yaginuma 提交于
[ci skip] Correct the stylesheet name used in the guide.
-
由 Alec Clarke 提交于
In the Action Text guides, `app/assets/stylesheets/actiontext.css` is specified as the file used to style the Action Text editor and content but the actual file generated from `rails action_text:install` is `app/assets/stylesheets/actiontext.scss`. This change simply corrects the file extension shown in the guide.
-
- 02 5月, 2019 1 次提交
-
-
由 Alex Kitchens 提交于
Add Action Cable Release Notes
-