1. 09 5月, 2019 9 次提交
  2. 08 5月, 2019 9 次提交
  3. 07 5月, 2019 10 次提交
  4. 06 5月, 2019 3 次提交
  5. 05 5月, 2019 1 次提交
    • Y
      Make generated test work even when using virtual attributes · 85a8bc64
      yuuji.yaginuma 提交于
      The virtual attributes(`attachment` and `rich_text`) can't set value
      with `fill_in`. So avoid using it. Once #35885 is merged, will be
      modified to use it.
      
      Also, add checking attachment attached or not for avoiding
      `DelegationError` when attachment didn't attach.
      85a8bc64
  6. 04 5月, 2019 2 次提交
  7. 03 5月, 2019 5 次提交
    • G
      Recover perf for `pluck` by reverting 9c9c950d. · 25f1e0e3
      Guo Xiang Tan 提交于
      This reverts commit 9c9c950d.
      25f1e0e3
    • R
      Merge pull request #36168 from yahonda/remove_redundant_test_too_many_binds_testcase · 9b0e632d
      Ryuta Kamizono 提交于
      Remove redundant `test_too_many_binds`
      9b0e632d
    • Y
      Remove redundant `test_too_many_binds` · 36483cdb
      Yasuo Honda 提交于
      with `ActiveRecord::BindParameterTest#test_too_many_binds`
      
      sqlite adapter has its own `bind_params_length`, `ActiveRecord::BindParameterTest#test_too_many_binds` respects it.
      
      * Modified `ActiveRecord::BindParameterTest#test_too_many_binds` to show `bind_params_length` value
      
      ```
      $ git diff
      diff --git a/activerecord/test/cases/bind_parameter_test.rb b/activerecord/test/cases/bind_parameter_test.rb
      index 85685d1d00..83cd07f1d7 100644
      --- a/activerecord/test/cases/bind_parameter_test.rb
      +++ b/activerecord/test/cases/bind_parameter_test.rb
      @@ -108,6 +108,7 @@ def test_statement_cache_with_sql_string_literal
      
             def test_too_many_binds
               bind_params_length = @connection.send(:bind_params_length)
      +        p bind_params_length
      
               topics = Topic.where(id: (1 .. bind_params_length).to_a << 2**63)
               assert_equal Topic.count, topics.count
      $
      ```
      
      * Executed modified `ActiveRecord::BindParameterTest#test_too_many_binds`
      
      ```
      $ bin/test test/cases/bind_parameter_test.rb -n test_too_many_binds
      Using sqlite3
      Run options: -n test_too_many_binds --seed 47321
      
      999
      .
      
      Finished in 0.075249s, 13.2892 runs/s, 26.5784 assertions/s.
      1 runs, 2 assertions, 0 failures, 0 errors, 0 skips
      $
      ```
      36483cdb
    • Y
      Merge pull request #36167 from alecclarke/update-file-extension-used-in-guide · 8305d305
      Yuji Yaginuma 提交于
      [ci skip] Correct the stylesheet name used in the guide.
      8305d305
    • A
      [ci skip] Correct the stylesheet name used in the guide. · 4c3231eb
      Alec Clarke 提交于
      In the Action Text guides, `app/assets/stylesheets/actiontext.css`
      is specified as the file used to style the Action Text editor and
      content but the actual file generated from `rails action_text:install`
      is `app/assets/stylesheets/actiontext.scss`.
      
      This change simply corrects the file extension shown in the guide.
      4c3231eb
  8. 02 5月, 2019 1 次提交