- 16 8月, 2015 1 次提交
-
-
由 Rafael Mendonça França 提交于
Convert Releasing Rails guide to Markdown
-
- 15 8月, 2015 27 次提交
-
-
由 Rafael Mendonça França 提交于
Initialize symbols instead of mapping to_sym on the set of strings
-
由 Marcin Olichwirowicz 提交于
-
由 maclover7 提交于
-
由 Aaron Patterson 提交于
The outer router object already keeps a hash of named routes, so we should just use that.
-
由 Claudio B. 提交于
Small fixes [ci skip]
-
由 Aaron Patterson 提交于
refactor the tests with a backwards compatible method call so we can rm add_route2 from the journey router
-
由 Aaron Patterson 提交于
then we can let the mapping object derive stuff that the Route object needs.
-
由 Aaron Patterson 提交于
now that we aren't doing options manipulations, we can just pass the mapping object down and read values from it.
-
由 Alexey Markov 提交于
-
由 Aaron Patterson 提交于
since we've extracted the `to` initialization, there's no need for `process_path`
-
由 Aaron Patterson 提交于
if `to` was initialized, this method would return, so we can eliminate the to ||= in the conditional. Finally, let's return a nil in the else block so that it's explicit that this method can return nil
-
由 Aaron Patterson 提交于
Eventually we'll pull this up and delete `process_path`.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
We don't need a method for something like this. I want to pull this up the stack as well and move the module + :controller ArgumentError up the stack as well
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
now we don't need to add it to a hash and delete it from the hash later just to pass it around
-
由 Aaron Patterson 提交于
`add_route` needs the AST, so rather than shove it in a hash and delete later, lets move parsing up the stack so we can pass down later
-
由 Aaron Patterson 提交于
also change the feeler to subclass AD::Request so that it has all the methods that Request has
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Eventually I want to eliminate the FakeSet test class
-
由 Aaron Patterson 提交于
I'm going to reimplement this using route objects, so it will be easier if we just change ast access to go through a method rather than hashes
-
由 Aaron Patterson 提交于
we don't need to keep adding it and deleting if from hashes.
-
由 Aaron Patterson 提交于
Eventually I want to pull up AST generation so that we don't have to add it to the `conditions` hash.
-
由 Rafael Mendonça França 提交于
Add method_source dependency to activesupport
-
由 Rafael Mendonça França 提交于
We already have rake install command that does the same thing.
-
由 Rafael Mendonça França 提交于
Remove `version` argument in install.rb
-
- 14 8月, 2015 12 次提交
-
-
由 Kite 提交于
-
由 Kasper Timm Hansen 提交于
Fix middleware deprecation message. Related to #21172.
-
由 Jon Atack 提交于
-
由 Claudio B. 提交于
[ci skip] SQL is written using statements, not sentences
-
由 Aaron Patterson 提交于
It just constructs a Path::Pattern object with the AST that it already has
-
由 Aaron Patterson 提交于
This was a useless object. We can just directly construct a Path::Pattern object without a Strexp object.
-
由 Aaron Patterson 提交于
the caller already has it, there is no reason to pack it in to an object and just throw that object away.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
we always pass all parameters, so there is no reason to provide default arguments.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
the caller already has access to `as`, so we can stop passing it around.
-
由 Aaron Patterson 提交于
the same value that is extracted from the options hash earlier is returned, so we don't need to pass it in in the first place. The caller already has the data, so stop passing it around.
-