- 08 12月, 2015 4 次提交
-
-
由 Andrey Nering 提交于
-
由 Kasper Timm Hansen 提交于
Fix #22232: rake test tasks exit status code
-
由 Arkadiusz Fal 提交于
The exit status code was not set when tests were fired with `rake`. Now, it is being set and it matches behavior of running tests via `rails` command (`rails test`), so no matter if `rake test` or `rails test` command is used the exit code will be set.
-
由 Kasper Timm Hansen 提交于
We had 2 pull requests erronously trying to remove the first command. Add some comments for clarity.
-
- 07 12月, 2015 16 次提交
-
-
由 eileencodes 提交于
Per this comment https://github.com/rails/rails/pull/18334#issuecomment-69234050 we want `protect_from_forgery` to default to `prepend: false`. `protect_from_forgery` will now be insterted into the callback chain at the point it is called in your application. This is useful for cases where you want to `protect_from_forgery` after you perform required authentication callbacks or other callbacks that are required to run after forgery protection. If you want `protect_from_forgery` callbacks to always run first, regardless of position they are called in your application, then you can add `prepend: true` to your `protect_from_forgery` call. Example: ```ruby protect_from_forgery prepend: true ```
-
由 Santiago Pastorino 提交于
remove `request_forgery_protection` initializer from rails api
-
由 Matthew Draper 提交于
Add missing require to strong_parameters.rb
-
由 Rafael França 提交于
Typo correction
-
由 Yves Siegrist 提交于
In the doc the `dependent` option was set with: `dependent: destroy`. This is not working because destroy would call the method of the activerecord::base object. The right way is: `dependent: :destroy`
-
由 Rafael França 提交于
[ci skip] Add a dollar sign to each command in the READMEs
-
由 Arthur Neves 提交于
The problem was that when saving an object, we would call touch_later on the parent which wont be saved immediteally, and it wont call any callbacks. That was working one level up because we were calling touch, during the touch_later commit phase. However that still didnt solve the problem when you have a 3+ levels of parents to be touched, as calling touch would affect the parent, but it would be too late to run callbacks on its grand-parent. The solution for this, is instead, call touch_later upwards when the first touch_later is called. So we make sure all the timestamps are updated without relying on callbacks. This also removed the hard dependency BelongsTo builder had with the TouchLater module. So we can still have the old behaviour if TouchLater module is not included. [fixes 5f5e6d92] [related #19324]
-
由 eileencodes 提交于
We don't want to commit the cookie jar more than once because then we will be attempting to modify a frozen hash. Fixes Railties test failure caused by 492b1344.
-
由 eileencodes 提交于
This adds a new method to request and response so we don't need to violate the law of demeter. We are changing `Request` and `Response` so that they always have a `cookie_jar` This is a continuation on work to combine integration and controller test code bases in Rails.
-
由 eileencodes 提交于
We want to get rid of the `Live::Response` so we are consolidating methods from `Live::Response` and `Response` by merging them together. This adds an `#empty` method to the request so we don't need to hard-code the empty array each time we call an empty `ActionDispatch::Request`. The work here is a continuation on combining controller and integration test code bases into one.
-
由 David Heinemeier Hansson 提交于
Introduce after_{create,update,delete}_commit callbacks
-
由 Genadi Samokovarov 提交于
Those are actually shortcuts for `after_commit`. Before: after_commit :add_to_index_later, on: :create after_commit :update_in_index_later, on: :update after_commit :remove_from_index_later, on: :destroy After: after_create_commit :add_to_index_later after_update_commit :update_in_index_later after_destroy_commit :remove_from_index_later
-
由 Eileen M. Uchitelle 提交于
Subscribing to notifications while inside the said instrumented section
-
由 Eileen M. Uchitelle 提交于
Test against the real value of tld_length unless explicitly set
-
由 Elektron1c97 提交于
According to pr #22443 in the guides there's always a dollar sign before every command, so why is in the main README a `$` and in every submodule a `%`? Just eye candy..
-
由 Eileen M. Uchitelle 提交于
add test for namespaced model name translation
-
- 06 12月, 2015 14 次提交
-
-
由 Kasper Timm Hansen 提交于
Reading `Rails::Commands::Command` feels excessive. Especially if users can subclass command to write their own commands — which I'd like to aim for. Switch to `Rails::Command` before we get too far into things.
-
由 Kasper Timm Hansen 提交于
We should first attempt to run commands through Rails command, and then fall back to trying the commands tasks. Because eventually the commands tasks should be their own commands.
-
由 Kasper Timm Hansen 提交于
When attempting to run a `rake` task with `bin/rails`, Rails would see check that a Rake task existed and ask users if they meant to run it with rake. We don't need that anymore, as the goal is to have `rails` be a valid way to run rake tasks.
-
由 Kasper Timm Hansen 提交于
The class level version is responsible for changing a task name to command name, then finding a command and run it if there is one. The instance level `run` then makes sure arguments have been parsed into `@options` and runs the command by sending it. `Rails::Commands::Command.run` returns true to make it work within `Rails::CommandsTask`, but won't in the future when it handles all option parsing.
-
由 yuuji.yaginuma 提交于
In rails api, since default is so as not to use the `protect_from_forgery`, `request_forgery_protection` initializer I think that's unnecessary
-
由 Arthur Nogueira Neves 提交于
Add redirection path in the error message of assert_response if response is :redirect
-
由 Kasper Timm Hansen 提交于
When `parse_options_for` was called for a command that hadn't set up any option parsing with `options_for`, the `call` method would be sent to `-> {}`, which didn't like to be passed two arguments. Switch to `proc {}` which can accept several arguments.
-
由 Arthur Nogueira Neves 提交于
even if a write fails, store the raw value
-
由 Kasper Timm Hansen 提交于
I want to streamline the wording around `command`, and not start pondering about instances.
-
由 Kasper Timm Hansen 提交于
The `ARGV` constant in Ruby is not a string, it's an array as demonstrated by running: ``` $ ruby -e "p ARGV" => [] $ $ ruby -e "p ARGV" test/file.rb --version=2 => ["test/file.rb", "--version=2"] ```
-
由 Kasper Timm Hansen 提交于
* Ditch the instance methods local variable. * Prefer Ruby's default nil return, and remove else branch.
-
由 Kasper Timm Hansen 提交于
Checking that a command exists before running it is an implementation detail of the Rails command and Rake task world right now. Eventually I'd like to get rid of `exists?`, when I've worked out another way to fall back to run the old tasks.
-
由 Kasper Timm Hansen 提交于
Users shouldn't have to lookup the command name for a task. Put it in the private section, so it doesn't show up in any generated documentation.
-
由 Matthew Draper 提交于
The previous spelling seemed a bit too generous with the whitespace, and looked out of place when amongst others.
-
- 05 12月, 2015 6 次提交
-
-
由 Sean Griffin 提交于
Add note about serialization to update_columns documentation [ci skip]
-
由 James Wen 提交于
-
由 Sean Griffin 提交于
remove warning from postgresql geometric test
-
由 yuuji.yaginuma 提交于
This removes the following warning which has been out in the case of a PostgreSQL 9.3 below. ``` activerecord/test/cases/adapters/postgresql/geometric_test.rb:265: warning: instance variable @connection not initialized ```
-
由 Kasper Timm Hansen 提交于
Add Rails command infrastructure
-
由 claudiob 提交于
The file [references Rack::Test here](https://github.com/rails/rails/blame/master/actionpack/lib/action_controller/metal/strong_parameters.rb#L671) so it's better off requiring 'rack/test' in the first place.
-