1. 31 10月, 2016 1 次提交
  2. 22 10月, 2016 1 次提交
  3. 10 10月, 2016 1 次提交
    • R
      Dump index options to pretty format · 5025fd3a
      Ryuta Kamizono 提交于
      ```ruby
        # Before
        t.index ["firm_id", "type", "rating"], name: "company_index", order: {"rating"=>:desc}, using: :btree
      
        # After
        t.index ["firm_id", "type", "rating"], name: "company_index", order: { rating: :desc }, using: :btree
      ```
      5025fd3a
  4. 12 9月, 2016 1 次提交
  5. 16 8月, 2016 1 次提交
  6. 07 8月, 2016 1 次提交
  7. 24 7月, 2016 1 次提交
  8. 10 7月, 2016 1 次提交
  9. 07 6月, 2016 1 次提交
  10. 25 4月, 2016 1 次提交
  11. 19 4月, 2016 1 次提交
  12. 06 4月, 2016 1 次提交
    • L
      Fix undefined method `owners' for NullPreloader:Class · cb4f6875
      Ladislav Smola 提交于
      * Fix undefined method `owners' for NullPreloader:Class
      
      Fixing undefined method `owners' for
      ActiveRecord::Associations::Preloader::NullPreloader:Class
      
      * Use Ruby 1.9 hash format
      
      Use Ruby 1.9 hash format
      
      #24192
      
      [Rafael Mendonça França + Ladislav Smola]
      cb4f6875
  13. 30 3月, 2016 1 次提交
  14. 08 3月, 2016 1 次提交
  15. 22 2月, 2016 1 次提交
  16. 20 2月, 2016 1 次提交
  17. 18 2月, 2016 1 次提交
    • J
      Fix issue #23625 · 55385c8a
      Jon Moss 提交于
      This resolves a bug where if the primary key used is not `id` (ex:
      `uuid`), and has a `validates_uniqueness_of` in the model, a uniqueness error
      would be raised. This is a partial revert of commit `119b9181`, which introduced this behavior.
      55385c8a
  18. 31 1月, 2016 2 次提交
  19. 25 1月, 2016 1 次提交
  20. 23 1月, 2016 1 次提交
    • S
      Use the database type to deserialize enum · 67c17190
      Sean Griffin 提交于
      This fixes incorrect assumptions made by e991c7b8 that we can assume the
      DB is already casting the value for us. The enum type needs additional
      information to perform casting, and needs a subtype.
      
      I've opted not to call `super` in `cast`, as we have a known set of
      types which we accept there, and the subtype likely doesn't accept them
      (symbol -> integer doesn't make sense)
      
      Close #23190
      67c17190
  21. 15 1月, 2016 1 次提交
  22. 13 1月, 2016 2 次提交
  23. 10 1月, 2016 1 次提交
  24. 05 1月, 2016 1 次提交
    • R
      Add short-hand methods for text and blob types in MySQL · 4d4239f9
      Ryuta Kamizono 提交于
      In Pg and Sqlite3, `:text` and `:binary` have variable unlimited length.
      But in MySQL, these have limited length for each types (ref #21591, #21619).
      This change adds short-hand methods for each text and blob types.
      
      Example:
      
          create_table :foos do |t|
            t.tinyblob   :tiny_blob
            t.mediumblob :medium_blob
            t.longblob   :long_blob
            t.tinytext   :tiny_text
            t.mediumtext :medium_text
            t.longtext   :long_text
          end
      4d4239f9
  25. 04 1月, 2016 1 次提交
  26. 19 12月, 2015 1 次提交
  27. 02 12月, 2015 1 次提交
    • Y
      tests, pluralize singular table name. · 0f82f661
      Yves Senn 提交于
      This solves the following error:
      
           ActiveRecord::StatementInvalid: Could not find table 'guitars'
      
      It seems that the table structure of the `Guitar` model has not been
      necessary until now. Due to the wrong table name the model was not
      correctly linked to the table.
      0f82f661
  28. 16 11月, 2015 1 次提交
    • Y
      Except keys of `build_record`'s argument from `create_scope` in initialize_attributes · 817c1825
      yui-knk 提交于
      If argument of `build_record` has key and value which is same as
      default value of database, we should also except the key from
      `create_scope` in `initialize_attributes`.
      Because at first `build_record` initialize record object with argument
      of `build_record`, then assign attributes derived from Association's scope.
      In this case `record.changed` does not include the key, which value is
      same as default value of database, so we should add the key to except list.
      
      Fix #21893.
      817c1825
  29. 15 10月, 2015 2 次提交
  30. 27 9月, 2015 1 次提交
    • E
      Fix regression in inverse_of on through associations · ee824c88
      eileencodes 提交于
      `inverse_of` on through associations was accidently removed/caused to
      stop working in commit f8d2899d which was part of a refactoring on
      `ThroughReflection`.
      
      To fix we moved `inverse_of` and `check_validity_of_inverse!` to the
      `AbstractReflection` so it's available to the `ThroughReflection`
      without having to dup any methods. We then need to delegate `inverse_name`
      method in `ThroughReflection`. `inverse_name` can't be moved to
      `AbstractReflection` without moving methods that set the instance
      variable `@automatic_inverse_of`.
      
      This adds a test that ensures that `inverse_of` on a `ThroughReflection`
      returns the correct class name, and the correct record for the inverse
      relationship.
      
      Fixes #21692
      ee824c88
  31. 24 9月, 2015 1 次提交
  32. 23 9月, 2015 3 次提交
    • S
      0 precision is not the same as no precision · 2c7d0d42
      Sean Griffin 提交于
      And we are passing them as separate types in the query, which means 0
      precision is still not supported by older versions of MySQL. I also
      missed a handful of other cases where they need to be conditionally
      applied.
      2c7d0d42
    • S
      Don't attempt to specify datetime precision unless supported · f696494a
      Sean Griffin 提交于
      Specifically, versions of MySQL prior to 5.6 do not support this, which
      is what's used on Travis by default. The method `mysql_56?` appeared to
      only ever be used to conditionally apply subsecond precision, so I've
      generalized it and used it more liberally.
      
      This should fix the test failures caused by #20317
      f696494a
    • B
      Fixed taking precision into count when assigning a value to timestamp attribute · d03f5196
      Bogdan Gusiev 提交于
      Timestamp column can have less precision than ruby timestamp
      In result in how big a fraction of a second can be stored in the
      database.
      
        m = Model.create!
        m.created_at.usec == m.reload.created_at.usec
          # => false
          # due to different seconds precision in Time.now and database column
      
      If the precision is low enough, (mysql default is 0, so it is always low
      enough by default) the value changes when model is reloaded from the
      database. This patch fixes that issue ensuring that any timestamp
      assigned as an attribute is converted to column precision under the
      attribute.
      d03f5196
  33. 22 9月, 2015 1 次提交
  34. 21 9月, 2015 1 次提交
  35. 24 8月, 2015 1 次提交
    • A
      Only nullify persisted has_one target associations · 19b168e6
      Agis- 提交于
      Since after 87d1aba3 `dependent: :destroy` callbacks on has_one
      assocations run *after* destroy, it is possible that a nullification is
      attempted on an already destroyed target:
      
          class Car < ActiveRecord::Base
            has_one :engine, dependent: :nullify
          end
      
          class Engine < ActiveRecord::Base
            belongs_to :car, dependent: :destroy
          end
      
          > car = Car.create!
          > engine = Engine.create!(car: car)
          > engine.destroy! # => ActiveRecord::ActiveRecordError: cannot update a
          >   destroyed record
      
      In the above case, `engine.destroy!` deletes `engine` and *then* triggers the
      deletion of `car`, which in turn triggers a nullification of `engine.car_id`.
      However, `engine` is already destroyed at that point.
      
      Fixes #21223.
      19b168e6