1. 01 7月, 2019 1 次提交
  2. 30 6月, 2019 1 次提交
  3. 29 6月, 2019 1 次提交
  4. 28 6月, 2019 4 次提交
    • R
      Add "SCHEMA" to the query in `configure_connection` like as other adapters · 1eb5cc13
      Ryuta Kamizono 提交于
      This makes to be able to ignore the query in `assert_queries` even if
      accidentally reconnected a connection.
      
      https://buildkite.com/rails/rails/builds/61917#4c49187a-3173-4d5c-8a8d-d65768f5bfc9/1000-1799
      1eb5cc13
    • U
      warning: instance variable @serial not initialized (#36556) · 12bc7593
      utilum 提交于
      Introduced in bba7c63a
      
      Before:
      
      ```
      $ TESTOPTS="-n=/test_yaml_dump_and_load/" bundle exec rake
      test:postgresql
      
      :scisors: ... :scisors:
      
      Using postgresql
      Run options: -n=/test_yaml_dump_and_load/ --seed 36896
      
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      /home/u/code/rails/activerecord/lib/active_record/connection_adapters/postgresql/column.rb:15:
      warning: instance variable @serial not initialized
      .
      
      Finished in 0.195325s, 5.1197 runs/s, 35.8376 assertions/s.
      1 runs, 7 assertions, 0 failures, 0 errors, 0 skips
      
      ```
      Co-authored-by: NRyuta Kamizono <kamipo@gmail.com>
      12bc7593
    • E
      Merge pull request #36565 from rails/fix-url-configs · 04d2fda1
      Eileen M. Uchitelle 提交于
      Fix broken url configs
      04d2fda1
    • E
      Fix broken url configs · f2ad69fe
      eileencodes 提交于
      This PR is to fix #36559 but I also found other issues that haven't been
      reported.
      
      The check for `(config.size == 1 && config.values.all? { |v| v.is_a?
      String })` was naive. The only reason this passed was because we had
      tests that had single hash size configs, but that doesn't mean we don't
      want to create a hash config in other cases. So this now checks for
      `config["database"] || config["adapter"] || ENV["DATABASE_URL"]`. In the
      end for url configs we still get a UrlConfig but we need to pass through
      the HashConfig to create the right kind of UrlConfig. The UrlConfig's
      are really complex and I don't necessarily understand everything that's
      needed in order to act the same as Rails 5.2.
      
      I edited the connection handler test to demonstrate how the previous
      implementation was broken when checking config size. Now old and new
      tests pass so I think this is closer to 5.2.
      
      Fixes #36559
      f2ad69fe
  5. 27 6月, 2019 4 次提交
  6. 26 6月, 2019 3 次提交
  7. 25 6月, 2019 4 次提交
  8. 24 6月, 2019 1 次提交
  9. 23 6月, 2019 1 次提交
  10. 22 6月, 2019 4 次提交
    • B
      Rely on Kernel require instead of self require · 968fcd6b
      Benoit Tigeot 提交于
      With this code (exctracted from derailed_benchmarks):
      
      ```ruby
      
      require "bundler/inline"
      
      gemfile(true) do
        source "https://rubygems.org"
      
        gem "rails", "~> 6.0.0.rc1", require: false
      end
      
      FILES = [
        "rails/engine/configuration",
        "rails/source_annotation_extractor",
        "active_support/deprecation"
      ]
      
      module Kernel
        alias :original_require :require
      
        def require(file)
          Kernel.require(file)
        end
      
        class << self
          alias :original_require :require
        end
      end
      
      Kernel.define_singleton_method(:require) do |file|
        original_require(file)
      end
      
      FILES.each do |file|
        puts "requiring file: #{file}"
        require file
      end
      ```
      
      It fails with Rails 6 and the change introduced by 32065
      ```
      requiring file: rails/engine/configuration
      requiring file: rails/source_annotation_extractor
      Traceback (most recent call last):
      	11: from repro_derailed.rb:33:in `<main>'
      	10: from repro_derailed.rb:33:in `each'
      	 9: from repro_derailed.rb:35:in `block in <main>'
      	 8: from repro_derailed.rb:21:in `require'
      	 7: from repro_derailed.rb:30:in `block in <main>'
      	 6: from repro_derailed.rb:30:in `require'
      	 5: from /Users/benoit.tigeot/.rvm/gems/ruby-2.5.1/gems/railties-6.0.0.rc1/lib/rails/source_annotation_extractor.rb:8:in `<top (required)>'
      	 4: from /Users/benoit.tigeot/.rvm/gems/ruby-2.5.1/gems/activesupport-6.0.0.rc1/lib/active_support/deprecation/proxy_wrappers.rb:10:in `new'
      	 3: from /Users/benoit.tigeot/.rvm/gems/ruby-2.5.1/gems/activesupport-6.0.0.rc1/lib/active_support/deprecation/proxy_wrappers.rb:10:in `new'
      	 2: from /Users/benoit.tigeot/.rvm/gems/ruby-2.5.1/gems/activesupport-6.0.0.rc1/lib/active_support/deprecation/proxy_wrappers.rb:125:in `initialize'
      	 1: from /Users/benoit.tigeot/.rvm/gems/ruby-2.5.1/gems/activesupport-6.0.0.rc1/lib/active_support/deprecation/proxy_wrappers.rb:23:in `method_missing'
      /Users/benoit.tigeot/.rvm/gems/ruby-2.5.1/gems/activesupport-6.0.0.rc1/lib/active_support/deprecation/proxy_wrappers.rb:148:in `warn': private method `warn' called for nil:NilClass (NoMethodError)
      ```
      
      Related:
      - https://github.com/schneems/derailed_benchmarks/pull/130
      - https://github.com/rails/rails/pull/32065
      968fcd6b
    • A
      Indentation >> · a2a515d9
      Akira Matsuda 提交于
      a2a515d9
    • K
      ef1dbd8c
    • K
      Merge pull request #36529 from Shopify/schema-cache-deduplication-init-with · 75a0cf4f
      Kasper Timm Hansen 提交于
      Also deduplicate schema cache data when using the init_with interface
      75a0cf4f
  11. 21 6月, 2019 5 次提交
  12. 20 6月, 2019 11 次提交