1. 31 12月, 2019 1 次提交
  2. 28 12月, 2019 1 次提交
  3. 26 12月, 2019 1 次提交
  4. 07 8月, 2019 1 次提交
  5. 23 4月, 2019 1 次提交
    • S
      Add ActionController::Caching into api app's document · e75452a7
      st0012 提交于
      Rails doesn't support view caching in api controllers by default but the
      document didn't clearerly declare this nor the manual config needed
      after including the module manually. So we'll see people get confused
      like #35602.
      e75452a7
  6. 07 3月, 2019 1 次提交
  7. 03 2月, 2019 1 次提交
    • G
      Cleanup the whitelisting references after #33145 · ca62dfee
      Genadi Samokovarov 提交于
      During the development of #33145, I have named a few concepts in the
      code as `whitelisted`. We decided to stay away from the term and I
      adjusted most of the code afterwards, but here are the cases I forgot to
      change.
      
      I also found a case in the API guide that we could have cleaned up as
      well.
      
      [ci skip]
      ca62dfee
  8. 24 7月, 2018 1 次提交
  9. 07 7月, 2018 1 次提交
    • A
      Recommend use of rails over bin/rails · 40b209db
      Alberto Almagro 提交于
      As discussed in #33203 rails command already looks for, and runs,
      bin/rails if it is present.
      
      We were mixing recommendations within guides and USAGE guidelines,
      in some files we recommended using rails, in others bin/rails and
      in some cases we even had both options mixed together.
      40b209db
  10. 11 5月, 2018 1 次提交
    • A
      Added a lot of Oxford commas · 25867024
      Anthony Crumley 提交于
      [ci skip] A regular expression was used to find a lot of missing Oxford
      commas and add them.  The regular expression was as follows.
      
      ", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
      25867024
  11. 31 3月, 2018 1 次提交
  12. 30 3月, 2018 1 次提交
    • D
      Deprecate controller level force_ssl · 4701a50b
      Derek Prior 提交于
      Today there are two common ways for Rails developers to force their
      applications to communicate over HTTPS:
      
      * `config.force_ssl` is a setting in environment configurations that
        enables the `ActionDispatch::SSL` middleware. With this middleware
        enabled, all HTTP communication to your application will be redirected
        to HTTPS. The middleware also takes care of other best practices by
        setting HSTS headers, upgrading all cookies to secure only, etc.
      * The `force_ssl` controller method redirects HTTP requests to certain
        controllers to HTTPS.
      
      As a consultant, I've seen many applications with misconfigured HTTPS
      setups due to developers adding `force_ssl` to `ApplicationController`
      and not enabling `config.force_ssl`. With this configuration, many
      application requests can be served over HTTP such as assets, requests
      that hit mounted engines, etc. In addition, because cookies are not
      upgraded to secure only in this configuration and HSTS headers are not
      set, it's possible for cookies that are meant to be secure to be sent
      over HTTP.
      
      The confusion between these two methods of forcing HTTPS is compounded
      by the fact that they share an identical name. This makes finding
      documentation on the "right" method confusing.
      
      HTTPS throughout is quickly becomming table stakes for all web sites.
      Sites are expected to operate over HTTPS for all communication,
      sensitive or otherwise. Let's encourage use of the broader-reaching
      `ActionDispatch::SSL` middleware and elminate this source of user
      confusion. If, for some reason, applications need to expose certain
      endpoints over HTTP they can do so by properly configuring
      `config.ssl_options`.
      4701a50b
  13. 15 12月, 2017 1 次提交
  14. 20 11月, 2017 1 次提交
  15. 24 9月, 2017 1 次提交
  16. 23 8月, 2017 1 次提交
  17. 19 8月, 2017 1 次提交
  18. 21 5月, 2017 1 次提交
  19. 15 2月, 2017 1 次提交
  20. 16 5月, 2016 2 次提交
  21. 14 5月, 2016 1 次提交
  22. 11 5月, 2016 1 次提交
  23. 01 5月, 2016 2 次提交
  24. 23 4月, 2016 1 次提交
  25. 22 4月, 2016 1 次提交
  26. 20 4月, 2016 1 次提交
  27. 25 2月, 2016 1 次提交
  28. 19 2月, 2016 2 次提交
  29. 07 2月, 2016 1 次提交
  30. 01 2月, 2016 1 次提交
  31. 29 1月, 2016 3 次提交
  32. 18 12月, 2015 1 次提交
  33. 09 12月, 2015 1 次提交
  34. 19 11月, 2015 1 次提交
  35. 04 10月, 2015 1 次提交
    • A
      Revert "removing Rack::Runtime from the default stack." · 24f9c03d
      Aaron Patterson 提交于
      This reverts commit 37423e4f.
      
      Jeremy is right that we shouldn't remove this.  The fact is that many
      engines are depending on this middleware to be in the default stack.
      This ties our hands and forces us to keep the middleware in the stack so
      that engines will work.  To be extremely clear, I think this is another
      smell of "the rack stack" that we have in place.  When manipulating
      middleware, we should have meaningful names for places in the req / res
      lifecycle **not** have engines depend on a particular constant be in a
      particular place in the stack.  This is a weakness of the API that we
      have to figure out a way to address before removing the constant.
      
      As far as timing attacks are concerned, we can reduce the granularity
      such that it isn't useful information for hackers, but is still useful
      for developers.
      24f9c03d