- 17 3月, 2017 9 次提交
-
-
由 Rafael França 提交于
Pass options to `driven_by`
-
由 Rafael França 提交于
Remove ability update locking_column value
-
由 George Claghorn 提交于
Use it to specify that an association should be initialized with a particular record before validation. For example: # Before belongs_to :account before_validation -> { self.account ||= Current.account } # After belongs_to :account, default: -> { Current.account }
-
由 eileencodes 提交于
Capybara was updated in teamcapybara/capybara#1841 to use Minitest style assertions so that system test output shows x number of assertions, x numbe of failures, etc. Before: ``` 6 runs, 0 assertions, 0 failures, 0 errors, 0 skips ``` After: ``` 6 runs, 7 assertions, 1 failures, 0 errors, 0 skips ``` This change bumps Capybara from 2.7.0 to 2.13.0 and includes the required minitest assertion file in the test case.
🎉 -
由 Vipul A M 提交于
-
由 Vipul A M 提交于
Fix guide incorrectly refers to public/assets/images [ci ckip]
-
由 Vipul A M 提交于
Updates incorrect documentation [ci skip]
-
由 Vipul A M 提交于
Add documentation to use with_options anywhere in the same class [ci
-
由 Dennis Zelada 提交于
-
- 16 3月, 2017 11 次提交
-
-
由 marvin 提交于
-
由 Dmitriy Budnik 提交于
Looking on code for this method it's clear that it's just returns `response.status` instead of full `response` object. It's better to correct docs as probably lots of specs are relying on this behavior.
-
由 Andrew White 提交于
-
由 Andrew White 提交于
We are overriding it in `Time` and `ActiveSupport::TimeWithZone` so there's no point in having it in the `DateAndTime::Compatibility` module. Also add some docs for the `to_time` implementations.
-
由 Andrew White 提交于
Allow Time#to_time on frozen objects. Return frozen time rather than "RuntimeError: can't modify frozen Time"
-
由 bogdanvlviv 提交于
-
由 Kasper Timm Hansen 提交于
Add secrets edit test
-
由 Jon Moss 提交于
PR was merged before I could finished reviewing
😬 [ci skip] -
由 Andrew White 提交于
In 9b654d47 some params munging was added to ensure that they were set whenever `recognize_path` would call either a proc or callable constraint. Since we no longer mutate the environment hash within the method it's now unnecessary and actually causes params to leak between route matches before checking constraints. Fixes #28398.
-
由 David Heinemeier Hansson 提交于
-
由 Rafael França 提交于
Fix fragile test (`AssociationProxyTest#test_save_on_parent_saves_children`)
-
- 15 3月, 2017 15 次提交
-
-
由 Andrew White 提交于
Remove implicit coercion deprecation of durations
-
由 Rafael França 提交于
Add documentation about signature_key for MessageEncryptor.new [ci skip]
-
由 Fumiaki MATSUSHIMA 提交于
If we run only following tests: - test/cases/scoping/default_scoping_test.rb - test/cases/associations_test.rb ``` $ cat Rakefile.test require "rake/testtask" ENV["ARCONN"] = "postgresql" Rake::TestTask.new do |t| t.libs << "test" t.test_files = %w( test/cases/scoping/default_scoping_test.rb test/cases/associations_test.rb ) end ``` a test will fail: ``` $ bundle exec rake test -f Rakefile.test /app/activesupport/lib/active_support/core_ext/enumerable.rb:20: warning: method redefined; discarding old sum Using postgresql Run options: --seed 11830 # Running: .........................................................................................F................ Finished in 6.939055s, 15.2759 runs/s, 27.9577 assertions/s. 1) Failure: AssociationProxyTest#test_save_on_parent_saves_children [/app/activerecord/test/cases/associations_test.rb:185]: Expected: 1 Actual: 2 106 runs, 194 assertions, 1 failures, 0 errors, 0 skips rake aborted! Command failed with status (1) /usr/local/bin/bundle:22:in `load' /usr/local/bin/bundle:22:in `<main>' Tasks: TOP => test (See full trace by running task with --trace) ``` In #28083, change `self.use_transactional_tests` to `false` but we forget to clean-up fixture. However we don't have to disable transaction except a few tests.
-
由 Andrew White 提交于
-
由 Andrew White 提交于
-
由 Andrew White 提交于
In #28204 we deprecated implicit conversion of durations to a numeric which represented the number of seconds in the duration because of unwanted side effects with calculations on durations and dates. This unfortunately had the side effect of forcing a explicit cast when configuring third-party libraries like expiration in Redis, e.g: redis.expire("foo", 5.minutes) To work around this we've removed the deprecation and added a private class that wraps the numeric and can perform calculation involving durations and ensure that they remain a duration irrespective of the order of operations.
-
由 Richard Schneeman 提交于
Remove unused `@txn` variable
-
由 Eileen M. Uchitelle 提交于
Make destroy command work within engines
-
由 Kasper Timm Hansen 提交于
Rename test of `app:update` to more appropriate name
-
由 Eugene Kenny 提交于
This was added in c24c8852, removed in b89ffe7f, and then (unintentionally?) reintroduced in 2d7ae1b0.
-
由 yuuji.yaginuma 提交于
`rails:update` was changed to `app:update` in 6fb31638. Therefore, I think that it is better that the test name is also `app_update`.
-
由 Andrew White 提交于
Adding durations to `Time` instances is perfectly okay.
-
由 Benoit Tigeot 提交于
-
由 Claudio B 提交于
Add CHANGELOG entry for --skip-coffee [ci skip]
-
由 claudiob 提交于
Was added in #25248 by @bluesh55
-
- 14 3月, 2017 5 次提交
-
-
由 Ryuta Kamizono 提交于
Remove obsolete warning about regular expression
-
由 Philipe Fatio 提交于
This warning became obsolete when the regular expression was changed to use `\z` instead of `\Z` in fce9c4e5. "-1234\n" =~ /\A[+-]?\d+\Z/ => 0 "-1234\n" =~ /\A[+-]?\d+\z/ => nil [ci skip]
-
由 Matthew Draper 提交于
This reverts commit 192db644, reversing changes made to 98939553. We can't sacrifice correctness for performance.
-
由 yuuji.yaginuma 提交于
Instead of calling methods of Rails.application directly, we need to use a method that is considered for the rails engine.
-
由 Richard Schneeman 提交于
Add CHANGELOG for #26226 [ci skip]
-