- 26 8月, 2015 2 次提交
-
-
由 Aaron Patterson 提交于
collect the body and make assert against the collected body
-
由 amitkumarsuroliya 提交于
-
- 25 8月, 2015 3 次提交
-
-
由 Marcin Olichwirowicz 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
We should keep the route set generation logic in one place
-
- 24 8月, 2015 3 次提交
-
-
由 Marcin Olichwirowicz 提交于
-
由 akihiro17 提交于
-
由 Aditya Kapoor 提交于
-
- 18 8月, 2015 2 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 12 8月, 2015 1 次提交
-
-
由 Dennis Suratna 提交于
-
- 08 8月, 2015 3 次提交
-
-
由 eileencodes 提交于
The tests and methods were hard to read with `options[:options]` all over the place. This refactoring makes the code easier to understand. The change came out of work for moving the underlying code of controller tests to integraiton tests.
-
由 Aaron Patterson 提交于
Looks like this was left over from converting Rails to Rack. I think it's safe to remove now.
-
由 Aaron Patterson 提交于
since we only work with instances of classes, it greatly simplifies the `Middleware` implementation.
-
- 07 8月, 2015 1 次提交
-
-
由 Michael Grosser 提交于
- webservers do not do it - it makes redirect urls ugly when request.host is used for redirection
-
- 03 8月, 2015 2 次提交
-
-
由 Aditya Kapoor 提交于
-
由 amitkumarsuroliya 提交于
-
- 02 8月, 2015 1 次提交
-
-
由 Aditya Kapoor 提交于
-
- 20 7月, 2015 1 次提交
-
-
由 Roque Pinel 提交于
This clears the transaction record state when the transaction finishes with a `:committed` status. Considering the following example where `name` is a required attribute. Before we had `new_record?` returning `true` for a persisted record: ```ruby author = Author.create! name: 'foo' author.name = nil author.save # => false author.new_record? # => true ```
-
- 19 7月, 2015 1 次提交
-
-
由 Roque Pinel 提交于
When executing an `ActionController::Parameters#fetch` with a block that raises a `KeyError` the raised `KeyError` will be rescued and converted to an `ActionController::ParameterMissing` exception, covering up the original exception. [Jonas Schubert Erlandsson & Roque Pinel]
-
- 18 7月, 2015 2 次提交
-
-
由 Prem Sichanugrist 提交于
This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`.
-
由 Prem Sichanugrist 提交于
We've started on discouraging the usage of `render :text` in #12374. This is a follow-up commit to make sure that we print out the deprecation warning.
-
- 17 7月, 2015 1 次提交
-
-
由 Robin Dupret 提交于
-
- 15 7月, 2015 1 次提交
-
-
由 Prem Sichanugrist 提交于
This is another take at #14384 as we decided to wait until `master` is targeting Rails 5.0. This commit is implementation-complete, as it guarantees that all the public methods on the hash-inherited Parameters are still working (based on test case). We can decide to follow-up later if we want to remove some methods out from Parameters.
-
- 14 7月, 2015 4 次提交
-
-
由 Aaron Patterson 提交于
We want to treat the response object as if it's a real response object (not a test object), so we should only call methods that are on the superclass.
-
由 Prem Sichanugrist 提交于
ActionController::TestResponse was removed in d9fe10cb and caused a test failure on Action View as its test case still refers to it.
-
由 Aaron Patterson 提交于
-
由 Jerry D'Antonio 提交于
The concurrent-ruby gem is a toolset containing many concurrency utilities. Many of these utilities include runtime-specific optimizations when possible. Rather than clutter the Rails codebase with concurrency utilities separate from the core task, such tools can be superseded by similar tools in the more specialized gem. This commit replaces `ActiveSupport::Concurrency::Latch` with `Concurrent::CountDownLatch`, which is functionally equivalent.
-
- 10 7月, 2015 2 次提交
-
-
由 Aaron Patterson 提交于
We should use rack-test's upload file objects on the test side so that we will be able to correctly generate mime blob posts in the future
-
由 Aaron Patterson 提交于
We should convert request parameters to a query string, then let the request object parse that query string. This should give us results that are more similar to the real-world
-
- 09 7月, 2015 6 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
We should assign parameters to the request object rather than mutate the hash that is returned by `query_parameters` or `request_parameters`
-
由 Aaron Patterson 提交于
Instead of trying to manually clear out a request object, lets just allocate a new one. The rack ENV is reused and cleaned (still), but the request object is not.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
We should leverage the request / response objects that the superclass has already allocated for us.
-
- 08 7月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
Variants are typically set in the controller based on some attribute of the request that the browser sent. We should make our tests more in line with reality by doing the same and not mutating the request object.
-
- 05 7月, 2015 1 次提交
-
-
由 Kasper Timm Hansen 提交于
-
- 21 6月, 2015 1 次提交
-
-
由 Dave Copeland 提交于
In 0de4a23d the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`.
-
- 16 6月, 2015 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
-