- 29 8月, 2011 1 次提交
-
-
由 Jon Leighton 提交于
The join_nodes must be passed to the JoinDependency initializer and therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556.
-
- 15 8月, 2011 1 次提交
-
-
由 Jon Leighton 提交于
-
- 13 8月, 2011 1 次提交
-
-
由 Jon Leighton 提交于
We were experiencing CI test failures, for example: * 3-1-stable: http://travis-ci.org/#!/rails/rails/builds/79473/L407 * master: http://travis-ci.org/#!/rails/rails/builds/79507/L80 These failures only happened on 1.8.7-p352, and we were only able to reproduce on the Travis CI VM worker. We even tried creating a new 32 bit Ubuntu VM and running the tests on that, and it all worked fine. After some epic trial and error, we discovered that replacing the following: fuu = Marshal.load(Marshal.dump(fuu)) with: marshalled = Marshal.dump(fuu) fuu = Marshal.load(marshalled) seemed to prevent the failure. We have NO IDEA why this is. If anyone has some great insight to contribute then that is welcome. Otherwise, hopefully this will just help us get the CI green again. Many thanks to @joshk for help with sorting this out.
-
- 06 8月, 2011 1 次提交
-
-
由 Santiago Pastorino 提交于
-
- 19 7月, 2011 1 次提交
-
-
由 Elliot Winkler 提交于
-
- 12 7月, 2011 1 次提交
-
-
由 Jon Leighton 提交于
-
- 09 7月, 2011 2 次提交
-
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
Ensure that the foreign key gets set when doing record.create_association or record.create_association. Fixes #1960.
-
- 07 7月, 2011 1 次提交
-
-
由 Anatoliy Lysenko 提交于
when condtions references tables from includes. Test fail because of invalid sql: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id: SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id" WHERE "readers"."person_id" = 1 AND (comments.id is null) Bug described in github#925 This commit will revert fix from https://github.com/rails/rails/commit/3436fdfc12d58925e3d981e0afa61084ea34736c , but tests is ok. Bug described in #6569 ticket.
-
- 05 7月, 2011 2 次提交
-
-
由 Bogdan Gusiev 提交于
In order to make CollectionAssociation behave closer to Array Add the ability to pass block to #find method just like Array#find does.
-
由 Dieter Komendera 提交于
-
- 01 7月, 2011 1 次提交
-
-
由 Jon Leighton 提交于
Assign the association attributes to the associated record before the before_initialize callback of the record runs. Fixes #1842.
-
- 13 6月, 2011 3 次提交
-
-
由 Jon Leighton 提交于
Make assert_no_queries literally enforce that there are no queries. As in, not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries.
-
由 Jon Leighton 提交于
-
由 benedikt 提交于
Don't wrap operations on collection associations in transactions when they are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database.
-
- 08 6月, 2011 3 次提交
-
-
由 Raimonds Simanovskis 提交于
As a result test was failing on Oracle where ids are assigned by default from 1000
-
由 Jon Leighton 提交于
Allow polymorphic has_one to work when the association is set before the owner has been saved. Fixes #1524.
-
由 Jon Leighton 提交于
When you add a record to a polymorphic has_one, you should be able to access the owner from the associated record
-
- 07 6月, 2011 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 05 6月, 2011 1 次提交
-
-
由 Jon Leighton 提交于
Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
-
- 04 6月, 2011 1 次提交
-
-
由 ganesh 提交于
-
- 01 6月, 2011 2 次提交
-
-
由 Josh Kalderimis 提交于
added an alias for new to build to the AR collection proxy, this corrects an issue where the collection proxies were not consistent
-
由 Farley Knight 提交于
-
- 31 5月, 2011 1 次提交
-
-
由 Arun Agrawal 提交于
-
- 28 5月, 2011 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 27 5月, 2011 2 次提交
-
-
由 Aaron Patterson 提交于
-
由 Mohammad Typaldos 提交于
-
- 26 5月, 2011 3 次提交
-
-
由 Marian Rudzynski 提交于
-
由 Marian Rudzynski 提交于
-
由 Mohammad El-Abid 提交于
-
- 25 5月, 2011 6 次提交
-
-
由 Josh Kalderimis 提交于
-
由 Andrew White 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Joey Butler 提交于
-
- 24 5月, 2011 1 次提交
-
-
由 Andrew White 提交于
-
- 23 5月, 2011 1 次提交
-
-
由 Jon Leighton 提交于
Fix problem with loading polymorphic associations which have been defined in an abstract superclass. Fixes #552.
-
- 21 5月, 2011 1 次提交
-
-
由 thedarkone 提交于
-
- 20 5月, 2011 1 次提交
-
-
由 Guillermo Iguaran 提交于
-