- 18 12月, 2019 38 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Rafael Mendonça França 提交于
[Railties] Add config rake_eager_load
-
由 Rafael França 提交于
Update instructions in generated Postgresql database.yml.
-
由 Rafael Mendonça França 提交于
Delegate child session assertions to parent session
-
由 Petrik 提交于
Some code examples were missing the language used for code highlighting.
-
由 Petrik 提交于
-
由 Chris Seelus 提交于
-
由 Rafael França 提交于
Add backend API doc for action text [ci skip]
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Remove call to object_id
-
由 Rafael França 提交于
minor grammar fix
-
由 Rafael Mendonça França 提交于
Update documentation to explain the behavior of explicitly raising ActiveRecord::Rollback in a nested transaction [skip ci]
-
由 Rafael França 提交于
Add some examples for getting current_user
-
由 Rafael França 提交于
Remove `spring-watcher-listen` from default Gemfile
-
由 Rafael França 提交于
Reversible remove_columns
-
由 Rafael Mendonça França 提交于
Update The Rails Initialization Process page[ci skip]
-
由 Rafael França 提交于
Fix FrozenError on ActiveModel::Error clear and delete
-
由 Rafael Mendonça França 提交于
Update downloading section
-
由 Rafael França 提交于
Respect Content-Type header passed in head method
-
由 Eileen M. Uchitelle 提交于
Move `name` key on configuration hash into `DatabaseConfig`
-
由 Rafael França 提交于
Update .yardopts to document *.rb files in [GEM]/app
-
由 John Crepezzi 提交于
`name` is used by Rails to find the configuration by connection specification name, but database adapters don't need to use `name` in order to establish a connection. This is part of our work to separate what the database needs to connect (the configuration hash) and the what Rails needs to find connections (everything else). Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Rafael França 提交于
Also close PRs with no activity over 3 months
-
由 Rafael França 提交于
Make `belongs_to_required_by_default` a class attribute:
-
由 Cliff Pruitt 提交于
* Add failing ActiveJob exceptions test for "disable retry jitter" Thanks to @kaspth for the starting point. * Update ActiveJob retry jitter to correctly use zero value * Simplify "disable retry jitter" test We don't need to repeat this many times. Fewer is shorter. * Refactor determine_delay with jitter * Fix indentation * Close the curtains and give JITTER_DEFAULT some privacy * Use .zero? instead of == to check jitter value * Add ActiveJob test for explicit zero jitter Co-authored-by: NKasper Timm Hansen <hey@kaspth.com> Co-authored-by: NCliff Pruitt <cliff.pruitt@cliffpruitt.com>
-
由 Edouard CHIN 提交于
- I'm hoping to get this change accepted even though this flag was introduced years ago in 6576f735 My use case is the following: We were never enforcing belongs to association and we have a lot of models that implicitely declare an association as optional. We are now changing all our models to make associations required by default. Since we have a lot of models (more than 1000), I'd like to progressively enable them to use the `belongs_to_required_by_default` flag. The problem is that this flag is a mattr_accessor and doesn't to be set per model. We basically need to modify all our models (which could take years) before being able to modify the global flag. I'd like to change this flag to a class_attribute to solve the issue.
-
由 Eileen M. Uchitelle 提交于
Deprecate `connection_config`
-
由 Rafael França 提交于
Rename a test method to not conflict with a deprecated method
-
由 John Crepezzi 提交于
This method in test has a confusing name that also is the same as a method with a different behavior on `ActiveRecord::Base` so we're just renaming it to avoid confusion between the two! Co-authored-by: Neileencodes <eileencodes@gmail.com>
-
由 Eileen M. Uchitelle 提交于
Add a host method to HashConfig
-
由 Eileen M. Uchitelle 提交于
Removes the un-used function call for syntaxhighlighterConfig
-
由 John Crepezzi 提交于
The `connection_config` method returns a `Hash`, but since we're moving toward a place where we're using `DatabaseConfiguration::DatabaseConfig` objects everywhere, we're introducing a new method here to replace it called `connection_db_config`. Co-authored-by: Neileencodes <eileencodes@gmail.com>
-
由 John Crepezzi 提交于
This is the last property that's used directly inside of Rails (in `DatabaseTasks`) that doesn't have an accessor in `HashConfig`. Adding this so that we can have a uniform interface for accessing properties that Rails needs (that descend from `DatabaseConfigurations::DatabaseConfig`) Co-authored-by: Neileencodes <eileencodes@gmail.com>
-
由 Rafael França 提交于
Revert revert ec sqlite3 connection transaction
-
由 Rafael França 提交于
Ensure migration generator respects primary key config in references
-
由 Rafael Mendonça França 提交于
-
由 Louis-Michel Couture 提交于
When rails is configured to use a specific primary key type: ``` config.generators do |g| g.orm :active_record, primary_key_type: :uuid end ``` Previously: $ bin/rails g migration add_location_to_users location:references The references line in the migration would not have `type: :uuid`. This change causes the type to be applied appropriately. Co-authored-by: NDermot Haughey <hderms@gmail.com>
-
由 Edouard CHIN 提交于
- #37798 had to be reverted because a new flakyness appeared ([see CI build](https://buildkite.com/rails/rails/builds/65467#efaa1dd5-aaf4-43a1-a204-d1c42abf614d)) This failure isn't related to the change itself. If you apply this diff, the test will some time to time fail. Even without my changes. ```diff diff --git a/activerecord/test/cases/transactions_test.rb b/activerecord/test/cases/transactions_test.rb index b5c1cac3d9..09fe0ddd7f 100644 --- a/activerecord/test/cases/transactions_test.rb +++ b/activerecord/test/cases/transactions_test.rb @@ -1127,7 +1127,6 @@ def test_no_automatic_savepoint_for_inner_transaction end end if Topic.connection.supports_savepoints? -if ActiveRecord::Base.connection.supports_transaction_isolation? class ConcurrentTransactionTest < TransactionTest # This will cause transactions to overlap and fail unless they are performed on # separate database connections. @@ -1198,4 +1197,3 @@ def test_transaction_isolation__read_committed assert_equal original_salary, Developer.find(1).salary end end -end ``` SQlite3 isn't safe to run in a multi threaded environment unless sqlite is compiled with a special flag which isn't our case. Ref https://www.sqlite.org/threadsafe.html
-
- 17 12月, 2019 2 次提交
-
-
由 Rafael França 提交于
number_to_currency negative zero fix
-
由 Rafael França 提交于
document the default for dependent activerecord option
-