- 14 9月, 2018 15 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 yuuji.yaginuma 提交于
Currently, PostgreSQL + Ruby 2.5.1 build has failed. https://travis-ci.org/rails/rails/jobs/427502723#L2940-L2942 https://travis-ci.org/rails/rails/jobs/427496382#L2921-L2923 https://travis-ci.org/rails/rails/jobs/427470858#L2921-L2923 This is because PostgreSQL server abnormally terminates when ramfs becomes full. Ref: https://travis-ci.org/rails/rails/jobs/427960998#L7614 This occurs since d54d0c95. In d54d0c95, `sudo` is used in preprocessing for setting MySQL. In Travis, even if specified `sudo: false`, when using `sudo` in build, sudo-enabled infrastructure is used. https://docs.travis-ci.com/user/reference/overview/#virtualisation-environment-vs-operating-system As container-based infrastructure was changed to sudo-enabled infrastructure, the disk settings etc were also changed, it seems that this phenomenon occurred. This can also be handled by extending ramfs(https://github.com/travis-ci/travis-ci/issues/9036#issuecomment-357189213). However, using sudo-enabled in all builds affects the execution time of build, so I think that it is good to use sudo-enabled only in the necessary builds.
-
由 Rafael França 提交于
SQLite3 adapter supports expression indexes
-
由 Ryuta Kamizono 提交于
Bump MySQL version requirement to 5.5.8 in the template files [ci skip]
-
由 Xavier Noria 提交于
Improve API document on Object#blank?
-
由 Yasuo Honda 提交于
Follow-up #33853
-
由 Rafael França 提交于
Conditionally use `helper_method` in Flash concern
-
由 gkemmey 提交于
-
由 Eileen M. Uchitelle 提交于
add `any?` to DatabaseConfigurations
-
由 Rafael Mendonça França 提交于
Allow subclasses to redefine autosave callbacks for associated records
-
由 Greg Molnar 提交于
-
由 Takumasa Ochi 提交于
-
由 Jeremy Daer 提交于
Validate if `utf8mb4` character set and longer index key prefix is supported
-
由 Rafael França 提交于
Update arguments.rb [ci skip]
-
由 Sharang Dashputre 提交于
Fix typo `Instrinsic` -> `Intrinsic`
-
- 13 9月, 2018 14 次提交
-
-
由 Ryuta Kamizono 提交于
Add changelog entries for #33849 [ci skip]
-
由 bogdanvlviv 提交于
Since these changes related to the public API, I think we should add changelog entries. Related to #33838, #33849
-
由 Ryuta Kamizono 提交于
Eager loading/preloading should be worked regardless of large number of records
-
由 Yasuo Honda 提交于
* MySQL 5.1 does not support `utf8mb4` character set * MySQL 5.1 had been already EOLed on Dec 2013 https://www.mysql.com/support/eol-notice.html > Per Oracle's Lifetime Support policy, as of December 31, 2013, MySQL 5.1 > is covered under Oracle Sustaining Support. * MySQL 5.5.8 is the first General Availability of MySQL 5.5 https://dev.mysql.com/doc/relnotes/mysql/5.5/en/news-5-5-8.html
-
由 Yasuo Honda 提交于
-
由 Yasuo Honda 提交于
Once #33608 merged If users create a new database using MySQL 5.1.x, it will fail to create databases since MySQL 5.1 does not know `utf8mb4` character set. This pull request removes `encoding: utf8mb4` from `mysql.yml.tt` to let create_database method handles default character set by MySQL server version. `supports_longer_index_key_prefix?` method will need to validate if MySQL 5.5 and 5.6 server configured correctly to support longer index key prefix, but not yet.
-
由 Rafael França 提交于
Use faster globs for template resolving
-
由 John Hawthorn 提交于
-
由 Rafael Mendonça França 提交于
In production the query cache was already being loaded before the first request even without #33856, so added a test to make sure of it. This new test is passing even if #33856 is reverted.
-
由 John Hawthorn 提交于
-
由 Rafael França 提交于
Include test helpers in ActionDispatch::IntegrationTest
-
由 Ricardo Díaz 提交于
As @dhh brings up, the point of `ActionDispatch::IntegrationTest` is to allow users to test the integration of all the pieces called by a controller. Asserting about the emails and jobs queued is part of that task. This commit includes the `ActionMailer::TestHelper` and `ActiveJob::TestHelper` modules when the ActionMailer and ActiveJob railties are initialized respectively.
-
由 Rafael França 提交于
Faster multiple_of? method
-
由 Rafael França 提交于
Follow up #33756
-
- 12 9月, 2018 11 次提交
-
-
由 bogdanvlviv 提交于
Also remove `# :nodoc:` for `ActiveRecord::Core::ClassMethods` in order to show non-nodoc methods in that module on the api docs http://edgeapi.rubyonrails.org
-
由 bogdanvlviv 提交于
It would allow `filter_attributes` to be reused across multiple calls to `#inspect` or `#pretty_print`. - Add `require "set"` - Remove `filter_attributes` instance reader. I think there is no need to keep it.
-
由 bogdanvlviv 提交于
- Move ``` filter_attributes = self.filter_attributes.map(&:to_s).to_set filter_attributes.include?(attribute_name) && !read_attribute(attribute_name).nil? ``` to private method. - Fix tests in `activerecord/test/cases/filter_attributes_test.rb` - Ensure that `teardown` sets `ActiveRecord::Base.filter_attributes` to previous state. - Ensure that `Admin::Account.filter_attributes` is set to previous state in the "filter_attributes could be overwritten by models" test. Follow up #33756
-
由 bogdanvlviv 提交于
Add mention that `config.filter_parameters` also filters out sensitive values of database columns when call `#inspect` since #33756.
-
由 Eileen M. Uchitelle 提交于
Fix query cache to load before first request
-
由 Eileen Uchitelle 提交于
In a test app we observed that the query cache was not enabled on the first request. This was because the query cache hooks are installed on load and active record is loaded in the middle of the first request. If we remove the `on_load` from the railtie the query cache hooks will be installed before the first request, allowing the cache to be enabled on that first request. This is ok because query cache doesn't load anything else, only itself so we're not eager loading all of active record before the first request, just the query cache hooks. [Eileen M. Uchitelle & Matthew Draper]
-
由 Yuji Yaginuma 提交于
Update test_helper_test.rb
-
由 Sharang Dashputre 提交于
Fix typo `wiht` -> `with`
-
由 rigani 提交于
-
由 Rafael França 提交于
Update action_mailer_basics.md
-
由 Sharang Dashputre 提交于
Add backticks to code
-