- 05 8月, 2017 10 次提交
-
-
由 yuuji.yaginuma 提交于
changed `rails/activestorage` to `rails/rails`.
-
由 David Heinemeier Hansson 提交于
Add Active Storage to Rails
-
由 Dino Maric 提交于
-
由 Claudio B 提交于
If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical URL for an object will start with "https://s3.amazonaws.com/bucket.name/" and not with "https://bucket.name.s3.amazonaws.com/". The URL tests have now been separated into two separate asserts, to ensure that both the "s3.amazonaws.com" and the "bucket.name" components are included, but not specifically in that order.
-
由 Claudio B 提交于
Before we forget...
-
由 Sean Griffin 提交于
Do not let use `serialize` on native JSON/array column
-
由 Rafael Mendonça França 提交于
The test was passing before because it was not being testes correctly. Now we create a different engine that is loaded before the already exising and we make sure that the first call for isolate_namespace is what takes effect.
-
由 Rafael Mendonça França 提交于
What we want to test is that two different calls to isolate_namespace with the same module doesn't change the original railtie. We can do that defining two different railties. We can't call in the application because this method is not supposed to be called in an Application class.
-
由 Rafael França 提交于
Use `assert_nil` if `value` is nil in `assert_field_default_value`
-
由 David Heinemeier Hansson 提交于
And deal with a temporary test fix until we allow you to skip active storage.
-
- 04 8月, 2017 30 次提交
-
-
由 David Heinemeier Hansson 提交于
-
由 Sean Griffin 提交于
Use `Concurrent::Map` than `Mutex` and `Mutex_m` for statement caches
-
由 Kir Shatrov 提交于
-
由 Eileen M. Uchitelle 提交于
Remove extra empty line
-
由 David Heinemeier Hansson 提交于
-
由 Ryuta Kamizono 提交于
Statement caches are used as a concurrent map. It will more clarify to using `Concurrent::Map`.
-
由 Sean Griffin 提交于
Deprecate `LoadError::REGEXPS` constant
-
由 yuuji.yaginuma 提交于
since 4ad1a52f, `LoadError::REGEXPS` is no longer needed.
-
由 Rafael Mendonça França 提交于
We are already removing the braces around hash parameters in the last argument in other places so we should not change the entire codebase because of two places.
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Change azure core dependency
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Make Rubocop happy about ActiveStorage
-
由 Richard Schneeman 提交于
Improve bundler binstub error message
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented.
-
由 Nathan Wenneker 提交于
-
由 Rafael Mendonça França 提交于
FormHelper includes FormTagHelper so we don't need to define two methods
-
由 Rafael Mendonça França 提交于
Also make sure file_field doesn't mutate the original options passed in.
-
由 Rafael Mendonça França 提交于
When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception.
-
由 David Heinemeier Hansson 提交于
cc @rafaelfranca
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
由 Rafael Mendonça França 提交于
I know those methods are unlikely to change but having one line method is hard to read and also hard to modify.
-
由 claudiob 提交于
Running `rubocop activestorage` before this commit resulted in 20 offenses. This commit only fixes: - Trailing whitespace detected - Space inside } missing - Put one space between the method name and the first argument. The other offenses are left since they are intentional according to @georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190)
-
由 Sean Griffin 提交于
Passing `klass` to `StatementCache.new`
-
由 Ryuta Kamizono 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
Actually `StatementCache#execute` is always passed the same klass that the owner klass of the connection when the statement cache is created. So passing `klass` to `StatementCache.new` will make more DRY.
-