- 01 12月, 2014 3 次提交
-
-
由 Sean Griffin 提交于
The detection of in-place changes caused a weird unexpected issue with numericality validations. That validator (out of necessity) works on the `_before_type_cast` version of the attribute, since on an `:integer` type column, a non-numeric string would type cast to 0. However, strings are mutable, and we changed strings to ensure that the post type cast version of the attribute was a different instance than the before type cast version (so the mutation detection can work properly). Even though strings are the only mutable type for which a numericality validation makes sense, special casing strings would feel like a strange change to make here. Instead, we can make the assumption that for all mutable types, we should work on the post-type-cast version of the attribute, since all cases which would return 0 for non-numeric strings are immutable. Fixes #17852
-
由 Rafael Mendonça França 提交于
FIX: absolute_path may be nil for code added via instance_eval
-
由 Sam 提交于
-
- 30 11月, 2014 13 次提交
-
-
由 Hendy Tanata 提交于
[ci skip]
-
由 Prathamesh Sonpatki 提交于
- In guides, "API" is used consistently instead of "api". - Reason behind replacing "fixtures API" to "Fixtures API" is because here we are referring to the concept of "fixtures". In other places in the guide "fixture" OR "fixtures" is referred to the single or multiple instances of test data. - This is also followup of https://github.com/rails/docrails/commit/aa9d1332b20305dd860b21a7ada06c5252bebad5#commitcomment-8497376.
-
由 Prathamesh Sonpatki 提交于
-
由 Richard Schneeman 提交于
[ci skip] fix description of url_for
-
由 yuuji.yaginuma 提交于
-
由 Sean Griffin 提交于
`where_sql` now requires that we pass it an engine. None of the manager classes take an engine in their constructor.
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
We never actually make use of it on the table, since we're constructing the select manager manually. It looks like if we ever actually were grabbing it from the table, we're grossly misusing it since it's meant to vary by AR class. Its existence on `Arel::Table` appears to be purely for convenience methods that are never used outside of tests. However, in production code it just complicates construction of the tables on the rails side, and the plan is to remove it from `Arel::Table` entirely. I'm not convinced it needs to live on `SelectManager`, etc either.
-
由 Sean Griffin 提交于
Pure rack apps can be mounted with a name
-
由 Sean Griffin 提交于
Fix link in documentation. [ci skip]
-
由 Igor Zubkov 提交于
-
由 Matthew Draper 提交于
Bump ruby version to 2.1.0 in rails.gemspec too.
-
由 Igor Zubkov 提交于
-
- 29 11月, 2014 20 次提交
-
-
由 Rafael Mendonça França 提交于
Pass symbol as an argument instead of a block
-
由 Erik Michaels-Ober 提交于
-
由 Xavier Noria 提交于
-
由 Rafael Mendonça França 提交于
Prevent Numeric#to_s from allocating an array
-
由 Rafael Mendonça França 提交于
Bump required Ruby version to 2.1.0
-
由 claudiob 提交于
[This article](http://weblog.rubyonrails.org/2014/8/20/Rails-4-2-beta1/#maintenance-consequences-and-rails-5-0) states that: > Rails 5.0 is in most likelihood going to target Ruby 2.2. Before the exact minimum version is fully decided, @arthurnn [suggests](https://github.com/rails/rails/pull/17830#issuecomment-64940383) that **at least** version 2.1.0 **must** be required by the `gemspec` files.
-
由 Arthur Nogueira Neves 提交于
Remove a reference to Ruby 1.9 in Guides
-
由 claudiob 提交于
[ci skip] Now that Rails requires Ruby >= 2.0 there is no need to document Ruby 1.9.
-
由 Zachary Scott 提交于
[ci skip] fix class name
-
由 yui-knk 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Jean Boussier 提交于
-
由 Rafael Mendonça França 提交于
fixed indent of end in jdom.rb
-
由 bigtone1284 提交于
-
由 Rafael Mendonça França 提交于
Refactor `add_column_options!`, to move the quoting of default value for :uuid in `quote_value`.
-
由 Rafael Mendonça França 提交于
delayed_job_active_record doesn't allow Rails 5 yet
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9.
- 28 11月, 2014 4 次提交
-
-
由 Abdelkader Boudih 提交于
4.2 release notes pass [skip ci]
-
由 Santiago Pastorino 提交于
Adds preloaded_records method to NullPreloader - fixes #16070
-
由 Jon Atack 提交于
-
由 Thorsten Ball 提交于
This fixes a regression where preloading association throws an exception if one of the associations in the preloading hash doesn't exist for one record. Fixes #16070
-