1. 01 12月, 2014 3 次提交
    • S
      Ensure numericality validations work with mutation · 704c6585
      Sean Griffin 提交于
      The detection of in-place changes caused a weird unexpected issue with
      numericality validations. That validator (out of necessity) works on the
      `_before_type_cast` version of the attribute, since on an `:integer`
      type column, a non-numeric string would type cast to 0.
      
      However, strings are mutable, and we changed strings to ensure that the
      post type cast version of the attribute was a different instance than
      the before type cast version (so the mutation detection can work
      properly).
      
      Even though strings are the only mutable type for which a numericality
      validation makes sense, special casing strings would feel like a strange
      change to make here. Instead, we can make the assumption that for all
      mutable types, we should work on the post-type-cast version of the
      attribute, since all cases which would return 0 for non-numeric strings
      are immutable.
      
      Fixes #17852
      704c6585
    • R
      Merge pull request #17860 from SamSaffron/fix_engine_backtrace · 8226bad7
      Rafael Mendonça França 提交于
      FIX: absolute_path may be nil for code added via instance_eval
      8226bad7
    • S
      FIX: absolute_path may be nil for code added via instance_eval · 6edc26f4
      Sam 提交于
      6edc26f4
  2. 30 11月, 2014 13 次提交
  3. 29 11月, 2014 20 次提交
  4. 28 11月, 2014 4 次提交