- 24 10月, 2015 1 次提交
-
-
由 Markov Alexey 提交于
-
- 23 10月, 2015 13 次提交
-
-
由 Kasper Timm Hansen 提交于
FIX: Randomly failing test when running without GIL.
-
由 Guo Xiang Tan 提交于
-
由 Sean Griffin 提交于
Remove no need `binds.empty?` checking
-
由 Richard Schneeman 提交于
remove unnecessary readme in dummy application
-
由 yuuji.yaginuma 提交于
`README` it is changed to `README.rdoc` in 6b126e23, it has been changed to` README.md` further 89a12c93.
-
由 Yves Senn 提交于
[ci skip] Add more code examples for `Module#anonymous?` docs
-
由 Ryuta Kamizono 提交于
`#exec_stmt` is private method and only called in `#exec_query`. it means `binds` is provided always. No need `binds.empty?` checking.
-
由 yui-knk 提交于
In later code examples, it is better to write how `Module#anonymous?` works.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
Reason: That one is an Oxford comma, as per our guidelines. See: http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#comma This reverts commit f184cd34.
-
由 Rafael Mendonça França 提交于
[ci skip] removed extra comma
-
由 hemali jain 提交于
-
由 Rafael Mendonça França 提交于
[ci skip]
-
- 22 10月, 2015 15 次提交
-
-
由 Rafael Mendonça França 提交于
Use sufficient a regexp anchor to check `@response.content_type.to_s`
-
由 Sean Griffin 提交于
Refactored association preloader for performance
-
由 Bogdan Gusiev 提交于
* less arrays created * less complexity with only one level of nesting in loop
-
由 Sean Griffin 提交于
Change Integer#year to return a Fixnum instead of a Float to improve consistency
-
由 Kasper Timm Hansen 提交于
Suppress warnings (warnings about AD::IntegrationTest HTTP request)
-
由 Konstantinos Rousis 提交于
-
由 Andrew White 提交于
Fix generated projection fields in group by query
-
由 Rafael Sales 提交于
* When tried to use `Company#accounts` test/models/company.rb I got: ``` ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: accounts.company_id: SELECT COUNT(*) AS count_all, "companies"."firm_id" AS companies_firm_id FROM "companies" INNER JOIN "accounts" ON "accounts"."company_id" = "companies"."id" GROUP BY "companies"."firm_id" ``` * The refactor on Calculations class was just to simplify the code
-
由 Rafael Sales 提交于
Closes #21922 Let `Book(id, author_id)`, `Photo(id, book_id, author_id)` and `Author(id)` Running `Book.group(:author_id).joins(:photos).count` will produce: * Rails 4.2 - conflicts `author_id` in both projection and group by: ```sql SELECT COUNT(*) AS count_all, author_id AS author_id FROM "books" INNER JOIN "photos" ON "photos"."book_id" = "books"."id" GROUP BY author_id ``` * Master (9d02a25d) - conflicts `author_id` only in projection: ```sql SELECT COUNT(*) AS count_all, author_id AS author_id FROM "books" INNER JOIN "photos" ON "photos"."book_id" = "books"."id" GROUP BY "books"."author_id" ``` * With this fix: ```sql SELECT COUNT(*) AS count_all, "books"."author_id" AS books_author_id FROM "books" INNER JOIN "photos" ON "photos"."book_id" = "books"."id" GROUP BY "books"."author_id" ```
-
由 Andrew White 提交于
Remove `#tables` extra args again
-
由 Ryuta Kamizono 提交于
This issue was resolved by #21687 already. But re-add args by #18856. `#tables` extra args was only using by `#table_exists?`. This is for internal API. This commit will remove these extra args again.
-
由 Sean Griffin 提交于
remove unnecessary forwardable require
-
由 Timo Schilling 提交于
`Forwardable` has been used in the past
-
- 21 10月, 2015 11 次提交
-
-
由 Andrew White 提交于
Extract native getter to attr_reader.
-
由 Andrew White 提交于
Fix warnings in multiple application tests
-
由 jbranchaud 提交于
The getter is doing nothing more than returning the ivar, so it can be extracted to an attr_reader.
-
由 Andrew White 提交于
This is primarily to fix method redefinition warnings in class_attribute but may be of use in other places where we define singleton methods.
-
由 Yves Senn 提交于
[ci skip] It's been a source of confusion that the lower-level `add_column` referenced the higher level `column` method for available options. `column` supports additional functionality like `index: true` that is not present on `add_column`. This patch moves common option documentation to `add_column` and only documents the additional options in `column`.
-
由 Yves Senn 提交于
typo
-
由 Scott Nelson 提交于
-
由 Sean Griffin 提交于
Ok, this explains why the branch showed as green. We don't run files in isolation for PRs, only for master. Active Support monkeypatches `BigDecimal#to_s`, so the generated error message was different depending on if the file was run in isolation
-
由 Sean Griffin 提交于
The error message when asserting `greater_than: BigDecimal.new` will give an error message based on how BigDecimal displays itself. Big decimal appears to always use scientific notation. This might not be the best error message for the general case, but the general case wouldn't use big decimal for the validation. And if they do, they likely need this level of precision.
-
由 Sean Griffin 提交于
Revert " Added an example to show how common secrets can be shared ac…
-
由 Sean Griffin 提交于
Revert " Added an example to show how common secrets can be shared across multiple environments in secrets.yml"
-