- 06 12月, 2019 3 次提交
-
-
由 Kasper Timm Hansen 提交于
Closes #37666
-
由 Santiago Bartesaghi 提交于
-
由 George Claghorn 提交于
-
- 05 12月, 2019 13 次提交
-
-
由 Ryuta Kamizono 提交于
Don't parse DB specific locking docs as code [ci skip]
-
由 Ryuta Kamizono 提交于
Add guide for inline around_action
-
由 George Claghorn 提交于
-
由 Ryo Nakamura 提交于
-
由 yuuji.yaginuma 提交于
This reverts commit 5bbb2a65, reversing changes made to f9e4906c. Reason: Since #36866, we use `azure-storage-blob` gem. So the original description is correct.
-
由 Ryuta Kamizono 提交于
Small doc fixes for ActiveJob::Exceptions::ClassMethods#retry_on [ci skip]
-
由 Ryuta Kamizono 提交于
Should keep the original parts for zero duration
-
由 T.J. Schuck 提交于
Follow up to https://github.com/rails/rails/pull/31872 Particularly, the closing `</tt>` tag of the documented wait algorithm had a misplaced `<`. Threw in a space between `15% (0.15)` for good measure. [ci skip]
-
由 Aaron Patterson 提交于
Add support for conditional values to TagBuilder
-
由 Rafael França 提交于
Distinguish missing controller exceptions from unrelated NameError
-
由 Eileen M. Uchitelle 提交于
Update active_storage_overview.md
-
由 Eileen M. Uchitelle 提交于
Deprecate `database` kwarg from `connected_to` without replacement
-
由 Rafael França 提交于
Remove deprecated non-symbol access to nested config_for hashes
-
- 04 12月, 2019 15 次提交
-
-
由 Jean Boussier 提交于
Fix: https://github.com/rails/rails/issues/37650 The classic autoloader used to totally unregister any constant that failed midway. Which mean `"SomeConst".constantize` was idempotent. However Zeitwerk rely on normal `Kernel#require` behavior, which mean that if an exception is raised during a class/module definition, it will be left incompletely defined. For instance: ```ruby class FooController ::DoesNotExist def index end end ``` Will leave `FooController` defined, but without its `index` method. Because of this, when silencing a NameError, it's important to make sure the missing constant is really the one we were trying to load.
-
由 Étienne Barrié 提交于
-
由 Pierre de Milly 提交于
-
由 Ryuta Kamizono 提交于
Follow up to https://github.com/rails/rails/pull/37849#issuecomment-560557239. Without this, `0.days` is considered as `0.seconds` due to #31310. We should not lose the original parts.
-
由 Ryuta Kamizono 提交于
Hide internal utility methods in the public API doc [ci skip]
-
由 Ryuta Kamizono 提交于
[skip ci] Update initialization guide start method to include change
-
由 Ryuta Kamizono 提交于
I digged the history for the internal utility methods (`convert_key`, `convert_value`, and `set_defaults`), I believe it is apparently not intended to appear them in the public API doc. * `convert_key`, `convert_value`: 71742114 * `set_defaults`: #20828 https://api.rubyonrails.org/v6.0.1/classes/ActiveSupport/HashWithIndifferentAccess.html Since we sometimes makes breaking change for internal methods (e.g. #37870), so that methods should not be leaked to the public API doc.
-
由 Eileen M. Uchitelle 提交于
Fix bug in configs_for
-
由 eileencodes 提交于
The `database` kwarg in `connected_to` has resulted in a lot of bug reports that are trying to use it for sharding when that's not the intent of the key. After considering where the database kwarg is used in tests and thinking about usecases for it, we've determined it should be removed. There are plans to add sharding support and in the mean time the database kwarg isn't the right solution for that. Applications that need to create new connections can use establish_connection or connects_to. Since the database key causes new connections to be established on every call, that causes bugs if connected_to with a database kwarg is used during a request or for any connection that's not a one-off. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 eileencodes 提交于
If a spec name was provided without an env name, config_for would return the first config that matched the spec, regardless of environment name. Now configs_for will return the database config that matches the default env and requested spec name. Additionally this commit has moved the default env call into a method because I'm tired of typing so many lines every single time. We considered either returning all configs that match that spec name or raising an error if only spec was passed, but this change has the least impact on current behavior and matches Active Record's assumptions: that if you ask for configs it will always consider the current environment. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 Joel Hawksley 提交于
-
由 Joel Hawksley 提交于
-
由 Joel Hawksley 提交于
Adds support for conditional values to TagBuilder, extracting logic we use in the GitHub application, inspired by https://github.com/JedWatson/classnames. It’s common practice to conditionally apply CSS classes in Rails views. This can lead to messy string interpolation, often using ternaries: ```ruby content_tag( "My username", class: "always #{'sometimes' if current_user.special?} another" ) ``` By adding support for hashes to TagBuilder, we can instead write the following: ```ruby content_tag( "My username", class: ["always", "another", { 'sometimes' => current_user.special? }] ) ``` cc @JedWatson
-
由 Rafael França 提交于
Avoid allocating Binding instance in HWIA#convert_value
-
由 Jean Boussier 提交于
-
- 03 12月, 2019 9 次提交
-
-
由 Javan Makhmali 提交于
Fix ActiveStorage::Blob → ActionText::TrixAttachment conversion
-
由 Javan Makhmali 提交于
A regression introduced in 764803e0 caused blobs to appear as HTML content attachments instead of file / image attachments when editing rich text content. This change restores the original intended behavior. References: https://github.com/rails/rails/pull/35485, https://github.com/basecamp/trix/issues/706
-
由 Ryuta Kamizono 提交于
Correct default value of `unknown_asset_fallback` [ci skip]
-
由 Ryuta Kamizono 提交于
Fix random CI failure due to non-deterministic sorting order
-
由 Takayuki Nakata 提交于
`unknown_asset_fallback` defaults to `false`. Refere to 6813b480.
-
由 Andrew Haines 提交于
-
由 Gannon McGibbon 提交于
Deprecate `service_url` methods in favour of `url`
-
由 Peter Zhu 提交于
-