- 15 9月, 2012 7 次提交
-
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
The caller needs to have knowledge of the rollback either way, so do it all in the caller (#transaction)
-
由 Jon Leighton 提交于
This avoids us having to manually increment and decrement it.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
This reverts commit c24c8852. Here's the explanation I just sent to @tenderlove: Hey, I've been thinking about about the transaction memory leak thing that we were discussing. Example code: post = nil Post.transaction do N.times { post = Post.create } end Post.transaction is going to create a real transaction and there will also be a (savepoint) transaction inside each Post.create. In an idea world, we'd like all but the last Post instance to be GC'd, and for the last Post instance to receive its after_commit callback when Post.transaction returns. I can't see how this can work using your solution where the Post itself holds a reference to the transaction it is in; when Post.transaction returns, control does not switch to any of Post's instance methods, so it can't trigger the callbacks itself. What we really want is for the transaction itself to hold weak references to the objects within the transaction. So those objects can be GC'd, but if they are not GC'd then the transaction can iterate them and execute their callbacks. I've looked into WeakRef implementations that are available. On 1.9.3, the stdlib weakref library is broken and we shouldn't use it. There is a better implementation here: https://github.com/bdurand/ref/blob/master/lib/ref/weak_reference/pure_ruby.rb We could use that, either by pulling in the gem or just copying the code in, but it still suffers from the limitation that it uses ObjectSpace finalizers. In my testing, this finalizers make GC quite expensive: https://gist.github.com/3722432 Ruby 2.0 will have a native WeakRef implementation (via ObjectSpace::WeakMap), hence won't be reliant on finalizers: http://bugs.ruby-lang.org/issues/4168 So the ultimate solution will be for everyone to use Ruby 2.0, and for us to just use ObjectSpace::WeakMap. In the meantime, we have basically 3 options: The first is to leave it as it is. The second is to use a finalizer-based weakref implementation and take the GC perf hit. The final option is to store object ids rather than the actual objects. Then use ObjectSpace._id2ref to deference the objects at the end of the transaction, if they exist. This won't stop memory use growing within the transaction, but it'll grow more slowly. I benchmarked the performance of _id2ref this if the object does or does not exist: https://gist.github.com/3722550 If it does exist it seems decent, but it's hugely more expensive if it doesn't, probably because we have to do the rescue nil. Probably most of the time the objects will exist. However the point of doing this optimisation is to allow people to create a large number of objects inside a transaction and have them be GC'd. So for that use case, we'd be replacing one problem with another. I'm not sure which of the two problems is worse. My feeling is that we should just leave this for now and come back to it when Ruby 2.0 is out. I'm going to revert your commit because I can't see how it solves this. Hope you don't mind... if I've misunderstood then let me know! Jon
-
由 Santiago Pastorino 提交于
-
- 14 9月, 2012 12 次提交
-
-
由 José Valim 提交于
update CHANGELOG
-
由 Sergey Nartimov 提交于
Add entry about 24594110 and 95be790e.
-
由 José Valim 提交于
warning removed: shadowing outer local variable - message
-
由 José Valim 提交于
Build fix for ActionMailer
-
由 Jeremy Kemper 提交于
use presence method instead of checking for blank
-
由 Nihad Abbasov 提交于
-
由 Arun Agrawal 提交于
-
-
由 Michael Koziarski 提交于
Implement :null_session CSRF protection method
-
由 Rafael Mendonça França 提交于
Allow passing block to deep_merge and deep_merge!
-
由 Pranas Kiziela 提交于
Hash#merge accepts block that you can use to customize how hash values are merged. This change makes merge and deep_merge compatible.
-
由 Rafael Mendonça França 提交于
-
- 13 9月, 2012 21 次提交
-
-
由 Rafael Mendonça França 提交于
Add boolean type conversion for AR::Store
-
由 Matt Jones 提交于
-
由 Carlos Antonio da Silva 提交于
Allow ActiveSupport::Deprecation features to be used by rails applications and library authors
-
由 Sergey Nartimov 提交于
It's further work on CSRF after 24594110. The :null_session CSRF protection method provide an empty session during request processing but doesn't reset it completely (as :reset_session does).
-
由 Piotr Niełacny 提交于
ActiveSupport::Deprecation is now a class rather than a module. You can get instance of ActiveSupport::Deprecation calling #instance method. ActiveSupport::Deprecation.instance But when you need to get new object od ActiveSupport::Deprecation you need to just call #new. @instance = ActiveSupport::Deprecation.new Since you can create a new object, you can change the version and the name of the library where the deprecator concerned. ActiveSupport::Deprecation.new('2.0', 'MyGem') If you need use another deprecator instance you can select it in the options of deprecate method. deprecate :method, :deprecator => deprecator_instance Documentation has been updated.
-
由 Robert Pankowecki 提交于
test local deprecation deprecator object Test ActiveSupport::Deprecation when included
-
由 Rafael Mendonça França 提交于
update ConnectionAdapter::Column#type_cast_code to be compatible with rails 3.2 branch
-
由 Thiago Pradi 提交于
-
由 Rafael Mendonça França 提交于
add --skip-ignore and --skip-keeps options to generators.
-
由 Derek Prior 提交于
Users of other SCM's can now generate rails apps that will add the "empty" directories to source control, but will not have a useless .gitignore or mis-named .gitkeep files. * Change `rails new` and `rails plugin new` generators to name the `.gitkeep` as `.keep` in a more SCM-agnostic way. * Change `--skip-git` option to only skip the `.gitignore` file and still generate the `.keep` files. * Add `--skip-keeps` option to skip the `.keep` files. It closes #2800.
-
由 Jon Leighton 提交于
In some circumstances engine was Arel::Table.engine which for separate reasons was an ActiveRecord::Model::DeprecationProxy, which caused a deprecation warning. In any case, we want the actual model class here, since we want to use it to infer information about associations.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
Previously the reflection would be looked up on the wrong class. However the test passed because the examples referred back to themselves.
-
由 Jon Leighton 提交于
Convert model name to foreign key in queries
-
由 Carlos Antonio da Silva 提交于
Update documentation for CollectionProxy [ci skip]
-
由 Marc-Andre Lafortune 提交于
-
由 Rafael Mendonça França 提交于
default is the SynchronousQueue.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
We don't need to rely on rails/queueing in Action Pack tests
-
由 Rafael Mendonça França 提交于
This allow the users to do: config.action_mailer.queue = MyQueue.new and class UsersMailer < ActionMailer::Base self.queue = MyQueue.new end
-
由 Rafael Mendonça França 提交于
We should not let the users use the ThreadedConsumer without know about the risks
-