1. 08 9月, 2014 4 次提交
  2. 26 7月, 2014 1 次提交
    • C
      Extract iterator method in AR::SchemaDumper · 75f3584d
      Caleb Thompson 提交于
      Gems which wish to tie into ActiveRecord::SchemaDumper need to
      duplicate this logic currently. [Foreigner] is one such example, as is a
      library I'm currently working on but which hasn't been released yet:
      
          def tables_with_foreign_keys(stream)
            tables_without_foreign_keys(stream)
            @connection.tables.sort.each do |table|
              next if ['schema_migrations', ignore_tables].flatten.any? do |ignored|
                case ignored
                when String; table == ignored
                when Regexp; table =~ ignored
                else
                  raise StandardError, 'ActiveRecord::SchemaDumper.ignore_tables accepts an array of String and / or Regexp values.'
                end
              end
              foreign_keys(table, stream)
            end
          end
      
      [Foreigner]: https://github.com/matthuhiggins/foreigner/blob/master/lib/foreigner/schema_dumper.rb#L36-L43
      
      Extract the skip logic to a method, making it much simpler to follow
      this same behavior in gems that are tying into the migration flow and
      let them dump only tables that aren't skipped without copying this block
      of code. The above code could then be simplified to:
      
          def tables_with_foreign_keys(stream)
            tables_without_foreign_keys(stream)
            @connection.tables.sort.each do |table|
              foreign_keys(table, stream) unless ignored?(table)
            end
          end
      
      It also, in my opinion, simplifies the logic on ActiveRecord's side, and
      clarifies the intent of the skip logic.
      75f3584d
  3. 11 7月, 2014 1 次提交
    • A
      Dump PostgreSQL primary key with custom function as a default. · 584fc8b3
      Andrey Novikov 提交于
      For example, if use pgcrypto extension in PostgreSQL 9.4 beta 1, where
      uuid-ossp extension isn't available for moment of writing, and thus to
      use a gen_random_uuid() method as a primary key default.
      
      In this case schema dumper wasn't able to correctly reconstruct
      create_table statement and lost primary key constraint on schema load.
      
      Fixes #16111.
      584fc8b3
  4. 27 6月, 2014 6 次提交
  5. 14 10月, 2013 2 次提交
  6. 23 8月, 2013 1 次提交
    • W
      Creating options for schema dumper. · 9f82fb3f
      wangjohn 提交于
      These options make it easier to change the config from
      ActiveRecord::Base to use something else inside of the SchemaDumper.
      9f82fb3f
  7. 04 5月, 2013 1 次提交
  8. 28 3月, 2013 2 次提交
  9. 26 3月, 2013 1 次提交
  10. 16 2月, 2013 1 次提交
    • J
      Revert "checking in the abstractions for valid type checking:" · c65b0763
      Jon Leighton 提交于
      This reverts commit c321b309.
      
      Conflicts:
      	activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
      	activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
      
      Reason: failing test
      
        1) Error:
      test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest):
      NoMethodError: undefined method `column' for
          test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in
      `test_valid_column'
      c65b0763
  11. 12 2月, 2013 1 次提交
  12. 07 2月, 2013 4 次提交
  13. 10 12月, 2012 1 次提交
    • J
      Move to the schema-migrations-metadata branch. · cff747d3
      Jeremy Kemper 提交于
      Pending work on graceful app upgrades.
      
      Revert "Merge pull request #8439 from joshsusser/fixes"
      
      This reverts commit ce8ac393, reversing
      changes made to b0e7b6f6.
      
      Revert "Merge pull request #8431 from joshsusser/schemadump"
      
      This reverts commit 036d3e1c, reversing
      changes made to 0c692f4d.
      
      Revert "Merge branch 'joshsusser-master' into merge"
      
      This reverts commit 0c692f4d, reversing
      changes made to 2e299fca.
      
      Conflicts:
      	activerecord/CHANGELOG.md
      	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
      	activerecord/test/cases/schema_dumper_test.rb
      cff747d3
  14. 06 12月, 2012 1 次提交
  15. 03 12月, 2012 1 次提交
  16. 14 9月, 2012 1 次提交
    • D
      Moves column dump specific code to a module included in AbstractAdapter · 4544d2bc
      Dan McClain 提交于
      Having column related schema dumper code in the AbstractAdapter. The
      code remains the same, but by placing it in the AbstractAdapter, we can
      then overwrite it with Adapter specific methods that will help with
      Adapter specific data types.
      
      The goal of moving this code here is to create a new migration key for
      PostgreSQL's array type. Since any datatype can be an array, the goal is
      to have ':array => true' as a migration option, turning the datatype
      into an array. I've implemented this in postgres_ext, the syntax is
      shown here: https://github.com/dockyard/postgres_ext#arrays
      
      Adds array migration support
      
      Adds array_test.rb outlining the test cases for array data type
      Adds pg_array_parser to Gemfile for testing
      Adds pg_array_parser to postgresql_adapter (unused in this commit)
      
      Adds schema dump support for arrays
      
      Adds postgres array type casting support
      
      Updates changelog, adds note for inet and cidr support, which I forgot to add before
      
      Removing debugger, Adds pg_array_parser to JRuby platform
      
      Removes pg_array_parser requirement, creates ArrayParser module used by
      PostgreSQLAdapter
      4544d2bc
  17. 08 9月, 2012 1 次提交
  18. 06 6月, 2012 1 次提交
  19. 11 4月, 2012 1 次提交
  20. 09 2月, 2012 1 次提交
  21. 10 1月, 2012 1 次提交
  22. 05 1月, 2012 3 次提交
  23. 19 11月, 2011 2 次提交
  24. 05 11月, 2011 1 次提交