- 01 10月, 2018 8 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
index option added for change_table migrations
-
由 Ryuta Kamizono 提交于
Don't handle params option in a special way in url_for helper
-
由 Ryuta Kamizono 提交于
Add `Style/RedundantFreeze` to remove redudant `.freeze`
-
由 David Heinemeier Hansson 提交于
-
由 lsylvester 提交于
make actionview templates marshalable so that they can be serialized during the parallel tests (#34030)
-
由 Yuji Yaginuma 提交于
Require the except hash extension before trying to alias it
-
由 Lachlan Sylvester 提交于
-
- 30 9月, 2018 7 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
MySQL supports DELETE with LIMIT and ORDER BY. https://dev.mysql.com/doc/refman/8.0/en/delete.html Before: ``` Post Destroy (1.0ms) DELETE FROM `posts` WHERE `posts`.`id` IN (SELECT `id` FROM (SELECT `posts`.`id` FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ?) __active_record_temp) [["author_id", 1], ["LIMIT", 1]] ``` After: ``` Post Destroy (0.4ms) DELETE FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ? [["author_id", 1], ["LIMIT", 1]] ```
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
No longer needed workaround for Ruby 2.2 "private attribute?" warning. Related 6d63b5e4.
-
由 Ryuta Kamizono 提交于
Follow up ae406cd6.
-
由 yuuji.yaginuma 提交于
Originally specified attributes were only normal values, and `ActiveRecord::MultiparameterAssignmentErrors` did not occur. In addition, an assertion is performed only on rescue, even if an exception does not occur, the test passes. To avoid this use `assert_raise`.
-
- 29 9月, 2018 8 次提交
-
-
由 Yasuo Honda 提交于
Since Rails 6.0 will support Ruby 2.4.1 or higher `# frozen_string_literal: true` magic comment is enough to make string object frozen. This magic comment is enabled by `Style/FrozenStringLiteralComment` cop. * Exclude these files not to auto correct false positive `Regexp#freeze` - 'actionpack/lib/action_dispatch/journey/router/utils.rb' - 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb' It has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333 Once the newer version of RuboCop released and available at Code Climate these exclude entries should be removed. * Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required - 'actionpack/test/controller/test_case_test.rb' - 'activemodel/test/cases/type/string_test.rb' - 'activesupport/lib/active_support/core_ext/string/strip.rb' - 'activesupport/test/core_ext/string_ext_test.rb' - 'railties/test/generators/actions_test.rb'
-
由 yuuji.yaginuma 提交于
-
由 Yuji Yaginuma 提交于
Updates expires_in docs
-
由 Eileen M. Uchitelle 提交于
Refactor migrations_path command option to database
-
由 Gannon McGibbon 提交于
-
由 Graham Turner 提交于
Previously the documentation for expires_in suggested that the option was available for all cache stores. This clarifies that the behavior can be supported, but is not always supported.
-
由 Mohit Natoo 提交于
* Documentation clarity in ActiveJob::TestHelper [ci skip] * Documentation for options [Mohit Natoo + Rafael Mendonça França]
-
由 Rafael França 提交于
Fix HashWithIndifferentAccess#without bug
-
- 28 9月, 2018 17 次提交
-
-
由 Rafael França 提交于
Update backburner to the latest version
-
由 utilum 提交于
version 1.5.0 includes to warning fixes that show on tests: https://github.com/nesquena/backburner/commit/cd9670146bca4df83ae2aacb95b3e6d1c1c1eee8 https://github.com/nesquena/backburner/commit/4dfa22bda1685ca1afa9f7d474df471ca6364e69
-
由 Ryuta Kamizono 提交于
Update guide for validation custom contexts [ci skip]
-
由 Ryuta Kamizono 提交于
Documentation for queue_adapter_name method in ActiveJob::QueueAdapter [ci skip]
-
由 Ryuta Kamizono 提交于
Bugfix ActiveRecord::Relation#merge special case of from clause
-
由 Bogdan Gusiev 提交于
When one relation is merged into another that has a different base class merging `from_clause` causes invalid SQL to be generated
-
由 Abraham Chan 提交于
-
由 Ryuta Kamizono 提交于
LoggerSilence doesn't require concurrent:
-
由 Edouard CHIN 提交于
- LoggerThreadSafeLevel does nowaday since 2518bda9
-
由 Ryuta Kamizono 提交于
Clarify transactional behavior of after_commit and after_rollback callbacks [ci skip]
-
由 Gannon McGibbon 提交于
[ci skip] Do not recommend testing stored object in template
-
由 Kadu Ribeiro 提交于
Since `assigns` is not placed by default with Rails, we suggested to test if the right information was displayed instead of suggesting to test if the right object was stored in the template.
-
由 Rafael França 提交于
Do not enable disabled elements for XHR redirects
-
由 Janosch Müller 提交于
* Handle more unsafe String methods * Fix codeclimate issue * Revert stylistic change [Janosch Müller + Rafael Mendonça França]
-
由 Rafael França 提交于
Add probot autolabeler config
-
由 Rafael França 提交于
[ci skip]
-
由 Gannon McGibbon 提交于
-